[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2][4.15] x86/AMD: expose HWCR.TscFreqSel to guests


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 8 Mar 2021 14:23:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=il//Mm0vq5qV1tMQrzMYc2d+Zzd83nBje/+yds0tuJ8=; b=NYn5rwea0tlm9YI6vzB35/gVtAomNnULqwepPP6jNeKWLdlEbKzdctBwEdPn5VkdYKsKVUIG90FHqtEaJIxkNCqEdwm84PMXfOWkAWm1tfzr115zwgzBsnwwzC+/1J0KmfhtNWKkmIXgbd+NfIRHsDuJsI9o9z0jV05wxd9Y6tTPAaMFSgln4tuu4haWpVwFA9iU19I9JmTdoE2JRwkE4Z5WIGFzX2PjjOmsweyWsorTVSdAGmoD/sNHB0EbCj2Gh5btAC39yBmFEFPZAP2AxF9vPOH9YpoW1WxKsyHOuMZizNVRdkoezS53V1LVn+GxBtPxk8O6SkjwwVBObjNoDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5pQ02Vt6N37awqUQYotm6TGTdid6/Q6Xkq+Da4Bb/rW4+c1NHE+hWrGnAT5Mteb7mH3U0cDDy8kn8q96ZZovp8Bfepjkh/4X1lMzEKgeXVLQUu68kfw6xvfdyVy9egtzdoOPbdyVsxTaRNtSNRxOeLmXd0GOUYO30G71yo/fcKmlpiy+gpKhIJofcXI7OG+Y4lakJiCwSIiSHtSsXZaC++3SzCvOreBdUpbnyVWGdyCWl4nDCnyouFod8M+RbEkKcpL8b6WtPGXSxUJTkoNo2b9HGhLoTCNtiVfrf5Nui2mIUidsmI6JCcyaQgU/PdQxBM5bhOgCcP0MfUQVcgTpA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Mon, 08 Mar 2021 13:24:08 +0000
  • Ironport-sdr: xwSVB7zjdkutq2fZNKgNP0aTB5o9b8mNabj8iB2p8nmcMtJFWr6AMlqYXeRNdCU0YbycmvehpP fNGExeAh/4pZhw4vUzFXW9QMYGkAWqEgHGxI/kXNVij853OHYgGagv5C0HbitOPBRzXhSCpCQz J9LUyGGFard/l0sUccZUFaHzv0hMO0dHE5qEQi+gfFNJVW2i8RDx3x6B98Q/9E6SoSpLFu+aX9 r3cI1zC64HuwLrMzm1RJcRW6QbhY2Be3LtE4p/qKxViUPtVqURValOPhphIlX43KNlt0QQoWtG TeE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Mar 08, 2021 at 12:41:26PM +0000, Andrew Cooper wrote:
> On 05/03/2021 09:50, Jan Beulich wrote:
> > Linux has been warning ("firmware bug") about this bit being clear for a
> > long time. While writable in older hardware it has been readonly on more
> > than just most recent hardware. For simplicitly report it always set (if
> > anything we may want to log the issue ourselves if it turns out to be
> > clear on older hardware).
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I realise Linux is complaining, but simply setting the bit isn't a fix.
> 
> This needs corresponding updates in the ACPI tables, as well as Pstate
> MSRs, or Linux will derive a false relationship between the TSC rate and
> wallclock.

Is there any description of those relations?

I don't seem to find any other MSR referencing the TscFreqSel bit in
HWCR on the AMD Open-Source Register Reference, but I might be looking
at the wrong place.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.