[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15] xen: Bump the minimum version of GCC supported to 4.9 (5.1 on arm64)


  • To: Julien Grall <julien@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 9 Mar 2021 11:32:47 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPNW8Ne7ZAqm2RuRdr8HcWsoLQpHtARH16WwuuXyI+E=; b=XTl1NTOntew9TmeqgY7l6Bj8Xp5XmA+29oxM91Hav9zFQxU/JLTukY7AnHUcJGJ1k+Q+wCCZc8Uz75IGmbG0r5eYAi/D69+dSr3IIJjZYFaCJ7QlaOrSAxJFngy+2LxBQg8sluF2sVlgX20xzpTa3vmShdoLI+ClSi7gyxVPIsDRG0bqV/5TIcoddqZD3amp6R5niIPs41DDDHkpCbvYe5DNlUCXQvZlw0b0pKo1rF6C5SwpBv1GiFkEPVKQQXSLpl5GK1ygwMWa8UCnnjVwysxP5ZIZ5YXmlxawhARfyLpj7QWlChVqK7iCBXCSYaLwzgTWJxO3gdb/Nt5vEKjnzQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkyEOfLOPJlDVHpxVi43qK1AxaVb4rn9FGmiAbHpp35bllblUvkkvJrwv/8toZhnK1ttmnZxvbpCEkLcJvLCzD1xHpSWWfQzS8/XqWu+tZ4+3j4rVEfoLn5JNc8XqA6jDbsrC3zkwyDbA33ASsyh9OV+ZRtMWmjfEVl+yp6lGymjrNbNWyhB14Coaqlk12F+CRzYInQK4xowDKq+q+0eqmugM7PAIWPHSCJ5dB+oYBulGf6hVo8JtIj0JHxzPGp5uiWEvG8a7pmSiW0IwrEXpArnVbn4RrJT5eDvZwx4WB1/SAQAm+aAUEc4n2tJMb6Iwz3mvVTUh6BidBv7T4mxqw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <famzheng@xxxxxxxxxx>, <cardoe@xxxxxxxxxx>, <wl@xxxxxxx>, <Bertrand.Marquis@xxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Tue, 09 Mar 2021 10:33:13 +0000
  • Ironport-sdr: LRagkpW4dziRmi7pp+0YoEGYbkda+LOmMv8k+O8lmOf86KQss5NdARY4dusaN2HEz/wNi2fT/I Eexg1WvcoaQqJwWloZEIqrbKqVYC8Ar3xHWadE48OOAZ1PxjIU7sMek2z+KN1MMB3hl7vjTfgu C+rpESfhnAuwTjuJnZjdnA1OATJjWGnuQpje5e0O9mljlL8W8FTD2i4eGdhneMCu9P2WEPIwG/ 0wvKsPr60P1ZgeM4kGVKKQcfvAG3nFsmUmx+ScA3leojFzEmWn4JFUcVCtB9aNAndFHxgMKRta I3I=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Mar 09, 2021 at 10:05:18AM +0000, Julien Grall wrote:
> Hi Stefano,
> 
> On 09/03/2021 00:59, Stefano Stabellini wrote:
> > On Sun, 7 Mar 2021, Julien Grall wrote:
> > > On 06/03/2021 23:04, no-reply@xxxxxxxxxxx wrote:

Where does one has to register to get the patchew build failures?

> > > > Hi,
> > > > 
> > > > Patchew automatically ran gitlab-ci pipeline with this patch (series)
> > > > applied, but the job failed. Maybe there's a bug in the patches?
> > > > 
> > > > You can find the link to the pipeline near the end of the report below:
> > > > 
> > > > Type: series
> > > > Message-id: 20210306214148.27021-1-julien@xxxxxxx
> > > > Subject: [PATCH for-4.15] xen: Bump the minimum version of GCC 
> > > > supported to
> > > > 4.9 (5.1 on arm64)
> > > > 
> > > > === TEST SCRIPT BEGIN ===
> > > > #!/bin/bash
> > > > sleep 10
> > > > patchew gitlab-pipeline-check -p xen-project/patchew/xen
> > > > === TEST SCRIPT END ===
> > > > 
> > > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/
> > > > warning: redirecting to https://gitlab.com/xen-project/patchew/xen.git/
> > > >   From https://gitlab.com/xen-project/patchew/xen
> > > >    * [new tag]               
> > > > patchew/20210306214148.27021-1-julien@xxxxxxx ->
> > > > patchew/20210306214148.27021-1-julien@xxxxxxx
> > > > Switched to a new branch 'test'
> > > > f332859b88 xen: Bump the minimum version of GCC supported to 4.9 (5.1 on
> > > > arm64)
> > > > 
> > > > === OUTPUT BEGIN ===
> > > > [2021-03-06 21:45:17] Looking up pipeline...
> > > > [2021-03-06 21:45:18] Found pipeline 266507477:
> > > > 
> > > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/266507477
> > > > 
> > > > [2021-03-06 21:45:18] Waiting for pipeline to finish...
> > > > [2021-03-06 22:00:21] Still waiting...
> > > > [2021-03-06 22:15:26] Still waiting...
> > > > [2021-03-06 22:30:31] Still waiting...
> > > > [2021-03-06 22:45:35] Still waiting...
> > > > [2021-03-06 23:00:41] Still waiting...
> > > > [2021-03-06 23:04:42] Pipeline failed
> > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang-pvh' in stage 'test' 
> > > > is
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc-pvh' in stage 'test' is
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-clang' in stage 'test' is
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'qemu-smoke-x86-64-gcc' in stage 'test' is 
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'qemu-smoke-arm64-gcc' in stage 'test' is 
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'qemu-alpine-arm64-gcc' in stage 'test' is 
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'build-each-commit-gcc' in stage 'test' is 
> > > > skipped
> > > > [2021-03-06 23:04:42] Job 'alpine-3.12-clang' in stage 'build' is failed
> > > 
> > > The following jobs are failing:
> > > 
> > > alpine-3.12-clang [1]
> > > debian-unstable-32-gcc-debug
> > > debian-unstable-clang
> > > debian-unstable-gcc-randconfig
> > > ubuntu-bionic-clang
> > > 
> > > Cloning into 'qemu-xen-dir-remote.tmp'...
> > > error: inflate: data stream error (incorrect data check)
> > > fatal: serious inflate inconsistency
> > > fatal: index-pack failed
> > > 
> > > This looks unrelated to my patch. Possibly a network error?
> > 
> > Yeah.
> > 
> > 
> > > =========
> > > 
> > > centos-7-2-gcc [2]
> > > centos-7-2-gcc-debug
> > > centos-7-gcc
> > > centos-7-gcc-debug
> > > 
> > > Centos 7 is using GCC 4.8.5. This patch is bumping the minimum version to 
> > > 4.9.
> > > So the failure is expected.
> > > 
> > > We may have to disable the jobs if my patch goes ahead. May I ask why we 
> > > chose
> > > to build on Centos 7?
> > 
> > CentOS 7 is still the latest and it is maintained until 2024:
> > 
> > https://wiki.centos.org/About/Product
> > 
> > I don't have a lot of direct experience with x86 users any longer, but
> > this seems to be problematic?
> 
> The last full updates was on the Q3 2020, so it looks unlikely that Centos 7
> will upgrade to a new Xen.
> 
> So this is only going to be a problem for anyone that decides to build there
> own Xen.
> 
> I can't tell whether someone may want to build upstream Xen on Centos 7.
> What I can say is the Arm64 bug in GCC 4.9 will lead to corruption, the bug
> in GCC < 4.8 looks somewhat less problematic.
> 
> So, I am sure any user would appreciate if we tell (e.g. throw an error)
> them when there is a risk that GCC X.Y may miscompile Xen.
> 
> In the ideal world (e.g if we had unlimited time), we should workaround it
> in Xen. But this doesn't look easy/possible here.
> 
> Therefore, for now, I think dropping support for GCC < 4.9 (< 5.1 for Arm)
> is the best approach. The support can be revived when someone is willing to
> spend time on it.

Does CentOS has something like Debian backports to get updated major
versions of packages?

Also, I think we do maintain Xen on CentOS using a separate
repository, so newer versions of Xen will be added to CentOS. Adding
George and Anthony since they know about that.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.