[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 9 Mar 2021 14:41:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmkRntvzIqeSF3EPYhFBuFd2sali9PIaLs65OqlA918=; b=j3aEk5EE/casAyIWJuNljN13MnSKY2HNJ8tFnPAkbQALt7eIbQ/xa96gwalK/EF88O9AkNXNW7zMpXfnN5o0j/ph5kMEDJvTzsrfMvKPxEsIZXFuqdFK6Pj11HGsJSySBqp4nhAxpiwk0o2a2TKPc5chKx9ubZ1I7QzIyl7q+2PQjiXcPwbfq7+XvTvJvtGt47LsFrp/mX+AB2ll75GUSjDHKWbU6dpK6rw2dhPh5JyNmbzxWsL/yYeDvnoEsKo08MCtDO7Zl0B80NVr8N7byCN/S4dElEeFT4GpQrRGyAR3Xpe/3V0l9othHyEOadcRcc48ce2pi76fU/Y4F9lBgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/beOX0p95uKDQn189uq4ZYSns1HkkJr8kwxcFxx8aumlPMvvLOZgAIZ6sugnUzCCL+W92N/ZtklcygwHd9AcBZ8VlmkE6IDyONtb9i473YIZa7yaLdpwspJ2heiHLTAO4vhQcFVH06Wh9I1gFop4lZvoTBuvpioPAajda9SijMzrsouZcIqJQixIfx6HjsW0tSo103tYCapt8oewaclebSurci4eS+368NJ3+ZMjBOFAOVwqZDK8dbPqNTh+KbZXgvtTCijkUakORxjADh/YGsj41ZCrADjR7LmTzVytL1tK4Wa/n+FDsxJaAVWcAEfOBGm7UWl2bQFt5tsJpEtgA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 09 Mar 2021 14:41:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7f0oAgAA8pIA=
- Thread-topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries
Hi,
> On 9 Mar 2021, at 12:04, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 08.03.2021 20:48, Julien Grall wrote:
>> On 08/03/2021 17:18, Bertrand Marquis wrote:
>>> --- a/xen/arch/arm/smpboot.c
>>> +++ b/xen/arch/arm/smpboot.c
>>> @@ -321,7 +321,8 @@ void start_secondary(void)
>>> if ( !opt_hmp_unsafe &&
>>> current_cpu_data.midr.bits != boot_cpu_data.midr.bits )
>>> {
>>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU MIDR
>>> (0x%x),\n"
>>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match
>>> boot "
>>> + "CPU MIDR (0x%"PRIregister"),\n"
>>
>> For printk messages, we don't tend to split it like that (even for more
>> than 80 characters one). Instead, the preferred approach is:
>>
>> printk(XENLOG_ERR
>> "line 1\n"
>> "line 2\n")
>
> Except of course you want to repeat XENLOG_ERR for the 2nd line.
Very right.
@Julien: feel free to tell me if you want a v2.
Cheers
Bertrand
>
> Jan
>
|
