Re: [PATCH for-4.15] arm: replace typeof() with __typeof__()

[Elliott Mitchell <ehem+xen@xxxxxxx>]

On Tue, Mar 09, 2021 at 09:27:34PM +0000, Andrew Cooper wrote:
> On 08/03/2021 13:36, Elliott Mitchell wrote:
> > typeof() is available in Xen's build environment, which uses Xen's
> > compiler.  As these headers are public, they need strict standards
> > conformance.  Only __typeof__() is officially standardized.
> >
> > A compiler in standards conformance mode should report:
> >
> > warning: implicit declaration of function 'typeof' is invalid in C99
> > [-Wimplicit-function-declaration]
> >
> > (this has been observed with FreeBSD's kernel build environment)
> >
> > Based-on-patch-by: Julien Grall <julien@xxxxxxx>, Sun Oct 4 20:33:04 2015 
> > +0100
> > Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
> 
> s!arm!xen/public! in the subject seeing as two thirds of the
> modifications are in non-ARM headers.

Gah!  Crucial little detail missing when rewriting the subject line.
Julien Grall's original patch/commit only did ARM, but when I checked I
found the other two and I did them too.


> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> This wants backporting as a build fix, so should be considered for 4.15
> at this point.
> 
> I wonder why our header checks don't pick this up.?? Do we need to throw
> a -pedantic around?

This came up since FreeBSD's kernel build uses Clang with
-std=iso9899:1999.  When I found FreeBSD was simply copying Xen's headers
it was clear this needed to be *here*.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@xxxxxxx  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445