Re: [PATCH v3 for-4.15] x86/msr: introduce an option for compatible MSR behavior selection

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.03.2021 10:33, Roger Pau Monné wrote:
> On Tue, Mar 09, 2021 at 07:13:26PM +0000, Andrew Cooper wrote:
>> On 09/03/2021 10:56, Roger Pau Monne wrote:
>>> --- a/xen/include/public/arch-x86/xen.h
>>> +++ b/xen/include/public/arch-x86/xen.h
>>> @@ -304,6 +304,14 @@ struct xen_arch_domainconfig {
>>>                                       XEN_X86_EMU_PIT | 
>>> XEN_X86_EMU_USE_PIRQ |\
>>>                                       XEN_X86_EMU_VPCI)
>>>      uint32_t emulation_flags;
>>> +
>>> +/*
>>> + * Select whether to use a relaxed behavior for accesses to MSRs not 
>>> explicitly
>>> + * handled by Xen instead of injecting a #GP to the guest. Note this option
>>> + * doesn't allow the guest to read or write to the underlying MSR.
>>> + */
>>> +#define XEN_X86_MSR_RELAXED (1u << 0)
>>> +    uint32_t domain_flags;
>>
>> The domain prefix is somewhat redundant, given the name of the structure
>> or the hypercall it is used for.  OTOH, 'flags' on its own probably
>> isn't ok.  Thoughts on misc_flags?
> 
> I'm fine with it, will change unless Jan objects to the name.

I'm fine with the suggestion.

Jan