[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 10 Mar 2021 15:20:55 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6+eE1L6ahTfk9aniyrLBSNW88CqnafowSvsmYjkTNE=; b=oBM18A4Hn7zZtNFi5UkQdWuOSZECEkHzQxCnZkYUPEpUY4jE+a5FZe++RwKEuuMOS7MRglhrTzL/TBII5AADp/8ZEAoS+7XC/7TG0/DvP8AkexOJLkxYf+VnzTDCvuahIpturzRbP9GO/Kc9LWtHvuBxbvy3x1okPsSmBBwrVywpbJn5ARtWa7xpEgveUPLM4ZtCIF2kuFmcg4cgxOrduIJEFoGqk1v/SSoFweWsNnijyEpoIjqllYCa+gcnhmxybGE94GVCvJ4Q+ccHy6mFzdisAaCNeN70xDzeqN43LskgED63VOWF9m/7QgibuWykV4aRIQTHKUxn0gD50VPm2Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhgYR3tqGq/bXzstD6SNwkGODcJNqt59pcL7uY3/QgRXu8puI8ITRtUrVHxuxfyv80GKHLmvmiM+8/sxAEmno/HWCS1NqdG7UzAi/m85lh1UyqJU5dtZr44hhVRayLy5Q064jdH0RScQDaDw4LIgSiEf7ocVJpJiaqf6oqfANSdskJDpw+og1ht6Cg4D7OXfWwo69ruD4iu6WYB+vmPFPgDj5qsOLQbglx15AWIJ2rPvJVYZ4qr/xAA224mYJKrc4C8t2eYQxRQe6VIr5bZDzy4/V7q2bSrGynXq8bTaRhpjWSrI5smd0FyHmBhu2A4qwXkRA1s5aqDUkdsEqasskQ==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Wed, 10 Mar 2021 15:21:38 +0000
  • Ironport-hdrordr: A9a23:VKG+la1TRzd/UsZAiIG/IwqjBR13eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/BIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmdJ1/Z xLN5JzANiYNzRHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcFdxi1SYzzrdXFebg9AGJY/Cd 647s1IuzKvdR0sH7qGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnm4j41VTRTzbA+tV XUigCR3NTej9iX6D/5k1XS4ZNfhcf7xrJ4ZfCkp8AJJlzX+32VTat7XbnqhkFNnMiO7xIQnM DIs1McOa1Img7sV0WUhTeo5AX6yjYp7BbZuC2lqF/uu9bwSj5/K+cpv/MgTjLj50AtvM5x3c twtgrz3fcnbmKj7VDAzuPFWB1wmk2/rWBKq590s1VlXZYDc7gUlIQD/SpuYeQ9NRjn44MqGv QGNrC42N9qdzqhHhTkl1V0zMfpdno+GQrueDl5huWllxJSnHx/0nICwt0eknoq5PsGOul5zt WBHaJymL5USMgKKYp7GecaWMOyTlfAWBTWLQupUBraPZBCH0iIh4/84b0z6u3vUJsUzKEqkJ CEdF9Dr2Y9d2/nFMXm5uwLzjn9BEGGGRj9wMBX4JZ0/pfmQqDwDCGFQFcy1+O9vvQ2GKTgKr SOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+c06So/jMNpbhuoXgAbXuDYuoNQxhdnL0A3 MFUjS2Dt5H9FqXVnjxhwWUdGjqfmD54JJsAInX9+Ue0+E2R8lxmzlQrW78ytCAKDVEvKBzVl B5OqnbnqSyonTz3Wug1RQvBjNtSmJupJnwWXJDogEHd2nud6wYhtmZcWdOmF+OJhp1SdLqAB dSzm4Hv56fHti1/2QPGtinOmWVgz84v3SRVaoRnaWF+IPDdo4nCI0lHIh8Dx/CGRAwuQsCkh YCVCY0AmvkUh/+g6Ssi5IZQMvFccNnvQutKclI7VTFtUudoskrbmABXyGnVPOWhQpGfUsQun RBt4skxJaQkzemLmUyxM4iNkdXVWiRCLVaSDieaJ5sgbDtcgFoRWKsjTiX4itDI1bCxgE3vC jMPCeUcfbEDh54tmpD2qjnyl9ya16QZll9cHx8rI17G1nXo3ob657/WoODl0+qLncSyOAUNz /IJQEfJQ5j3Pib/h+YkjTqLwRq+rweesjmSJgzebDa3X2gbLCSnaYdBvlO4dJOL9b1qNIGVu qZZi6YJD71EPkSxgSQv3opURME8EUMoLfN4lnI/WK41HkwDb7uO1xgXagcOMzZwG7+RfqEua 8Jxe4djK+VCCHWZdGHw62MMGIGBRPXvGKsT+Yn7bpTprk/sbNvH5/dFRvEvUs3qikWHYPRrg c5Rq8+3ZXqfqlIVOYWczhC/lUomM+URXFb+DDeM6sbRxUVk3TfP9m1+LLGprokP12ZqGLLSC 6i2hwY282AYjCK2rEbAZ8hOGh6aEAz73J54eOJHregQTmCRqVm/FCgNGW6f6IYYK+ZGa8Iph IS2aDFo8anMw750hvXpz11P+Zn9HumW9q7BEapFfRT+9K3fXSKja3C2r/9sB7HDR+6YV8fn4 tLaAg5adlCkCAriMkP6ReJI5aH6X4Noh95+jFollnkx4ig7iP6JCh9QHzkq6QTeyJSPHiOhd nC6s6C2h3GkWN45aU=
  • Ironport-sdr: jfqrJkF57zbpyDiou5eauw2q4i4uhyPjNG6iCKLatSD1+jkbfNCWiHrTThud5QwsNSnmPdbpKS AYnSl9xgFQYZd0maVox1zg10QgYRacV/HAod+yqjX4pMQJxzp4xCmAGMHIDvjw4Zg3DlUjqian aC/ShkaTgUqBjlw28jW4LcfE3/4ggnUT8iMwb+LqTvXz1c/XqGrLmkgf0Tksg6jhEefWoi+fsM +cF35hflepRUHIAaMiyzAPEpZjOCmFktZBze54iJBiofg7kNdh51glRxFVf7R1pncY2yE65b7e wPM=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/03/2021 15:14, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ 
> header guard from public API"):
>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library.
>>
>> That change actually broke the build with:
>>
>>   include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t'
>>        ioservid_t *id);
>>        ^
>>
>> as libxendevicemodel.h now uses a type it can't see a typedef for.  However,
>> nothing noticed because the header.chk logic is also broken (fixed
>> subsequently).
>>
>> Strip the guard from the public header, and remove compensation from
>> devicemodel's private.h.  Fix the dmop design doc to discuss both reasons
>> behind the the ABI design.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Paul Durrant <paul@xxxxxxx>
>> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>>
>> v2:
>>  * Patch dmop.pandoc as well.
>>
>> For 4.15.  This is a build fix, even if current staging can't spot the
>> breakage.
> Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>
> I am going to stop giving acks for this kind of thing fairly shorty.

Thanks, but you already release acked it.  This is the requested update
including the documentation change.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.