[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2][4.15] tools/x86: don't rebuild cpuid-autogen.h every time
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 11 Mar 2021 16:29:27 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=geDBbU9EjX8Jnex9QKdowsFek8INI4IykGSx1N6fHto=; b=BcjEOH9G6WyGGGs5P8wKvwoUIVWFpUyIdTUvxl8A1ToF+gHyEIJw9/GjVgQhINi2/kEOPgcUTZZ+YQcxHfboi5VvpLvIfWxcDcniWaLVJkQ3rY/0mA5tRN+zgKoHIj9KLrSCOM7eFeeyY5psdfJ8cfpR2Z4KXyZ1xfSg8I91tYl9hU3FJhuiDuhgBDkIz2KDzxKBbKXuSLbAa31sOIs1LLPqWFemxDa8qfYTgqoAWqNT4uEqXTcS56eqzO+AlMRcOHc9bvG5zYTobrOS+22gnqdLXfXeyJ6A0dgrO9NX4o0DAUIb5z/G/cYS3zJiA9V2PuDphafYgfeR/BKIxnsbpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fe54hH1DCj+HsbhRlIunzSp23ZvVkK2plkPGeAJ9v7rNqvUhiZ+HKBllyrNW06L+aNmpiXCBSF/81sUjnR6KOF2kqlNh8MsgMhMzIcDuKrnHF6Hg8bJRhkKzkaYmvinKZs1y+S4x/2jrhGKWswXCdOLPrOJqRB7dVfrg8O5rIWBPnD98LrP4dDjlZxpj/rpnbj8qlk/oOnRdIuh0DhTPKjJtJWfvp5JYMNrVhwq32CDSX1D3iMimwtkHGzZMnDahvAytLoOKjToD+n/2uqx3R5hSoJP6MZoUthM5i45HKdi0Lyg9K34gPnIin0Di4569PQoJTs6Y8ondk4/bU3WH5g==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>
- Delivery-date: Thu, 11 Mar 2021 15:30:16 +0000
- Ironport-hdrordr: A9a23:52i+bK9CckXCcT2ZFFhuk+FLcL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2CmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXHOlAuWe/fq9rX0K/3eBJuPW9c1CCirxONrIT7HR+RwwsEX1p0oIsK3G DZn2XCl8Cemt6hzBu07R620713n5/bxsJHFIiwjKEuW0nRoyKJQKgkZLGYpjAyp4iUmSYXuf 3BuQ0pMcg2y165RBDMnTLX1wPt0Ckj5hbZoDfy6xaTwr2aNUAHIvFMio5DfhzS51BIhqAG7I tx03+ErJ0SNBvcnU3Glqn1fit3nUm5q2dKq59rs1VjV+IlGdhshL1a1kZUHJAcJTn9+YAqHc J/Zfusmsp+QBe0aWvUsXJox8HpdnMvHg2eSkxHgcCN1SNK9UoJg3cw9Yg6pDMt5Zg9Q55L66 DtNblprqhHSoszYbhmDOkMbMOrAgX2MF3xGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUXtD3FRCO37GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7CLTCDclYziMGtys9vQ/Hzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk7odA+d1WSot/aC4Hju+DBGcyjZobFIHIBYCfSE3 EDVD/8KIFr9UawQEL1hxDXRjfMdyXEjNdNOZmf29JW5JkGN4VKvARQo0++/Nu3JTpLtbFzWE N/Jbjgg56qvGXexxeN00xZfj5mSmpF6rTpVH1H4SUQNVnvTLoFs9KDPUdfwWWAPR06a8/NCg ZQqxBW9MuMXtKt7BFnL+jiHnORjnMVqn7PZYwbgLe/6cDsfY59KI0nVqx3HQDiDAd0hg5ulW dGZGY/NwziPwKrrZ/goI0fBenZedU5qhysO9RopXXWsljZmdsiXUIBXzmlUdeehCEnQzY8vC w3z4YvxJ673Rq/I2o2h+o1dHlBcn6eDr59AAOZX4lMgbzwdAZsTWCFuCyCh3gICxnX3nRXol akATyfePnNDFYYgHxe36rw2H5fd2mWfStLGztHmLw4MV6Dlmd40OeNaKb27nCYbUEaxPoBdB vfZyEJHw9oz9er9RKclTqYD086zpE2MuG1NsVkT5jjnleWbKGYn6APGPFZuKt/PNf1q+kRTK axfRSWID6QMZJe5yWl4lIefA96p3kvnam2hFnL7G2k0GU+BvSXClJ8XL0fK8yd6W+hZ/vg6u QMsfsF+c+LdkP2YZq67IuSSRhpABbau3S3QOElsoo8h9N7iJJDW73gFQLV33RG1igkJMj6lE kiUL12iYqxT7NHTog3QWZl5VInm9SEEVszviH3CuE4e0sxj3WzBaL/35P47Z4uCFaGvg3+JB 229DBc5e7MW0K4pPQnIpN1BWRdc04n7nt+uMuEao3LEQ2vM8VO5kCzPHP4ULhTTsG+aPgthy c/x9GDhOmMcSXknCjWoDtgO6pLt1+dfvnaOnPEJcd4t/qgOVqNhaO24Mm8yBfPIAHLFHgwtM libkwfbsNKlz84qpY4uxLCE5DKng==
- Ironport-sdr: Tur9VbaaZls+DPT3gNvOkx1OCxxtH75J4KzifoTCx5iE1r/JEQV7n712KUSCewb6W58yWnpIA2 UnmEAfAJsS01GITnudyHCItCkQ9BLcGTeqKwzMMLfxvuwHXRY/0qgFPLg5hYO4YBr7YX4kYP5O 9o36NA8pGp5lDifFwmJGzDYMsswkE/lrau3wAwbfuJm9p5dux5a1P/XNxKT0mt9kJOquE61qhE 2/0wm0D0LvLLKVk33pBVJvQIr7Gorz5raoDGSYXxInyYIrVWJxDDsqosH2j6hOnuY2yjTkWKJS noM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 11, 2021 at 03:40:05PM +0100, Jan Beulich wrote:
> The first thing the "xen-dir" rule does is delete the entire xen/
> subtree. Obviously this includes deleting xen/lib/x86/*autogen.h. As a
> result there's no original version for $(move-if-changed ...) to compare
> against, and hence the file and all its consumers would get rebuilt
> every time. Instead only find and delete all the symlinks.
>
> Fixes: eddf9559c977 ("libx86: generate cpuid-autogen.h in the libx86 include
> dir")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: Different approach.
> ---
> Ian did suggest to pass -0r to xargs (and -print0 to find), but I
> couldn't convince myself that these are standard compliant options. We
> don't use any special characters in file names, so -print0 / -0
> shouldn't be necessary at all. The stray rm invocation when there is no
> output from find can be taken care of by passing -f to it.
Why not use `-exec rm -f {} +` instead? That seems to be part of
POSIX and is likely nicer than piping to xargs?
>
> --- a/tools/include/Makefile
> +++ b/tools/include/Makefile
> @@ -19,7 +19,7 @@ xen-foreign:
> $(MAKE) -C xen-foreign
>
> xen-dir:
> - @rm -rf xen acpi
> + find xen/ acpi/ -type l 2>/dev/null | xargs rm -f --
Do we care about leaving an empty xen/libelf directory behind?
Thanks, Roger.
|
