Re: [PATCH v4 0/2][4.15] x86: guest MSR access handling tweaks [and 1 more messages]

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Jan Beulich writes ("[PATCH v4 0/2][4.15] x86: guest MSR access handling 
tweaks"):
> Largely to re-base patch 1.
> 
> 1: PV: conditionally avoid raising #GP for early guest MSR reads
> 2: AMD: expose HWCR.TscFreqSel to guests

Jan, thanks for the v4.  Roger, thanks for your reviews and for your
mail to committers@ (on Wednesday).

Andrew Cooper writes ("Re: [PATCH v3 1/2][4.15] x86/PV: conditionally avoid 
raising #GP for early guest MSR reads"):
> I am still of the firm belief that this is the wrong course of action.

Andrew, thanks for your clearly stated opinion.

It seems to me that, even having taken Andrew's strong objection into
account, Jan and Roger and I all still think this patch is the right
thing to do.

With my release manager hat on I would prefer not to spend any more
time debating this; and, the discussions do not seem to be producing
any new information.

I spoke to Jan on IRC and he confirmed that these patches are finished
on a detailed technical level - that is, there is no reason not to
commit these patches, except for the above objection to the whole
principle.

I therefore intend to commit both these two patches (v4) late this
afternoon, say 5pm UK time.  If anyone thinks that this would be
improper, or has a new reason I shouldn't go ahead, please let me know
ASAP.

Thanks,
Ian.