Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

["Hsu, Chiahao" <andyhsu@xxxxxxxxxx>]

Andrew Lunn 於 2021/3/12 15:52 寫道:
> CAUTION: This email originated from outside of the organization. Do not click 
> links or open attachments unless you can confirm the sender and know the 
> content is safe.
>
>
>
> On Thu, Mar 11, 2021 at 10:59:44PM +0000, ChiaHao Hsu wrote:
> > In order to support live migration of guests between kernels
> > that do and do not support 'feature-ctrl-ring', we add a
> > module parameter that allows the feature to be disabled
> > at run time, instead of using hardcode value.
> > The default value is enable.
> Hi ChiaHao
>
> There is a general dislike for module parameters. What other mechanisms
> have you looked at? Would an ethtool private flag work?
>
>       Andrew

Hi Andrew,

I can survey other mechanisms, however before I start doing that,

could you share more details about what the problem is with using module 
parameters? thanks.
ChiaHao