Re: [PATCH for-4.15] arm: replace typeof() with __typeof__()

[Elliott Mitchell <ehem+xen@xxxxxxx>]

On Wed, Mar 10, 2021 at 09:54:57AM +0100, Jan Beulich wrote:
> On 09.03.2021 22:27, Andrew Cooper wrote:
> > 
> > I wonder why our header checks don't pick this up.?? Do we need to throw
> > a -pedantic around?
> 
> That's a long-standing issue with the checking: For issues to be
> found in macros, the macros would actually need to be used.

This is key since only the hunk for xen/include/public/arch-arm.h was
found during a build.  The other two hunks were found while preparing to
submit this to the Xen Project since I checked for other occurrences of
typeof().  Had I not spent the time to look, the other three uses might
have generated 2-3 additional patches in the future.

Also notable the ARM portion was originally found more than 5 years ago
(between 4.2 and 4.6), so this had been lurking for a long time.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@xxxxxxx  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445