[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically


  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Tue, 16 Mar 2021 17:03:00 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpdsNT/0W2Q+Lc807unc1Uhwzf7v4rCqEvbSwrwDcTA=; b=VSoVOJJrph1vVB8gaJ225dHGev5FUkjDbsxpXShtNF14fLSgkoVyRbkN77rRrbPwAkJDcelRJFUMT274S8ci90GoYAyf2CDcO1ve3VqjE5B1Z8yGSgncx89/vikgXG/xbZBiBU/XmjT4Mn6wfYIINd0I2Y3/WYsYWeX0Dzu7HnuvordbfdDTPMcVGxs1u21CLKmZP/zXbooTvJa7IExNK+9DFA8Pee2vN3xxN2Tb0mWMlNN9HwvFG5tQ9wTx/DVY+PqRl/5GLXbvMAJS+JyZ2hge7+txN8ns+5Eu32bSuq25D23s4p8rParBkglxt12v7lOIfWfTCM0wH8Yi2SJYDg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ioPX2LlDtrY88Ht/OLSsAz8hRW8AIv4IxPCFTT8SejB3BfUNrUftKQhgWQ7wYgLX0x8gFr6tpnGZUXYLL/YRV+aBYCTyW6GLGMC8C10mkJLiIEUf/A96odzs63DECXndupGG6oSbg5ivTaMGtvFitWyMMzxm1TybFAsIDnL59XYZBeFPupwqyebR1cbw6hVSPyec23uqgs8MJTZnStTzLzSPmuNdecgMGwzcvNUQsAgndJfRsyT6dbwgUSOcioTKBQeyOuTd9ebEh3w9AC5b5q/Yt6u7/yg+viPLngFz0UX4wTiFrcuZq6fG0+9xWLAnNikVzDMYQaZkSB/Mabt1cw==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 16 Mar 2021 17:03:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXFRDxe8GGVnZwKkOnqqCxaz3gPqqGxKGAgAAdrQA=
  • Thread-topic: [PATCH 1/5] xen/arm: smmuv1: Handle stream IDs more dynamically

Hello Julien

> On 16 Mar 2021, at 3:16 pm, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Rahul,
> 
> On 09/03/2021 18:19, Rahul Singh wrote:
>> Backport commit 21174240e4f4439bb8ed6c116cdbdc03eba2126e
>> "iommu/arm-smmu: Handle stream IDs more dynamically" from the Linux
>> ernel.
>> This patch is the preparatory work to fix the stream match conflict
>> when two devices have the same stream-id.
>> Original commit message:
>> Rather than assuming fixed worst-case values for stream IDs and SMR
>> masks, keep track of whatever implemented bits the hardware actually
>> reports. This also obviates the slightly questionable validation of SMR
>> fields in isolation - rather than aborting the whole SMMU probe for a
>> hardware configuration which is still architecturally valid, we can
>> simply refuse masters later if they try to claim an unrepresentable ID
>> or mask (which almost certainly implies a DT error anyway).
> 
> For single backported and verbatim commit, it is common to keep the origin 
> tags (I usually indent them) to show who is the original author of the patch.
> 
> Since 7936671da9fbf645d6bb207608f7b81c27f992de from Wei Chen as an example.

Thanks for reviewing the series. I will add the origin tags in the next version.

Regards,
Rahul
> 
> Cheers,
> 
> -- 
> Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.