[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 17 Mar 2021 13:45:51 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy3NqsFP3OnRutrrUYLpp1kAnLMNdN/HNf9rhiY+1I0=; b=YcvTJdjwzVdayG+37+mRu7leWothMDT9rpgWUPa8Z7MlXEpMuCUE5ubcNRHnVFCVRj+t+pCrJFSamI37Htak76QclUy58+SBDz0MA901DrEoBbn8zoBBYI+KYuaUEGclogJ9xQZ7SvJY71VkKguLrRTXYK25ndPACmf+3r7cWbIMfo4e/GykzgrOIxCAOi9n9NPG6fJalNoNuVRWXDTIot1b2+PhNyIJUnOn1uxG3cmhNbJRm9xPN0pBBEuxQyawWMmmPdNSFNXHKIwZ5k/UNYuPakn60wTzkIjim7OMYxvKGBjakoRlDAsCqm4mSqlT5bO1UbT6JE0aTQVfWfe4TA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NNhWkU/888rPyhgcktrIERNeJptgOHOLszNW/nYSbPFv22sKMEW/wpBtuDiiF6fXr7IuIqcOlBqorIPPr7FDKVMP2+wiUgaQun8XuvA8Yn5P5/og0IHkrFyo8bFrPAiDpXrPk++Z8dNrfo/vUixA4a+xNW5O47DpXFKoPs4p1ThAihnE6lmJfz5favTc7rQZaFUWRxxkGvDOIdGXAc+4fOkoBIY+N1uxNwIGmSzwUNrZslocUY/D7eqCAHw5yzbhPCx9+z1EF4ZuSF7gt3HOIBVPskxizU1f1Dy1XyiK8nqkOCp8j+94BYqR7Fm92OdyAMCzsBcYpr/CH6/rTF3ISQ==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Delivery-date: Wed, 17 Mar 2021 13:46:07 +0000
  • Ironport-hdrordr: A9a23:G0Ykv6pB7WYLrzwkKhd/NDMaV5trKNV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQV3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIBg/I 9aWexFBNX0ZGIUse/T6gO1Cstl5dGB/ryhi+u29QYTcShBQchbnmBEIyycFVB7QxQDIJI/Go aV6MYvnUvfRV08aMOnCn4ZG9XSvtGjruOpXTcqJT4CrDOPgzSh9aLgH3Gjvis2fjtTzd4ZgB P4uiPj4KHLiYDf9jb90Cvp441SiJ/dzLJ4dbCxo+w0DhmptQqyfoRmXNS5zXEIicWi8kwjnt WJgzpIBbUI11rrcmu4oQTg1mDbuV5FhhOSqi77vVLZrcP0Xz48AcZa7LgpDyfx0EY8oMp6lJ tCwmPxjfFqJCndlyfw7cWgbWANqmOIoGEvmeNWr3tTXZp2Us4okaUj/VhYGJpFISTi6IpPKp gWMOjg4p9tADenRkGcklhE5fSNelgJWjOqBmIlneO0/VFt7SpE5npd4PZasmYL9Zo7RZUBzf /DKL5UmLZHSdJTRb5hBc8aKPHHSlDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop LcS1lV3FRCOH7GOImr5tlm4xrNSGKyUXDG0cdF/aV0vbX6Wf7NPTCcTkst1++tue8WDMGee/ vbAuMVP9bTaU/VXapZ1Qz3XJdfbVMEVtcOh9o9U1WS5s3RLInnsfHabebTKLLhHS1MYBK6Pl IzGBzIYOlQ5EGiXXH1xDLLXWn2R0D59ZVsVKjWltJjj7QlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+e+rWmy9mDY8nVxNnNmfwBoyYSld0kPiR4BMkvyf7pGkc6YY3pu0HyOIQI6SdjXHg 5Zr1F+4rm2MJSU2CAnB7ucQyenpkpWgEjPY4YXm6WF68ugUIg/FIwaVKt4EhiOCwZ4gh9wqG BIaBYNQ0jWEj+Gs9T9sLUkQMXkM/VsigaiJsBZ7U/FvUKHvMc1Wz8wRDi1S/Oahg4oWhtZjl B86LUknbKFgDqjQFFP2NgQARlpUiC3CKgDJBmZbI9U84qbCT1YfCOvv3imrD0dPkDt7F4fg2 T9Kzb8Q4C6PnNt/lZC0qjr91tocH66ZEwYUAEgjaRNUW7CvGp/lfWGbLap03aAA2Fyl901AX XOZD0PL0d1y9qqzx6JiHKuFXsr3IhGBJ2OMJ0TN7vX3G+hbJeFn70cH+JFuLJsNNXnqeULUf 33QX7LEBrIT+kt3RCZ4mwoMjVuqGQ11dfh2Bjs92K43GEjEePfSW4WGY0zEpWX6m75SrKT3J 9kltIpra+OMn7scMSNwaa/VU8TFjrj5WSySf0k7YpZt74otKZiW5PcVjzF3mwv5mRsEO7E0E kaRrh3pKrMMJN1f9EDPy9Y5FAtnNSKIFBDiH2nPsYOOVspiWPXe8mE6abSqac+RlaMrgvoOV WZ7kRmjqv4dhrG37sdF691O2hddFM99WQn5u+EeoHKYT/aKt1r9EamM3O7bb9WQLWEH7JVtR ph/9SUhYasBlnF8RGVsj1hLq1U9WG7Bcu0HQKXAOZNt8e3IFKWn8KRkYOOpSayTTuwcEIDg4 JZMUQWc8RYkzEn5bdHmRSaW+jyokg/lUFZ7iwinlnx2pK+6GOeGU1dKwXWjtFXWjZUW0L4x/ jt4Kyd1H7n5iJC1oSGHEBMfstWE9xVV5PpNU5VWL4tla/t+7BqjjVIYR8oAWJ5gDfh3/l+1b P83PnJQeXtBXrhJFppw08IOqdk2igw7W1Qecm36pywJh8aEeMFGPMz7IFbmjABkCm603QMKx F28gA43IDEKVLqe2lmHa/1hI3snVwWorOB51AGngQepnq3zFWH/177kMa+tyBq8ynTrgp7pb 6cQzV0iiBDrQJjybFgNH3IUWOEewLwDHrniK8zfXtiAiQzzu9uihzJJawCjIq/wGppti5TOF l4/5i7UmLEDSyPHtjxJi2wHNu7ANRuc+9cU1BzWkKeJVDBgNAsVRrGd9dqywW0lnoPDaaIPL m6YAj1Nuh7wIUAf6r2Q4Cfgs/S1g9Ws3EKxriL+0C4oA==
  • Ironport-sdr: ZVlHBufiYEkPiZFnMEELk08j0xve2b3z+pdjV+YQp7BPTcOEcRRIMZCx2UPVTs9GA5Jctl/Pg5 WgPc75VQi5CLuClDJAwyUjVCMMijqPKh41ji+Ke7lGknSdVaQV11g3eaLhEhu0t+kKBZOr4GJH h9qA+P96WdYSsCZnrN5K64VLygP5QjgbGWAg56uCYFiAQePwTO6QH0Jt40SDIpQEMI2Ui4K6UK YW95NcAHHJEOn/x1+aWve2r4v0/Jju4ECxpm9ZkKjsD6p5Ce9SSlEKyDOTynGZapf0nn+ayqyj hTI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17/03/2021 13:37, Ian Jackson wrote:
> I have read this thread and with my release manager hat on I feel
> confused and/or ignorant.
>
> Patch 3/ has a good explanation of what the problem is it is
> addressing and why this is important for 4.15.  But then there is
> Jan's most recent reply starting "I find all of this confusing".  Jan,
> can you please tell me in words of one syllable what the implication
> of that message is ?  In particular is any of what you say a reason
> for me to withhold my release-ack ?
>
> AFAICT there is no explanation for why patches 1/ and 2/ deserve to go
> into 4.15.  We are late in the freeze now, so I would ideally be
> looking for a clear and compelling argument.  I'd also like to
> understand what the risks are of taking these.  Can someone please
> enlighten me ?

To make the code in 4.15 match 4.14, so patch 3 can be written in the
first place.

Also, as a side benefit, patches 1 and 2 reduce the quantity of logspew
from the impacted MSRs.

We cannot simply take patch 3 as-is, and say "4.14 and earlier" for
backport, because that still forces end users to specify msr_relaxed to
unbreak their Solaris guests, which is usability regression vs 4.14

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.