[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure
- To: Christoph Hellwig <hch@xxxxxx>
- From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
- Date: Wed, 17 Mar 2021 13:51:56 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AuI7WZwh+THy66uOk/dX3AZL5VQVLUSbLO1vN8BYNn0=; b=oSYlbGapY7yAud4JHRULDxIdcFgcRiWIVoYYb1MMcgGKqy6sGKKDR6sYcucR+6huAwI7iTbrLSWiW0hhStMiAu7t2Aoezm1GPFZvH4U5vvs4uhEof+uZrAGo5wdWClXFR1obEnYK2HrB9i+9p4EsBLV2A9ZVo+0P+iYs8WgmQ9A719Ch04jnrTP6V8OTcvKTQkTO41Eo96mjpzQUfhdvFy8Q1kh3mQbR9NgZaaegoFsuRlXmfWggICuTwkIM5I+k9bjNL2NpKwIlVoiFtqsYFuirPVzb3elhERj7twf8OEScJkMb6upOJ07V/d1Ty8Wtw4woAZfoZyHfXbR5ZlmH1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kcn/OjkRge8LRRP9YU/yXyzkWHOmNItw1fflnCQtErFqe43UOBpVw/FXv2hgRoNipg6yCqhebnN8HMd+pYJwPVuUgl6jY/noZ/u+hrjO8j9kkVP40XTNyKcBCTD7mwcmV/URn9aWl7ceK/hz8ns6oTU7mh195Ur8WxXn3LmEZenbl7jsx8plEe14shYAw0gE0DHH4hH1tHk17Co7VYohUf3EWIVoTCS4pkQQoziIM7mjBBPeqP+Bb+deOqdvEeAqRT1i7OzgXmGQdbXC+TdBxf+rCea73JMHUm+Rpr6P1B/zOAtHECHQdlgXiY3mZua9jUctRyD5m7SxiMUxqzJgEg==
- Authentication-results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=oracle.com;
- Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Claire Chang <tientzu@xxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Dongli Zhang <dongli.zhang@xxxxxxxxxx>
- Delivery-date: Wed, 17 Mar 2021 17:52:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote:
> > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t));
> > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE);
> > > - if (!io_tlb_alloc_size)
> > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n",
> > > - __func__, alloc_size, PAGE_SIZE);
> >
> > Shouldn't this be converted to:
> > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE);
> > if (...)
> >
> > Seems that it got lost in the search and replace?
>
> Yes, I messed that up during the rebase. That being said it magically
> gets fixed in the next patch..
Yes. However if someone does a bisection they are going to be mighty unhappy
with you.
|
