[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 19 Mar 2021 13:11:26 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jM8qdwwfFOCDRt77RJ+JAWvBOuX8McM9bLag1QMCR4=; b=GbITMBmap9IB46VPPX6T/nTXHt6n6hjZLZh+KJRgdQl9kExNxkaassviP4aHJAs2Z+35KL4J1Myy2dEadj6+/WgQxauQ/qgOIj5poem5PL4x2Afjfn480nCOFL2ven0acBwtu0Chhc0yqHyMtHmkdaxsQp8fYXM1LSUSfyoWaP46CYoqBnuieejaXY3cgIlHt8kR2LaFVO7b1m6Fn2Us/sGdxngrH/+JnR9kX3edV/Sh5JN/anyUJAPI7J+k7cTKAJ/5UTTWcnrV3byMrB1bAUoowlgKmkL+Vlkd2VNPYVZRLmYVFhR7UdXncNJqYrp/gtGSjhmIDJ+KFbdIEdWcZQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vy49PQcXlplBqhc+qBHIwlcuZ0CJLLS5NW5YxDfu3QbfiZzgPyeSS6B+Thr6joehFuffjKWqbHpPwrR8IibRJfTIpzAW7Q4CrKdncsEAFbAAUs3euJbs4ohri4hBTuoSTDVX72frhXU/tzkhehyKG6IPVDSUHea0jRSpNCVgl8Lv2TwFbUNibhIhgYOP27hNcQP8zVk2yFr13PT0aXMA1KLy7f8ZWfTTcnuq4cUglAi3yJWSy8OdCsqP/O3JEtCIFU8Wn7udtskZbMVNW/y6PTmXsIU5GU9z5fpcKuftnXv+oDyR97lUEOiqi7i1AhbxRsUO1qkz4eMWIL2VncvH4A==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 19 Mar 2021 13:12:14 +0000
  • Ironport-hdrordr: A9a23:DwYNcKiDe/z3+Iq1JOG6WSaSNXBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg==
  • Ironport-sdr: MrEMg0GOTf7pGvt5JzjoznEDeOFcIHheHcLas2l3Md0DDioUZc5VfxUCEE5veFy/Ykhsznjtyd ScvgaocgvlL6YOOYoBj/Tu646y1NwVb9LqYQ4RAXQEf+Z2Sr/5R/sNkIoZswq5zDfAZVia3/a6 VMxRDGR9CDznHiZw/xn4BrWWU4HyFJjKPHXhXrHKhcnPzbieS43nYFjjo/CmtGVEklPSjj0G3d xFAyVy7wSQpBSO7RIy3Mq493tCoo1bITpun9RgDIAdHZMW/8/KnK0eqPmV4SQXePdvVoJ3SS4Q uqs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18/03/2021 09:35, Jan Beulich wrote:
> On 17.03.2021 14:37, Ian Jackson wrote:
>> I have read this thread and with my release manager hat on I feel
>> confused and/or ignorant.
>>
>> Patch 3/ has a good explanation of what the problem is it is
>> addressing and why this is important for 4.15.  But then there is
>> Jan's most recent reply starting "I find all of this confusing".  Jan,
>> can you please tell me in words of one syllable what the implication
>> of that message is ?  In particular is any of what you say a reason
>> for me to withhold my release-ack ?
> Answering the last question first - I don't think so. Something may
> indeed want doing here beyond what we already have, and it may well
> be precisely what Andrew is proposing, possibly just with extended
> descriptions and/or comments. My confusion about patch 3 is that it
> (a) claims behavior in turbostat that I can't locate and (b) implies
> (describes) behavior of code that I find entirely unexpected (as in:
> not making sense to me).

Turbostat was discussed on the LKML thread where KVM fixed the same bug,
IIRC, but I'm struggling to find the reference.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.