[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: introduce XENFEAT_direct_mapped and XENFEAT_not_direct_mapped
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Fri, 19 Mar 2021 11:00:43 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yTvQAh21u5lJPTBC4tu7w6h3+TwtqNoE7L4tquNswHI=; b=oCiL0lplrA5gdkcQ4lbCl2r+Hl+GgGwbfeymh7FCkGOO1CooXVcWJqUMxzjTS+ULUz66m62y0xGqRvCe2/RpaTMedtBW4fJxaPKp0/cF+vn0vugLhhc4ziMXGtn2NVHbOm17w0XEsIQPNjudUYI09DNR0nt1tk/WEuj8PI4Lw4Ma6rT/2VAv9DIwqC8pBXo5s6jpm3KV/QC3CnFgb2GcXQHgcz8uAhV2SXq6P90EVb/tuv6pC0CH6ivyR4vlMFO3QVqCWOzdI3vEJUd6ak79Ftgs9sx9vPs3L87POElayA+NbGHN4QShoKCFQv3exdED7yfT6aaD2Jw+kLrvQRSkUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q542thT8pik9jqMNJG88KY2YUKVs6EsWRSKZry8mrUG5rgBri+hyOWkSDD0Ckp0rW7xib37bB96iCIePEVMLOj8wTwVCx6+XoPIFhNi0O5j1jcQ5f/Q/zLfuYbhb8beNKowttBr/eMdTPRqurLCjdrbrD3oST5CwRlf4KXaxK/giYMU+3C8NSQpBXlUvXuRqa1iB+NuujhXClnJW4hOOPMPllKDunWjx1YZpo1p1oP1nwxv/KjY7VZ+5Yy/Bya1EHxeAAu/2z5Z68keYW0IL52xn2+eemcphfWAGc10pOpuy3pmnalCwZVNndGSJUv5UFBSjNSJfKzSM2Lu7jJYg5A==
- Authentication-results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=oracle.com;
- Cc: jgross@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Delivery-date: Fri, 19 Mar 2021 15:01:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/18/21 7:28 PM, Stefano Stabellini wrote:
>
> So, I'll follow you suggestion, keep the x86 side named as it is today,
> and provide a tiny wrapper so that we can still have an arch-neutral
> xen_swiotlb_detect function (on x86 just calls pci_xen_swiotlb_detect.)
But now on x86 side we end up with a routine that noone calls. And
pci_xen_swiotlb_detect() becomes not __init and so it will have to stick around
after boot for no good reason. (You could have made it __ref btw).
I think we should leave x86 alone. And if there is a declaration in
include/xen/swiotlb-xen.h that's only relevant to ARM --- well, so be it. Or
perhaps you can create arch/arm/include/asm/xen/swiotlb-xen.h
-boris
|
