[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: Create EFI_VENDOR directory


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 22 Mar 2021 14:59:18 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+ThIadZaVI+ovXVbO/r8tuMVO8UAQd0KHXYB3V3zVA=; b=b2g9xmXpRnpWzExfOGu1S8D9+rSAaaurl6DenTP7dztikiMA8kOU1+Oz38hv4lORz6N/znq6hGP+35tokaz+wG/Sh1xbwOkAmhgA/2/FGAOUbJgdtWXF6pbeAbADSvpKHrl+/TDxjPP4hDJlkyi7y53uEo72btkvVJxPYmr6CMjDVVL/I5bmWML/2bC+t959kxeNB5X1BXKNxIjTEoXsG9Ra8OOvF0yF4BHafaZZhkApMPbVz3NgC56Hwm50k9tpBI+7HYsjW1zqNpYndnHEar+uKc1vcm/z1pcWPUrqY3WyOB5qKVz5q6XMxc7R3hriBXpHv2ykc3F2AHWpVFJo1A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keJPN0EswLSqPpG1vOsrF33b7S6ImO49DGCcWdwCIPhZQD9O6EJjkbZ+f33isRgCvjju6/SkSj9iIKE62Kd4bJWeZAalbYDd+B6eMLtk+/RocKyF5cUD4jtNUGeDAZpoVRy+Vvas1KEHFZ0u/fTKTYXWTyrRM1NhvGAgHdViHwtVH9NMQpjPPYzakkSLPkaD1wUhOw81SRWVJqU22TKpllGEAiLbhb4jNbTDIGxwrYfBK1l6HxF6RXkl54qAzNwrAmWfzq+gru53EF2vqr0nJL2JFSt+gUkELIu3jfmjEXDCgmzccVxrcA9SbLEUH5Z0TWKPiqvqvPrY2WA874eLDQ==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 22 Mar 2021 14:59:49 +0000
  • Ironport-hdrordr: A9a23:DD9nVaGy+j2z3HKHpLqFRZTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7Lk/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeNJwTXzcQY76 tpdsFFZeHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLD1CQYsI1XYdNi+wFEpqSA5aQb8wE5 SB7sRKzgDQBkg/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcLHOjKf2QoTVC4K/Kc6/Q H+4nHEz4iAk9X+8B/T0GfP849b8eGO9vJvDNGB4/JlUgnEpR2vYO1aKtq/lRAz5Nqi8VM71O TLyi1QRfhbz1P0UiWLrQD22w/muQxemEPK7VODm3PsrYjYaVsBerN8rLlUeBfY9EYs1esUuM kgvxP7xu9qJCjNkyjn69/DWwsCrDvRnVMYnfMOlHsaaIMCadZq3Pwi1XlIG5QNFj+S0vFALM BSCqjnlZRrWG+BY2uclmdix8HEZAVJIj62BmIGusCTzgFMmmF4w0Yy1KUk7wY93aN4ZJ9e6+ veNKN00JlIU88NdKp4QNwMWM2tFwX2MF3xGVPXBW6iOLAMOnrLpZKyyLIp5NuycJhN6Jcpgp zOXH5RqGZaQTOhNeS+mLlwtjzdSmS0WjrgjutE4YJih7H6TL33dQWeVVEHiaKb0rYiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbeNEJu+w8R0mFrqvwW83Xn92eVMyWCKvmED4iVG+6KG AERiLPKMJJ6V3udWT/hDTXRnPxam3y9Z99C8Hhjq0u4blIErcJnhkeiFy/6M3OAyZFqLYKcE x3J66isq7TnxjzwU/4q0FSfjZNBEdc57vtF1lQoxURDk/yebEf//GWeWVY2mq7NgZyJvmmVz J3lhBSw+aaPpaQzSctB5aMKWSBlUYeo3qMUtM6lrCc49zmPrc1FIwvVqA0NQijLW01pS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxCGxIcBVrnrbnV6Gpd4mQ0YaWzLGa7/UvS8eAx5vwn Fh+a4Wh7SN3Ry1L3Ekveg+OFpQLFiMDKl+FwSDboVMkrXNcAV9JF36wwCyulUWQC7H5k8Sjm vuIWmxdevQClRQgHxez53n6Uh5bGmbYkJ2ZE1rqIEVLxW1hl9DlcuwIoaj2WqYbVUPhtsQNz zIehM+CAJjzdLf7m/epB+yUVEdgrk+NO3UC7ouN4zJ0nS2MYuSiOUtBPlP5qtoM9jor84GWe +SYBWuMTv9Eu8lsjbl/0oNCW1Rkj0JgPno0Brq4CyEx3Y5G+PVO0kjaLcBId2QhlKUDsqg4d Fct5YSsuSxOGmqNYLD5qHTcjJZKhTc5USxVPolrJhIvaQ08Jt/dqOrJgfg5TVi5lEZKsyxqW Y1BIJcy5rFMpV0f8MTdzlCl2BZ3+inHQ8OiEjOHuQ6fVsRlHfVMNOC3qrQpdMUczm8jTq1HW PazjZU8PjEVRaSzLI2C6o/JmJNdUg3gU4Sit+qRsn1CA+wcftE80f/GnihcKVFQKztI8Rckj 9Kp/WJlfSQbSz2xUT5uiZ6OLtH9yKCTdmpCAyBXc5O/NrSAyXBvoKapOqyhizwUz21dgAxgp BEb1UZaoB7sQYZ5bdHmhSae+jQuUIqk1xX/DFhmBrM4+GdkRnmNHADFxbYjJVQVSRUKV6Sg6 3+gLCl6Eg=
  • Ironport-sdr: TQgnT4lTxJ4JfykOqvSs8zhoXi4fEaSea6zjeDfhhuItGSr1AJqn1wzc8JYVgTwEqth3yW3mco UcKpW7PNIc1SrdmqeIq8RhDgS00TFDBUG+dbv/UCTYkVzI49/0fO/8V4Y6wVAGlaiEDwppzchD /TUN9MLZt+urWgIq/68mazDwLXk2rczorrEobeWjBodXUccTM7Ze3ljZiMZ2IxxL9H0z3a/qzo atuCz5DRpZAPNd8ziplrYTcacoWngqlRRzYHtho3henrSmVL4HCIFUunJcTazPzHREx4F1vEsk /F0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/03/2021 14:52, Jan Beulich wrote:
> On 22.03.2021 14:33, Jason Andryuk wrote:
>> make install-xen fails when EFI_VENDOR is set (=fedora) with:
>> install: cannot create regular file 
>> '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such 
>> file or directory
>>
>> Create the EFI_VENDOR directory so xen.efi can be installed within.
>>
>> This removes the need for Fedora and Qubes xen.spec files to manually
>> create the directory in advance.
> While I'm not strictly against, I'd like to point out that it was
> deliberate to not create this directory here. I also didn't expect
> anyone's xen.spec to do so. Instead I'd expect the distro to create
> it during OS installation. If this was a bad assumption, I'd prefer
> if the commit message here could point out why such an expectation
> won't hold in general.

This reasoning is broken for anything other `make install DESTDIR=/` on
a live system.

It is incompatible with how RPM, deb, etc packages work.

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.