[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Mon, 22 Mar 2021 15:09:19 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zPn+iu7Ye/W2MmnTGOHRETUDtVmPyAC2+mP2WpRSSlc=; b=ik2CvQfGEHkAQYrJUVpxPWv00z2yzLIRSw6tXFsVjVmm5TvCG4SahPmPfMDlzPAWqxzZI7MckaqvaypljtUlOdLibMRItWO0pfQ1Ho3qNJmFcO+//NQsx5QKfJQDNcEBFA+uLdMnh44GicggznVyHfH4Aj7P8cHDI7yzUvaA//jkpw9kAC0grcrp4u1Y7I9l2wgl167QLo/tB8wsdvsZmNTWJ9WQ4lXMU0bziye1U+j4FhIJoODPM9U5Devd4jU548ACm2sgCvGnaYwFFwyv7GCWBuYel6/MJbUOc65J6+9sekvx1l06Pzg6pFXNGNvbFagfQVZIwYQNby2f69e4lQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMR45aSgKcP5hzx158TFPS5rNSwIt2R2bTvgVLkeGWvKfNNuon4wVhhAjqI4JiMkYj9XAtPGziqS3/4rXvoZb7hYcSTDUbCDfLjjUodtVyRnuSklZb8c8x0LMFgWSzmzbR9H83w121XRDx/wucow84lV5Ok4siTN7vGe+GJWHGGQnK7wfDm6BkpWWDpWBq+bNJHJpMqX8dJhrtCaSPhNZ+ow1mpSTHSVTT4cuXwsex8JLRHWD5ASG8FRrBIJOvj1dhVWquHQ9jGZCoXrHSTBs/Uq3jHr8Cdt1IRXdmLTXkB2fkZKdME6DUDcHcNDwcg1Z2bkau3BAhKZM2G5QHT/Fw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 22 Mar 2021 19:09:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/17/21 7:04 AM, Roger Pau Monne wrote:
>
> /*
> - * Clamp the amount of extra memory to a XEN_EXTRA_MEM_RATIO
> - * factor the base size.
> + * Clamp the amount of extra memory to a EXTRA_MEM_RATIO
> + * factor the base size. On non-highmem systems, the base
> + * size is the full initial memory allocation; on highmem it
> + * is limited to the max size of lowmem, so that it doesn't
> + * get completely filled.
> *
> * Make sure we have no memory above max_pages, as this area
> * isn't handled by the p2m management.
> + *
> + * In principle there could be a problem in lowmem systems if
> + * the initial memory is also very large with respect to
> + * lowmem, but we won't try to deal with that here.
> */
This comment looks out-of-date in light of deprecated support for 32-bit PV. So
I think we don't need to revert this part (except for the macro name).
-boris
|
