[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 25 Mar 2021 09:37:49 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2w/a6QIOvJdqHc/an9cDyck3WaAGeZtdwdvZrCvYneI=; b=Gev5jvarq8zPC9UJR//g+bTPRiImKgadARWe4stzNezYH3crrpP4re4x0XV7qh6VR9pIeLNk2ILL2yYto+khwDfzmD+ErCYa5jLbDjH0oGRQ7Q2IGZensW62wEUxeorFPCIC840RIkoJ2IFsJptZSerr1teunirCtJqASVu2xkK0JalffJURRNNgkH1UAAivWNN+lEGwIkTW9vnIKx07kdT7+t4hoK12dORgYUQL8ssMDNcYD51gYNfxWI9xx8g3AoxA4mtVPFQ6vD7ZB39ZWOXq3ZV3+GmxoYck1C+66Lcpceru94ZAFEwP1VtJ2rB4H5gOPP629LtH4eA8rCs2hA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mx9FBVvJ6AgCdGqZ1xrVCHfD/0J1VjzfvUgm+/RhNuLPbtzq+9NKgn1p5lUg9SRnGenZ/8ET9SAG2w7UaogaFWbPmu2UTLlMC8pEau0KvkrHfwxneW3r9ki5wf0sq58zFjOk3moEOcWHrscO1SvINhVfCYD2Rtp3Tsw6tbmi8dSfS7nkthjHq6D/iWmainEcP0YYXS6n4WQUR6nI5gIpCydGdYHP7Ur0If7Y0b8nsu57aL44qqTmZhdD/L1vU5HliOuFOq8yIw79XXd9lahiwuo58jZowJJQtxjZx0jthoXC/i/YKfeFcEdk6KtRYNEKcFUYGPUnYDozWMQOq7IpKA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Thu, 25 Mar 2021 09:38:12 +0000
- Ironport-hdrordr: A9a23:6E/966PtQlrhrMBcTxv155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEq+GXH/a6NpJ8ZAcVI3SOTXOlUmJCMVZ7YXkyyD9ACGWzIRg/I ppbqQWMrLNJHdgi8KS2meFOvIB5PXCz6yyn+fZyB5WPGNXQoVt9R1wBAreMmAefml7LKE0Hp ad+cZLzgDIERgqR/+2G2UfWKz7r8DL/aiMXTc9GxUl5AOS5AnYi4LSLh7w5HYjegIK+5gO2y zvkwv15qKs2svLsCP05ivowLl93PfkwttHLsSQhsYSMSWEsHfUWK1RH4eskRpwjOaz6Es7sN SkmWZdA+1Dr0n/U0vwgRzx1xLu2DwjgkWStmOwsD/YjuHSABcZYvAx4b5xQ1/ixGcL+OxY6u Zt2VmUspJGZCmw5BjV1pzzeDxB0navrWFKq591s1VvFbEwRZV2toIl8EZcAP47bVnHwbFiKu VoAc3GjcwmF2+yXjTctmlr9tSmQm4+KBeAWlQDocyYyVFt7QlE83c=
- Ironport-sdr: +B2WYDj8ONp6sU2d2uoX4dzhMYd59EnqZ4rXC4br6jVzdinxzBmAFIIsVnTekYN5rbPnJKekZM aaFLj3udsNEhQ4Eo6NPA6OM/eoCQMwYyVIYoJeaM0HeaVD76xbP4W4PbzTsSThOlignzTCE+wR JgqpLUgJRDuIIACsouWcSqbDnSlVFO+0sSjeYx2S/ArHqAJyOpJlHPwitRU13Vx2PbNlxPKuzY WP6uPiFW3kRHzpAvsiX51ExpmrHX10X5wR5amTxSL+tTOxXv7mIn1EBZqXgqs96IRGMEfR4jW4 iZI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/03/2021 09:04, George Dunlap wrote:
>
>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 24.03.2021 17:44, George Dunlap wrote:
>>> --- a/CHANGELOG.md
>>> +++ b/CHANGELOG.md
>>> @@ -14,6 +14,8 @@ The format is based on [Keep a
>>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>> - Named PCI devices for xl/libxl
>>> - Support for zstd-compressed dom0 kernels
>>> - Library improvements from NetBSD ports upstreamed
>>> + - x86_emulate: Support AVX-VNNI instructions
>>> + - x86_emulate: Expanded testing for several instruction classes
>> TBH both seem too minor to me to be mentioned here. If I was to pick
>> just one, I'd keep the former and drop the latter.
> It’s always quite difficult in these releases to help express to people
> exactly what’s happened. We’ve got over 1000 changesets — what have we been
> doing? If my star chart is correct, the latter represents nearly 1700 extra
> lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a
> reasonable chunk of code churn, which I think is worth highlighting.
I agree with Jan. New concrete instruction groups are useful for an end
user to read. "We refactored some internal of a test harness" isn't,
especially when it would most likely be repeated every release.
I'd drop the latter line and just keep the former.
~Andrew
|
