[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Thu, 25 Mar 2021 18:56:57 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EzPllQmjJ2MAsdxWEpVbMU/4HFnw55suz1Vf+Qgmp8o=; b=PfU6LjUia6xjBqTmRbhfg5+INxzzA77cE0WA9CzmzpRS7/T+Ouo6MqGLd9rY9rk8oUNZ9El4+Y8qwWNfLBCQ3qVGv0mbinkM7//wEk2QWgD2Kl+siK81ol4D7BiS3jZ//MATrKnGRXyKwtf3QAYgN8aVT88foG+dq+eZ9PrV4M+KdX+RJF5GCc4YQ38egzi44WEoPRR2uCDZR6UYR9U41ZQ3wXhbTkH0D9aoE1kvXMyeBUdcv6K0q2Bt9Xd4C55i6yftBPQiH7nVXqAcK+eHTT+dUG2zh9o23a+DKEDAlQOE/4YVqcrQk3tzxovQ5bfearjJuoYoHlF+EdehHui9jg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EzHFnq1mLxCO2zln+KgfJRE1oppDnK4dcGZxZqfEurOD1hCsi3vL/ntSigPTf9oH3d6LozU9hHrmM3Zz2PfyIlN4wKpoCi20KBZuACjaleFEL/2xHzLLEBU3YgKnVhxI63B0fhANYq05p9CqqRb4IJ48LZfuWU8uX86zqXVQswTQU/1rrS1L3iBXsziOPnmZH85ogMi2PQJdRIFVs8NyU0aeZphtsbPLzbJDDflfjPgiXK1bNQEym5NqNwQqqLIe2zHB/I8qKc1JoovV6OeEvU1ZUQAyi7S70cWC5lPhR/znnV1rk3ODgjvw1ywspzhd9NQsy9fy8GBlqCkffNR6xw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com;
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 25 Mar 2021 22:57:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 3/24/21 7:09 PM, Boris Ostrovsky wrote:
> On 3/24/21 8:24 AM, Roger Pau Monne wrote:
>> Hello,
>>
>> This is a proposal for an alternative fix for XSA-369 that instead of
>> special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making
>> XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG
>> option rather than XEN_BALLOON_MEMORY_HOTPLUG.
>>
>> I think this is safer, as we don't want to be special casing any option
>> that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG.
>> Without this we would also need to at least special case ZONE_DEVICE
>> which also relies on MEMORY_HOTPLUG, and is what pulls the generic
>> MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled
>> with XEN_UNPOPULATED_ALLOC.
>>
>> Thanks, Roger.
>>
>> Roger Pau Monne (2):
>>   xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on
>>     MEMORY_HOTPLUG
>>   Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"
>>
>>  arch/x86/include/asm/xen/page.h | 12 ------------
>>  arch/x86/xen/p2m.c              |  7 ++-----
>>  arch/x86/xen/setup.c            | 16 ++++++++++++++--
>>  drivers/xen/Kconfig             |  4 ++--
>>  4 files changed, 18 insertions(+), 21 deletions(-)
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>


Applied to for-linus-5.12b.


-boris




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.