[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tools: Drop gettext as a build dependency
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 26 Mar 2021 15:27:47 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Tf1Vq2Gf57OlG0dMq+RGZP6gLPG7kR1gClMVEZ2XDg=; b=gu35CACfvyw2RVYoQUT2KycgNa/0XW/1m5zbWgBArHTrfele23sgwOwZ6EmI5aDFCtfCjEOX4jXnvLOxB0awVg15JAm0tSZMrkMOHr/GaRocm2cG3MG4TkHpL+Hpak+MtyIwfe5rgs6hCLEuN/G7ereZLru0NjaGtnq2irsr9pb58in2ss22Fy/Zp/IFU1ifGiBP0Ytf8G+7rTl1SPCUOo3ZP8RSVw3XNHxteqPSvtnG5ze9HQWXSRFRWD+S0ltTSAN86C5SBZKH80YO3b9YrhSNwQqAl/BYxpgvNGz5+xMUJlUjUfJ7dWWf/6CUdNN8AH8u/EmIVBRJHgyUPxpBtQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNiUm/1oD+n0HdWzEjcJ3KLANbSbVf7d0ql/1eYkHr206Dz1DHRj7oRimItGB2GVO44jgVz8k2RhEAlY2AO2vXSaZQERB1HkaWeZP9wrJ06TTR6TafI8lk3wThL5/aV4xD+gYtrjytJWz7R/G5v0xVY4YTj1lstBU+PkhCg8mKKQnUEetjYQm+XuLJpQkB6+sdlGQbLYfmWl/IwVfD5lRqGdPOv4RMjc2xUv4MfJ1OBBPq+Bl+su4g0HZHNISJkHfCGm0xhPf6PXX6Cfm+UR8QisREBkI7KeqHN/zCd5c/Jtgo3Y0+/dB307Vl0Ls38jK2uiJF9r9qkOKc0WEASHSQ==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Fri, 26 Mar 2021 15:28:06 +0000
- Ironport-hdrordr: A9a23:vcf8taipoXgQpduTnpIj095z5HBQX0tw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyycFVB7QxQDIJI/Go aV6MYvnUvdRV08aMOnCn4ZG9XZr9rQm578JTIADRgr6A6B5AnYlYLSOR6ewxsYTndz0a4vmF K16TDRy4eCl7WAyhHa33LO9Jg+orXc4/ZKGcDksLltFhzCkQCtDb4RPIGqnDdwm+237UZvrd +kmWZaA+1Wy1f8Ol64ugHs3Q6I6kdf11bHxUWDiXXu5ezVLQhKbfZpvo5SfhvH50dIhrgVu8 gqrgHpxaZ/Nh/OkD/w4NLFTXhR5y6JiEEvjPIJiDhnWZYeAYUh3LA3xl9fE5sLAUvBmeIaOd RpZfusgcp+TUmXdDTwsGVp3bWXLwwONybDaE0DtsuJ6iNRjXB0wmAJrfZv4EsoxdYTTYJJ6P /DNbktvLZSTtUOZaY4P+sZR9CrY1a9DC7kASa3GxDKBasHM3XCp9re56g03vijfNgtwIEpkJ rMfVtEvQcJCg7TIPzL+KcO3gHGQW27Uzio4NpZ/YJFtrr1Q6euGTGfSXg1+vHQ4sk3M4n+Yb KeKZhWC/jsIS/FAoBSxTDzXJFUND03TNAVgNAmQFiDy/i7ZLHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSFQXn9rB/NW278W0D28J5qeZKqvNQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4PffGn8qA1CuL1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGn92efGtVzUaWPxMXdbKSLC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC7ARh7OE/sWgXp8jFJ4pVOhQGGzwZlNIsDcvjF 0GRB4PR0fZGD+ro76iloYoCObWcMQ5phyqL85SoXf2rl6duskre3seU1eVII6qqDdrYwARqk x68qcZjrbFsy2oM3EDjOMxN0AJVH6aG4tcDAOOZJxdn5fifA0YdxbPuRWqzzUIPkb6/UQbgW LsaQmZY+vCDFZmtndE6ary619vemKBf0V/V2BiveRGZBf7k0c29dXOSru40mOXZFdH+O0bPT 3fSRY5Iw9lxbmMpVaosQfHMU9j6oQlP+TbArhmTqra3Wm1LpaU0YscGeVPwZpjPNfyk+MCXO 6FYTWJJDfgB+5B4X3Tml8VfA1P7F8qnvPj1Ee7sCyW3HsjDeHTJ1ojbbcBON2Y53XlQfHN8J gRt6NAgcKAdkHKLviBwuXrShQGDDX5i2u/VfspppBZprhajso7I7DrFR/zkEha1xA/JvrunE wQQK5H8KnMU7UfCvA6SmZ8xB4Vj9yBI0sgjxzuDsI/dV8riWXHP9nh2cu+lZMfRmmArhD3I1 +R7ml0+OrERTKK0dcheukNCFUTTEg383J5+uyeM6XWFQWxbulGuH63KGW0frMYaK+LH9wr31 xHyuDNu++cbCzj3g/M+RN9P6JV6m6iBfqIPzjkI58/z/WKfXKWgqWr58avjDD4DRuDAn5o+r FtRAg3dcRMij4rkYst9DO9I5aH5H4Yrw==
- Ironport-sdr: xovhcyLK/NMoVKvDpZJ1x+1FcSWz38lbZIcRpdl541zPSSc1WON7zjHkylzIZuEKIFzrr909P4 MTGDeveOGimTj02ucwOMs8IygHxm46bIP/IhI6k71dli4otDWEY6KkcBrLTIXZ3Fy+NBompiOo TN7I3EVOFLFlnw10LJAwVIodXmVq96CIbuabFjZQ6nbOIoVxY5uRN3oje4el2Bf61OqyYKgi9C 57WPazUv2jYYqQ4S4amNS76ZyTTb68Ea86n+nHR75YngVSQvajNYa3CnlpEeJdE/b/E3ipW/Nz T+E=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/03/2021 14:11, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH 1/2] tools: Drop gettext as a build
> dependency"):
>> It has not been a dependency since at least 4.13. Remove its mandatory check
>> from ./configure.
>>
>> Annotate the dependency in the CI dockerfiles which are used for 4.14 or
>> older. Drop the dependency from Alpine and Ubuntu Focal which are new
>> containers in 4.15, as well as dropping from CirrusCI and TravisCI.
> Thank you but I'm afraid I think that this is not an important bugfix
> for 4.15. So I am withholding my release ack for this patch.
>
> Feel free to explain to me why this is the wrong decision.
The bug is configure rejecting a correct build environment.
The reason why this is important for 4.15 was discussed. Shrinking the
Alpine and Focal containers (several MB in both cases) makes a material
impact on Gitlab CI efficiency, and therefore the turnaround time for
answers, but cannot be done if 4.15 gets out of the door with the
erroneous check still in place.
~Andrew
|
