Re: [PATCH-for-4.15 v3] tools/libs/store: tidy up libxenstore interface

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 24/03/2021 12:39, Juergen Gross wrote:
> xenstore_lib.h is in need to be tidied up a little bit:
>
> - the definition of struct xs_tdb_record_hdr shouldn't be here
> - some symbols are not namespaced correctly
> - the layout of a structure with an enum inside it depends on the
>    implementation of the compiler
TBH, they seem that each of them should be in their own patch. I am fine 
with one patch but I think you should at least outline the solution in 
the commit message. This will be easier to relate with the rest of the 
code (you are solving 3 issues at once).
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Sorry I didn't realize, you already sent a v3. So I will repeat my 
comment here.
I think you want to summarize the discussion [1] in the commit message 
so it is clear that
  1) You are breaking the ABI (although it is technically broken as we 
use enum)
  2) Why this is fine to do it.

Cheers,

[1]  https://lists.xen.org/archives/html/xen-devel/2021-03/msg01267.html

--
Julien Grall