[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/21] libxl: don't ignore the return value from xc_cpuid_apply_policy
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 30 Mar 2021 16:38:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i4MWx8RKyI2m57Qe4Jvz7OTy7zS3azzQ25k3aG7RPmg=; b=EskyG8fLui5vnXhbcWxlPda9+Vteg/c9Q4LtTKrWrP2aEYmioIIqWOBq3CZt1q53GLAqOINp7APB8UkEoE2CzfV7s9MlUffpr4RLY9FT7Nzj64gLPdNHRj8PhN2ER8YeF86zzqBy14d86qwh+08b2Mx6CgATJwHk9/HRd/eU7M9rTMAOH5XteAjaLtweAo/fcYJ9HTPcrqwxWkY7eAJ6/yEWg3anwjXaVYHXrvEqkl9XS5r7ECnV164TnBrqN7L18K/FvpFE1QsnFSFgY5tgA1WTkmJvSVZUv/TV4HY5oe5RDvTy4ANDR30lYalC080nIVRLk6mbxLgGbufANQ6BiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHAnxPtO0J+orWj+R4E/2tJfdLS/NdoDq+zg7CmHKLWJj49y744MlMWRmrzup+d6haCWNSnv/Ly5kMXFQIxsW+4s7Fs+rVCFIFyAnDW5iCu1/uaEDZOdDKv7/ZAdAnEpLIACiqKZcRgygWNFob4c974MnD31XOcvYAeUWqCM3j3qUrEJQyY2HSlqOPF/XrwsyIuSnWTyyd4TMSTSaDteGzZbSKReEERqEhavIg0gcXGL2S8kXCh4S1aU1PaH70dtbhOL5z4rwJkv/P1qcP77ODD33wfjL0O1PQQjV/q15c+nZTohRrIRMULYJU5v79r078rItW3J5X8h1qbmVMoBJg==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 30 Mar 2021 15:39:10 +0000
- Ironport-hdrordr: A9a23:RQUTFaNU9iezusBcTkSjsMiAIKoaSvp033ACy112DSZIeciZit 2jkZ0gpHvJoRwWX2wtns3FHaGGT2/V+5Id2+gsFJ2lWxTrv3btEZF64eLZrAHINiXi+odmuZ tIXLN5DLTLZ2RSrcG/2wWgFsZl/d/vytHKuc7771NACT5ncLth6QARMG2mO2l7XhNPC5Z8NL f03Kp6jgGtc3gWcci3b0NtN9TrnNHFmInrZhQLHXccmWuzpAm14733GQXw5GZ6bxpzx94ZnF Ttokjc3OGOovu7whjT2yv2445NkNXsjvtYQOuAkaEuRAnRtg==
- Ironport-sdr: Kr2+qOSarzQqro3lZndSfU5X6T9R5zdXEGEqxWGGNGSh1YzVq21PzVrb4coxJzcIdfrzq6rnON p3Iwt9LcJjG1nxJGkqJ+/4jtSNj5ZzwejzQUpMqc3ggsc6OrbP41s2XopaZZ74lO3lv01l7Xbl 43TdU1zMIdKco47ybelcyqMrBHd53TKlV3LE6JuuFYPyKTWrvHYk1iMxghUNIkdHkAwExc0E5s Sa/IFa5zGrkSPMuYoKRi332OEGSWgj7dhgerrDnfWNQp1p514XkV1kh3ObnOld4tpZrSSqqHjy W/Q=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Also change libxl__cpuid_legacy to propagate the error from
> xc_cpuid_apply_policy into callers.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
This path has never previously had error checking.
The set-cpu-policy hypercall, in principle, returns a triple of (leaf,
subleaf, msr) to try and help the caller fractionally more than just
getting EINVAL, but doesn't actually fail yet for interesting reasons.
My plan was only to wire up the error handling with the new interface,
which requires plumbing the extra failure information through into
suitable locations, and ideally also looking up the offending values to
render into error messages.
~Andrew
|
