[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/21] libs/guest: introduce helper to fetch a domain cpu policy
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 31 Mar 2021 13:06:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0ua5x8NrFRnTlHpHqLFMm0gHOAb8Ol8y96wdBm6mDk=; b=V+LuPLzjGckNXQX0BLQfKJOMVhSlK0GPC6dJLVzaxXTStcPlkaPe0hoEo7x/2ILuJ8HBNAQzv976g4Xt6UYk5uRjYIBv7krF5/JBeo5vWf1GtQFMzehP85Y/LF23zvGMO27aiY7hm6LryJL0RxmcG0DoKHuWfsyf9fIMn3wy8Qn4DwuNi9sGkQIBKNqGLIcVy//2VbIOMrrvMb7lY/lXLiKNjE1ThNhEu2VPo3F9HwS8depan8NzQxDuwzfJDzPeW70L39noHJdK5ll4uq5s2Ih6qi8Nhf8+WsU9txo7/XMPA6SWyklsxT1hj1n88sx21tI5tlWP843F4sGQmyflNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNI9MUX1ji9fRtDGOfDkb5ngKZYHJ2BerSMzhRstnBFnSrIIUHTXt/9KUMTjMIvIKvpIPHd33MkOScUFYU/ku1AKnzEL3r5fl0YvXnQbfMy9cd3FG/xtpUOJbhUlw9pFwnHvCKYDBsqG/Z2Ptmu4pSa52Gm93BZk+HBb9geay+WB9TkhYGhIzgeTdcJVQNUoscWv67mms38l729NPCbDJl++oJZ2BYkJlpvzkCqJTryC9tI3rqQ+EIc816TKi5lW6G4Dzcg2G70g+WAXJw/DJzu8J9Hd8C3lKnebmnBGtqH6t1pl6jS7zX8satygE0WmCHCyqc5uAs5s6B3SmaDl1w==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 31 Mar 2021 11:07:09 +0000
- Ironport-hdrordr: A9a23:q/+do6xUjh+RvAm/8OqfKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5
- Ironport-sdr: EW0XM+Etjzm/mNcjJXvWx4Eo6A7QFTcimtW2+HCUyqDq3VTHRaU5QndplJZZT6Zxe/ULhIhSog wUaMKQWu14MIT++EHoq4NuVu+KaEnix1fxBUT58Umqp1gt4Lc6iiwc6A0+s0EkRh/BW5OogxUN EMpiJtnvEhNRBN0vlJhoiN/ZteQ92Ra4qERmDnUZt5Is8dz6155yihFNon363OFbKdEw8nx9a3 waM76+S+B5t5Dwn6lbCxYuUtFhtCTO2HVDHUtNPer2MDyqdYeDdXAAjKWpPySXABGq0Z81OLjg b1w=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Mar 30, 2021 at 05:37:02PM +0200, Jan Beulich wrote:
> On 23.03.2021 10:58, Roger Pau Monne wrote:
> > Such helper is based on the existing functions to fetch a CPUID and
> > MSR policies, but uses the xc_cpu_policy_t type to return the data to
> > the caller.
> >
> > No user of the interface introduced on the patch.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with again a minor remark (plus of course the same that I made for
> patch 4):
>
> > --- a/tools/include/xenctrl.h
> > +++ b/tools/include/xenctrl.h
> > @@ -2599,6 +2599,8 @@ void xc_cpu_policy_destroy(xc_cpu_policy_t policy);
> > /* Retrieve a system policy, or get/set a domains policy. */
> > int xc_cpu_policy_get_system(xc_interface *xch, unsigned int idx,
> > xc_cpu_policy_t policy);
> > +int xc_cpu_policy_get_domain(xc_interface *xch, uint32_t domid,
> > + xc_cpu_policy_t policy);
>
> Generally I'd expect domid_t to be used for domain IDs.
Me too, but xenctrl.h seems to consistently use uint32_t for domain
ids. I'm fine to use domid_t here, but I assumed there was a reason
for using uint32_t uniformly there.
Thanks, Roger.
|
