[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic EOI callbacks
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 1 Apr 2021 11:15:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+bvJqg/PbAj/zaIBp4Zsin11W4wJLOT6sVFvy9DVdI=; b=hHWq4I8ziMggBgY31mVBw+CMVxsvV8xQ8IMm5d3XsQQeEhnqznpSZQ+vZdMlCsEgTCiVjjiRiRlOyPNgwX4+RJYEaD+IuViwOLlGxwWZIN1QWJmH9BLCIr/zfJcgSMj/Im4W6WNIkAQC6ztgxJ1RBi2gpuQtw+vVsnArVUZmg0l6R2JWZAMGdk7drWvlrCsXP8eRapsejR6tKOOz67QSp16/6SZ+JHapiY4MrC/GEcDuoHE+0VIs+S4jiNzufNCTDurHTivhN2F1vqaemKbCoP+wmfzljU94L4TvWWJzFtQ0B47Gd96R/TeJFmt4RGkg2QjqB+1eXndWgl4zvm7c/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLq87aEgwqtFtwpITzKBXImTeWcY2bUUeiyK8yhkh58g41RckDHo9XpE4bgJGOLH5Ha8psecVMlnTUbOzAy2rsLbk1Iv0fZ8K1rx93MkqEnaX3KJMct9wnxrxW4hm4jJjF3u/tB8Izgn14XPUxvvOranWs9GZUmQ52+OkmNzW4NAr3Ifbvw/n0SjL+e+UyR9mU5iEVFccxYL5jX6oE6T6VC7fDAa5gcicjO545EwyurIhjbc5TpH069i3YGc7p+YPOWTA3K/HluyfdSkO1yqCe1N/0fTSJISkfYwYnLUQXsG38M66Mk95u/AR3zspSMfuDkmxc5bD8cNWQxAaR7Hbg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Paul Durrant" <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 01 Apr 2021 09:16:03 +0000
- Ironport-hdrordr: A9a23:SgtE7K7A+HWNx6rT2QPXwRKBI+orLtY04lQ7vn1ZYQBJc8Ceis CllOka0xixszoKRHQ8g7m7VZWoa3Xa6JJz/M0tLa6vNTOW3VeAAaNDyc/ZwzPmEzDj7eI178 1dWoV3FdGYNzdHpOng5g3QKbgd6f2m1IztuuvE1XdqSmhRGsNdxiN0EBySHEEzZCQuP/oEPa GR7MZGuDasEE5/BqiGL0IIQvTZoJnznI/mCCRsOzcc9AKMgTm0gYSKcCSw4xF2aVJy6IZny0 fpuUjT5qKvs/a0oyWsrVP73tBtt/bKjvdGDMyIoMAJJjvrkRbAXvUdZ5Sy+AobjcvqxFE2kM TdgxpIBbUO11rhOlubjDGo+w783C0g43XvoGXo/kfLkIjCax8RT+9i7LgpFifx2g4bk/xXlJ 9v5Sa/saFaCBvR9R6Nn+TgZlVRuWef5UY5nfV7tQ05baIuLIV/gKY4501vHJIJDEvBmfsaOd grNs3a6fpMGGnqCUzxjy1qyNyoaHw5Ag2LdEgEotCUyDhbhhlCvjIl+PA=
- Ironport-sdr: gzGQLHkO/6MaMEO8/Rl5ZRpIcQEyiGWPyUJDMgC7Wwomf7pk4e6+Tap+bQ1JKFU/YoOGacdU3o gR4tZqPonMXeMdnSw0rvA01S2Yw/MXBoyguVAFuwsxhAM/NBcvuEoV7jWllKr+whNKKGU189UZ KeJaQI5hACPqAPdJmXHOJIXsNxXp2M4oXj/Yi7izNhYjkiUV16xLwqJTn4T8zrKZDgXyCZS/Gp gCalMzbiGhLNCtPT0veTFq/vnQZLLVUyejPkcrivAw4pqk+r1vlJ768evqjON/tzyeECoLU7Ml YgU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Mar 31, 2021 at 06:04:43PM +0200, Jan Beulich wrote:
> On 31.03.2021 12:32, Roger Pau Monne wrote:
> > EOIs are always executed in guest vCPU context, so there's no reason to
> > pass a domain parameter around as can be fetched from current->domain.
> >
> > No functional change intended.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Reviewed-by: Paul Durrant <paul@xxxxxxx>
> > ---
> > Changes since v1:
> > - New in this version.
>
> Just to make it explicit - possibly same thing as with patch 1,
> depending on how exactly the issue there gets taken care of.
I don't think we have any scenario ATM where we allow EOI'ing of
interrupts from a different vCPU context, neither I can see us
allowing such in the future, but I don't want this discussion to block
the series, hence I'm going to drop this patch together with patch 1.
Roger.
|