[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxg: don't use max policy in xc_cpuid_xend_policy()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 1 Apr 2021 12:33:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9Bof/P9ivmijchbbNvr/d9Cs/Off1vuyFeRE3O+sMA=; b=mFqlwAtaWkMkvLbGE7cHKJ6131nyPSTEjfTRhnueAnczyfRLdpSaAkOHrg2arV024yYVhz1KuLVCZdhcMCA5YThubTTu36sTf+sXf1jpyvPQlXa2g3ghvTHnqR82R4Taz/68PxdDbcqA8G1SS6nl6lvH3UfdLH9j8kSpGq01LnNFwRoykyFTgaYLHCs+ZtyBxQHBqud6WHI8XbMyCTOQcmrKUwU/ToHHbG5+X5CiDUI1SzKuRd5rSKWTQLQJHJ1mHYY7wfLiuVtx6jgf+5h80P5WDYL9+q26M6QbQ/JjeaOGbxR1P3ImsLbtzatktQiIHQP5a30VyE9F/MTrN6lyWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMkVWnh2LgXamTSc5M5KLVBR5JIwjmm44a7564tUZ+9ek0s/YRgfnBlJJCDIH4fgP8mckdY1OTyCx5AiADRRIh+Q/hoPwZOEt4XPpE76+RFgwrn7/uQHelEkCRff3nnFir/2qlDCQ/c0YCiuiMP6GCsshJvMauz5U/JhYiOfB4AMGX5BuOqZhmFioxq8+1+z25vr93qamRDPc//F0H41PgFz1+InFm4AUIysddXg5bNgw5FOfMvahVP2PR9SWwIuL99yjdA9fvRzM7QDXWLjtVj+9LNp7QsUzizNcYtp0cVARFFn9cSWFna+SVSVGx1XZ7MOsg5Jagp0bsMaDeLFPw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 01 Apr 2021 11:33:42 +0000
- Ironport-hdrordr: A9a23:KUE5rawHTCXz65q03Me9KrPxg+4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnm6JdybI6eZOvRhPvtmftFoFt6oP+3ybtcheQysd07o 0lSaR3DbTLYWRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRC51IxS0RMHf9LmRdQg5aCZ0lUL +V4cRarzStEE5nEPiTLH8DQuTFupn3j5rgexELHFoK7wOJgDOu5tfBYmel9z0ZVC5CxqpnzH jdn2XCl9memtyY6juZ7W/c6JxKhMDso+EjOOWggtUYQw+c8TqAS59mX9S5zUkIicGprG0nid zd5yonVv4Dlk/5WkGQjV/T1xL70DAogkWSu2OwpXf4u8T2SHYbJqN69PpkWyDU4UYho91wuZ gjtwny2us1fHGw6BjV3NTGWwpnkUC5uxMZ4IgupkdSTJcEb/tppZEflXklY6soJj7w64wsDY BVfaThzctRGGnqC0zxgnNi25iFUHg1A369MzI/k/3Q+T1XkHdl9lAf1cwSk1wRnahNO6Vs1q DqNL9lm6pJSdJTRaVhBP0ZSc/yMWDVRwnQWVjib2jPJeUiATbgupT36LI66KWDf4EJ9oI7nN DkXElDvWA/VkryAaS1rdx22yGIZF/4cSXmy8lY6ZQ8kKb7XqDXPSqKT01ru9e8ot0Ea/erGc qbCdZzObvOPGHuEYFG00nVQJ9JM0QTV8UTp5ISR0+OmMTWMYfn39arM8r7Ff7IK3IJS2n/Cn wMUHzYP8Nb9H2mXXf+nVz/QHXoVkvj/Y9hMaTT8uQJobJ9crFkg0wwsxCU98uLITpNvugdZ0 1lOo7qlau9uC2X8A/zniJUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0X+HOGIxR4Xv7HCQ I3nSUwxYuHa7irgQwyAdOuNWyXy1EJomiRcpsakqqfoeDoZ40/FZRjfKBqDw3EG1hUlG9R2S d+QT5BYnWaOiLliK2jgpBRLvrYbcNAjACiJtMRj2neu0WarcQGXWAaQDaqbM6SjW8VNn9pr2 w015VarKuLmD6pJ2d6qv8/KkdwZGOeB68DMB6If7xOmrfgeBh5SECDgTDysWBrRkPas2Epwk DxJyydfv/GRn5QoGpR3KrR/FRoTWmFZE5rZndmsYpyKHTeth9IoJq2T5v291HURkoJw+kbPj 2AWzcULw907/2c1RKeml+5ZDgb76RrGtaYIKUocrnV1H/oFZaBkrseGeRIuLx/Msr1j+MNWe WDWgOcIT/iEdk10wiNqntNAlgtlFAU1dfTnDH15mmx23AyRcfIKFN9XrcBPpWy6XPnS/vg6u QwsfsF+c+LdkP/Zd6NxfuJM3ptKhbPrXW3SO9tg5ZOpq42vKZyGZ6ecTag7gAw4DwOaOPP0G UZS+BHxZqEHKlFVckbYThY8Vokj87nFjpgjiXGRssFOWgwhHraNe6T67XGqbATElSMzTGATm W3wml4xbP5RCON2r4RNrIoLUlXYEY67m5+/OnqTfyYNCyaM8VC9kG9KHmzbft0T7WEA6wZqn 9Bkp21tt7SUyrzwwbLuzRnZopI7ma8WMu3RCaBA/RB/dD/GVOChMKRkYGOpQaybTuwcEIDg4 JZMWQWc8RYkzEnyLQN7RLacN29nmsV131E4T9mkVbx2o+ppEfjdHs2QDHxs9FxRjlcMn+BkM Lf1/OXvU6NuwR45Q==
- Ironport-sdr: mscDtZEnalcGFKjeO3s1M7QK4wXEs7csF7O+08OM4S+MKx+ncWMFBEEGK7HKRfJJk63XeezxWt E+1oJbpKq17Okm3ud59Bi/21n89uvusUKl1gmZHehHD2MMvqBoBIzvjtsQJ/rDIcUEjsUk6zLv go1ScoVfRL88Iss57AhIU48ybLwHiMV8j+vwxZ0G8KmExkuR/vD5TBTQt1pXS0V2w0gxmN3LCR Xro8b+GqkbNxfPaOIeJSODhZL1rvKpzFhO9vne1Z3yCLIpTW4X1LUL3mqt1LUT3hyTkO7dJnrw hrw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/11/2020 15:56, Jan Beulich wrote:
> Using max undermines the separation between default and max. For example,
> turning off AVX512F on an MPX-capable system silently turns on MPX,
> despite this not being part of the default policy anymore. Since the
> information is used only for determining what to convert 'x' to (but not
> to e.g. validate '1' settings), the effect of this change is identical
> for guests with (suitable) "cpuid=" settings to that of the changes
> separating default from max and then converting (e.g.) MPX from being
> part of default to only being part of max for guests without (affected)
> "cpuid=" settings.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
This is a semantic change for how the xend string works. However, I do
agree with your reasoning.
I'm pretty sure it won't be safe to backport across my change to
effectively eliminate the s/k options, but that's fine because it was
the same time period where I introduces a distinction between max and
default.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
