[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/8] x86/EFI: sections may not live at VA 0 in PE binaries


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 1 Apr 2021 13:01:11 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6GBDxKhS3qtdNf++KnrNQw6MnOkE9dFm6CLdC2q+Nw=; b=nt4fG60JcxFXRFnzRLaL5afL9Wx+63vpBssTIUDK20AYJq+AKRoQhYDffb4Qgyy9vpuhDvAMg4WPLZqJU4mQydoYBgd3ZXZ5v4OwJXcw8Uloh0ZGnYdDb3keX5ibagSc4/IiXHwt59DLxXYRZbFEqryvpH2Rokr/P39Z6Mi04ij6+qtQyOTeeexEm9Ce1VJNhFKIDPZdAEK5nBBYaZUrIr4NHi5T40bBw8JsOhcD4qfgmHJPuz7H6Lts/2jaJRmqtMUGpPuWyS3RmV5wEfpoEjqEwtoUfJ43BsllyTFGPWQuGWtg/byadOQCJe0g8ffcPc+Vp1p92sehVzcY4eleQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sra4nDGMYlsgletTqRFWnEVZad0SW8Hbfw58z3jT6cjblMGwsVxon3DEoAOX62XMk6fTncAy+z8BSayWmpEcDlbGV6RjNod28FAddvWA+r+7RCrPI+bBrUSLG4uLMbtbnUX0zAPqrPTTl2vQQENfGt8hVPCdWhTw7kWRoT/t2/1jH0dKHuEqR6NT2UuKr7Wfljt8P5+uXalxAl9zyp+TE4TsndiI8mIt5chiTwVhxUUI0I80fJNUo8JAqnQ0v6DVb4nWDZuMgpfNPob+XVU3SgjyKh2DvcSZZqx2nLg8G03lcI/iPNISaLRFMYlQFLlULetJCH+8qYqUekiRZZZuqw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 01 Apr 2021 12:01:30 +0000
  • Ironport-hdrordr: A9a23:1KHQDqjCJ4/RgekKHXb8tERD13BQX3dw3DAbvn1ZSRFFG/Gwv/ uF2NwGyB75jysQUnk8mdaGfJKNW2/Y6IQd2+YsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmuZ tIW5NVTOf9BV0St6vHySGlDtctx8SG+qi0heHYi0xgVx1udrsI1WZEIyywe3cGITVuL5w/CZ aa+45jrz2vZXwYYq2AdwY4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZjbxpkx7A+/W /Z1zHo/6nLiYDH9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFfxccpKYujRdmpDJ1H8Ll5 32rw4kL4BP7RrqDxuIiD/M/yWl7zo08X/lzjaj8AjeiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WJ2/HyWx5njUayq3Y5+NRj60B3aocCdKRX6bUW4UI9KuZxIAvB9IslHO NyZfusgsp+TFXyVQG6gkBS2tC2Glw8EhCaK3JywfC94nx9mXB0yFYg38oPnnsM34JVceg028 30dotvj71AVckQcOZUA/oAW9K+Dij3TQvLK3/6GyWpKIg3f1b277Ln6rQ84++nPLQO0ZsJgZ zEFHdVr3Q7dU7CAdCHtac7vCzlcSGYZ3DA28te7592tvnXX7zwKxCOT1gojo+Jv+gfKtezYY fxBLtmR9vYaUf+E4dA2APzH7NIL2MFbcETstEnH3qTv8PwLJHwvOCzSoeSGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1z3fEjS+o9xDbj68+AfxJNlDPwIjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quUbEhl8ZfiZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+iLh97RMXGLR 5Hqz1MiOWKBq3V4RpnJ8OsM2qcgXdWjmmNVY0glqqK4tqgXZ8kEJA8WuhUGR/QHxJ43SZmwV 0zKTMsdwv6LHfDmK+lhJsbCKX0bN9nmjqmJsZStDb4rkWTpcYmQ1MBRD6wWcurgQIjLgAkxG FZwus6uv6tiDyvIWwwjKATK1tXclmaB7pAEUC4folOo6vqfwtxVG+OojSfh3gICyzX3nRXol akATyfePnNDFYYnnxDyK7l/Gl5cXinc1tqZmp3tpB8Emr6qm9+uNX7FJab4i+0UB8v0+sdOD bKbX8pLgRiy8ue+TSVlDyBfE9WjKkGD6j4NvAOYrvT0nSiJMm0jqkABeZT54sgHsvpqPU3Xe WWfBK1IDv0B/gy4RGcom8oNUBP2SAZuMKt/CegwHmz3XY5D/aXHU9vQKsDJcqAq0fjXPSF3f xC/JsIlNr1Fl+0TNGIyavaNWEebjzSpHO7VOEup9R/u7kouL56ApncVn/p2Rh8rWIDBfaxsH lbZqJxpI3lEMtIWec5fipC5FonlNiVNiIQw0fLK957WWtotmPROtOC3qHBprUuCHCQvQeYAy jqzwRtu9P+GxaZ3bEUC6gMMX1bRUg15nNl5v6DfeTreXOXXtAG2FqxKXmmdrBBDICDBLULtx 5/iuv40tO/Rm7d2ArKuyF8Lb8L22G7QdmqCAbJPeJT6dS1NRCthaStifTDwAvfeH+ea04Cg5 dCelFVRsNfiiM6hIly6xOMcMXM0woYumobxypmmF7r0pWn52mePXguC3ymvrxmGR9JMnaJis zZ9/O/z3qV2kkc5aX+
  • Ironport-sdr: Jaub2kREXajW/MpPqJOqLmWOhr0a6/H/Si9cJazw9ZSempVLcCvpwqLkDNxhdflWFXPZ4kYPjz I70z47dbB9ZlkbmQDTHmro9l/LdxzKIsky1t0u0MSME5uoKfQj1L5uMDxlkGJihfQhFEQOMEvf JU5Vhy7/KedMSFZla1HSU9HG9+koPSulFSkB5CLZm3SaAU4UL8sNksZ6Ea40ZwwO4mT0h3QdS9 KPrhLQ7+Pk8RVtf57LY2DS60W8PvJbz36G3Uvb97/raGmDpXSdplEl1bjC4uTFRdvgZJZQrBmi XWs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01/04/2021 10:44, Jan Beulich wrote:
> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at
> least 2.36 would silently truncate the (negative) difference when a
> section is placed below the image base. Such sections would also be
> wrongly placed ahead of all "normal" ones. Since, for the time being,
> we build xen.efi with --strip-debug anyway, .stab* can't appear. And
> .comment has an entry in /DISCARD/ already anyway in the EFI case.
>
> Because of their unclear origin, keep the directives for the ELF case
> though.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> It's certainly odd that we have stabs section entries in the script, but
> no Dwarf ones.

Its not odd in the slightest, given the heritage and lack of anyone
touching the linker file unless something is broken.

We've got dwarf symbols in xen-syms, have we not?

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.