[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] x86: don't build unused entry code when !PV32
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 1 Apr 2021 15:31:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udhhZcGEPQ7SLgOVIOZqqyiA5alT0Gfr+eK9vE2UNaM=; b=KSXejOBa0XbQQKU0Q4R/IpPjyUTR9Tzq4GuAYG498djAjnGYk3DHML+3hI23FAwvHiPJTM5jwsa7drtm55Tqi4LsYVuBFtZoz8mC7HECFIhkmnI83LOszwXdush7WWPMFAzcjBt8TRYIBSF0siaAmnWUSUdCfDtFihNk2YBLCFuEIGYd79ZDC68pKiMXlSDeWW8K8dAJazpsI3SJPQCsJP8CAeHAYPXI/L+ylBDTXT75v8Dh90KQMT1BJaK4r1Dc7N7Aq+v5rRPkL9abWlw75ChmQ8Y4yR6z8ItC4Ue1ID5HcXwtTTPLFv3Dw9+l6+rxxZBZ2pnnAEmlVy98xmdDIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPBM5Tc+T0dH8I+EGBmklATit0fKTH31R+ewPuNlWOHRYmBThTs4VlNtg1/tE0fjbqy1ZkX4aNcOMw0orRTE7QF/LYpmnIl/75YWCNVhARo5eZ0PKQncjk9Mfp+SzSPAPeaNR7c0/CFPRa97ht3Y5TOQ3Zv4GeRIpKr207VKpS5/DvppVu1yudmcc2nrnJnUYRLkx6D3uJpiSskyfXDcN6zC5r6mUTQxz9J2oMwZC74ZwuOFlkrSDCR/zc45N4KvJVf7QeHXd3VfRFYVUtFrjZ+vDh2zLixGYwLI4M2eKkqNzYv0pUvmpxRbPNZXfoGBjc/oXrlQw3cXAIC8GwXqqA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 01 Apr 2021 14:31:53 +0000
- Ironport-hdrordr: A9a23:PjZ3dKvKpLCOqbtp0uTmAO/V7skC54Yji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOjLU5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Q26Y 5JSII7MtH5CDFB5vrSyAOzH888hPyO9661jenTpk0dNT1CQadm8gt/F0K/Gkp5WAFJCfMCZe Ghz+BAoCetfmlSU9SjChA+LqP+jvDotLajWx4JABY79BKD5AnF1JfWGwWVty1uNw9n7qwl9Q H+8jDRxqLmiP2jzw+Z6mm71eUupPLE6v9uQPOBkdIULDKEsHfjWK1EV6eZtD445MGDgWxa9+ XkmBsrM8Rt5365RAjcznXQ8jLt3zo053jpxUXwuwqEneXCWDk4B8Bd7LgpESfx1ks6sNlwlI JN0m6J3qAnaC/ooSXn69DEEyxtj0q/yEBS89I7sno3a+sjQY4UibZa0FJeEZ8GEi6/wpsgCv NSAMbV4+sTWU+GbljC11MfjOCEbzAWJFOrU0ICssua33x9h3Zi1XYVw8QZgzMp6I89cZ9Z/O 7JW54Y241mf4szV+ZQFe0BScy4BijmWhTXKl+fJlzhCeUhN2/SrYX0pJE4/vujdpBN7JZaou WObHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo5djvLnxQ6fqLD2DRFgin9DImYRePuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFM0Z0+xLGG6mk4buEMnHp+bbePHcKP7GCjA/QF7yBX MFQXz2LMVE5Ua7R2/gjHHqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOLyZDvKwwdE 53O6jmjau/uGmz8Q/zniRUEysYKnwQzKTrUntMqwNPGVjza6w/t9KWfn0XwGGKPQZlT8TdEB dWolN+/a7fFe3U+QkST/acdk6KhXoao3yHC6oGkqqY/MH/Z9cTFZA9QpF8Eg3NCj14kQtns3 14dQcBX0PTfwmezZmNvdgxPqX/f8M5qBq3KcRUwEivz3m0lIUKfD8neBKAFeSQmh0jQjJIgE YZyd5jvJOw3RC1KWU+h+wkNkZrc2r/OsMKMC2MeJhUlrf3eAt5UGeNgniAhwsuf3fxnn9i+l DJPGmaf+rGDUFavW0d2qH28ElsfmHYZE5obGtm2LcNY1juqzJ20eWRYLC03HbUYlwewvsFOD WtW0pnHip+g9S23gWSgjCMCDEvwYgvJPXUCPAmf6vI0n2gbI2OmqduJY4iwL91cNTvuPQMS+ SRZkucKy75Efog30iNvWk+URME20UMgLftwlno/WK41HkwDb7bJ0lnXagSJ5WZ43L/T/iF3Z 1lhbsOzKKNG3S0bsTDxbDcbjZFJB+Wu2KwQu0yoZ1fvK45ttJIbuzmeCqN0GsC0AQ1Lc/ymk 9bXb9y56rZPJRzO8MVYCBU8zMS5ZyyBVputhazBOAwfVsg1SCGe9yI5qfFsropDAmKohDqNV yW7i1a+LPEUkK4pM8nIrN1JX4Tbk42rGlm9qeFcYbbDQ2xbeFN/FagKBaGAc1gYbnAHa9Vtw pw5tGDgvSeeCX50h3BpDcTGNMxz0+3BcepRB+WEeFG89amKU2Bj6uj7sm0lir2Q1KAGjQlrJ wAc1cRYMRFgiQji4Ny0jHacN2Jnn4Y
- Ironport-sdr: D2Qlt4VVMjKNS4+eJIO14HGPMG9+zWq6igtFUyICVMFCsYSNPC9Ewf/P3V68zhDoRx11Htna8i QnvXC+mqaTo98/nd0fH0QDisGZqq1tOf/tTtXpe9FcBMCmOUUVCES7Pj8iJBYw0CuV71ZVTwtN EPNHDb4LvTn6K1HmlX5SiUD55lQHnoFTTzvyUloArHAolVEPKIavQSkMe2pcVRx9+2DXapXy1d 2LBFhI0pVKOdbIiqT+UNwPlZs/+OXt/zKXfC9KraQu5ToIL4eglpoMxBKeRWNnkit1qlMT2QRg 970=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/11/2020 08:51, Jan Beulich wrote:
> Except for the initial part of cstar_enter compat/entry.S is all dead
> code in this case. Further, along the lines of the PV conditionals we
> already have in entry.S, make code PV32-conditional there too (to a
> fair part because this code actually references compat/entry.S).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> TBD: I'm on the fence of whether (in a separate patch) to also make
> conditional struct pv_domain's is_32bit field.
>
> --- a/xen/arch/x86/x86_64/asm-offsets.c
> +++ b/xen/arch/x86/x86_64/asm-offsets.c
> @@ -9,7 +9,7 @@
> #include <xen/perfc.h>
> #endif
> #include <xen/sched.h>
> -#ifdef CONFIG_PV
> +#ifdef CONFIG_PV32
> #include <compat/xen.h>
> #endif
> #include <asm/hardirq.h>
> @@ -102,19 +102,21 @@ void __dummy__(void)
> BLANK();
> #endif
>
> -#ifdef CONFIG_PV
> +#ifdef CONFIG_PV32
> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit);
Even if PV32 is compiled out, the is_32bit field still exists, and is
still necessary for crash analysis. XCA parses this offset information
as part of dissecting /proc/vmcore.
It's one single bool in a fixed size allocation which we've got plenty
of room in. It can and should stay to avoid impacting the existing
diagnostic tools.
~Andrew
|
