[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/21] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 1 Apr 2021 18:44:02 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+791JNpeEdaqd7sL8/wPJrh4NVafG8GswQ+wOJdn8Cg=; b=j9XlgDMaSoTjBmIMTaSdDB6gXQQznmi5VLhRdMbqKFBCddd/mT9akQNm/FWpHzmkEN6MhZvlZpUarUeuiRw6QbW80k16Jdm2Q245AiteUdC9qKTBIo7XdvUsqy5EVuyitPF+YATbgXZUdOtgsgQjbLvBAewe75c5h+rG9g+R8HTze7ZNfA6WUquPGhrUFwW30PmuxxZRR61klPy1M7bTBJ6MA7m5+sb1GUROMJ6gYVyYIdw33BkxPEVio99dF6xJUPzVuaipVqRqwlurpchKd/8ddP1jaG5FicagdPTq8TrNCAec1IeZZ/zXa9+3zLpqIQ5ItdmcCgMmxdmyovVrsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SeVm0ZCRELaqX9eG9DkrJd405agACnmMP2L5JXfCHOlAs3lz8jKOfL7VyrhSOZgYLHLKbcKO76Rtk+2PtAS60hKRJ6w34ddQKiOR0x2JT+sjTPZnnbu8k7ZCRn0zZHLFPZ1qGAtALACGPQPAeDduMLrtLZVckqTEREghwvgBfsz3b66yEpgex0DYBdiDB0RDD99dsodqbw+pJLCBJvDIxglYkUYZxiQMY3R58TyNU3j4hlk/08C0nIcNvCYaVSWwapuf/rDU/p0m0Mmi++MFxEXT/KIM8Xal4BVtYRlfrvFcBIzHf9rW9jOyIcIEqqvkqyxzgKkDvgaGBMgdmUcmaQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 01 Apr 2021 17:44:28 +0000
- Ironport-hdrordr: A9a23:UBRIVa//5mftcagWf5xuk+F1cL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2OmO2dxQxRLAod8MZ Ka6NZOqTbIQwVpUu2QAH4ZU+/f4+DRnJX9bhIcQzIh4g+CjTSngYSKbySw9BEYTj9J3PMe4X HI+jaJm5mLntOa7lvn12HV54lLg9eJ8LV+LeGFl8R9EESVti+Gf4JkMofy2wwdgObq01oylc mJnhFIBbUI11r0XkWY5STgwBPh1jFG0Q6Q9Xa9jWH4qcL0ABIWYvAx/L5xSRfS50o+sNwU6s sitAj4xvkneC/opyjz68PFUBtnjCOP0B4fuNUekmBFVs8mYKJRxLZvjH99KosKHy7x9ekcYY 9TJfzbjcwmE2+yU2rUpS1GztCqQx0Ib2y7a3lHkMmU3z9KpWt+3ksVyecO901wha4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8f166EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIOz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQfHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9tDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjbQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCL1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Zm31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EdXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EQTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03dtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywRO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xy/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd9BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfA7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q+6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXFEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0DfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpL1S6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 tHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+eXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn7doXH5mQ/k1Vf5jl7llninqieiV2rY31uAEn+mZVZXT5aL36Sq9 /KmNLojEjA3A==
- Ironport-sdr: lPQNur7rz93qhrVQe/y/aFmx6nG6P5Xq6ZfvKzbP4Pmmz5Vkp1FnJ8mZNMDCEWM4sG0Bda9MAg zn5Aqh+H/OfhhVQq5KfSOu85P6mX+LY2wdbcwL16ZtsWZ1bws+zSIFWFo2P5EYV90Zisdnf/cU vo7EGGuw5NvYsV2kAgGDKWXxsrB0w7gzxBZymSM9KgFIf92oUk9G4q5pFkctRiEThpxRHD1wSa loBgKCub0dPOGV6pYQgtPqgD1r+1rEXP5SDV+JBNw7hQ1oL/UZhGZ+SrZ9kH4ReFKoichBCLE3 ncY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/03/2021 09:58, Roger Pau Monne wrote:
> With the addition of the xc_cpu_policy_* now libxl can have better
> control over the cpu policy, this allows removing the
> xc_cpuid_apply_policy function and instead coding the required bits by
> libxl in libxl__cpuid_legacy directly.
>
> Remove xc_cpuid_apply_policy.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> I'm unsure why this is called libxl__cpuid_legacy, mostly because I
> don't seem to be able to spot a libxl__cpuid (ie: non-legacy version).
> Should this be renamed to libxl__cpuid?
>
> 1b3cec69bf300e012a mentions the process of switching to a new cpuid
> interface, but I'm not sure we need to keep libxl__cpuid_legacy, since
> that's an internal interface that's not exposed to libxl clients
> anyway.
"legacy" was referring to the pre-4.14 migrate-in problem. It was the
best I could come up with without having a firm plan of how this series
was going to look like.
That said, the resulting function is still very definitely doing thing's
I'd consider "legacy", so perhaps it wants to stay named like this until
we've got a better plan for how to enable non-trivial features.
~Andrew
|
