[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 6 Apr 2021 16:13:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FFQSFE5Ykvq6/LpHS2MvCngSqL58CoX0TTlRAuPYais=; b=HCkYD+wzwL6pdMGcuHn+q4v4FaLQulvl664ZwLdCLqe+tSg2BVCZe1qDbLsd3MjxqrzEYMKT/GCjVSQcbGioo5NLBdVpWqa2giWGrAVItw2Ydea/flQs8pF8Z9onOR0kLE4tSJrckVKYXRWUdikR0wcDZQw4VvUvnVgELMTfsyizfAW11Ulwyp6j5Kp9gRy8HMud3QLw4XXXEQhNSrDeiB8JEjz+Tx5j9vEEJ9+kLuQs2ZtlmmQl0QxFrIWdKEHuGWISl8+V5UUndLXEB7O0CYrGA+TZ7Ak8V6WuzsXnnwh5zYTOUsRmlEY/tX9/TUy8PvUb7wfN2D0Lkb/2AnQj2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LS6Q737OQMKROoAIo3uXx5vbNBs7DUQsn3iYs2GZeJZq+hucW0RROjfuHrD79nW2tRr/T25j7c8uxRmwKurSqWBWrZSlnsHpGOBictKpQpUj7fdhTYMAT5jsJaVhUC1feAVXYmJlcdHVKIWjNREVqlN122Oyx5vGJOcMNQ/RCL9nryKCaYl0iI4Zls6WAKBSogfGBM8u2e/zq8kAxRQPF+5Mh6FlF2ePj+EMgzmcroJytigh+15yOC9gQKrF+pzyIyl2FLfatqe80sKZeIGXx/hQg1112xy2t27wjvfBDNTqfOECktLjmI3R1VwfpvTxYAJFH9uFUTWIQQRJZ3nENg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Apr 2021 14:13:55 +0000
- Ironport-hdrordr: A9a23:2r1bgKy0yLMald3V05+OKrPxve4kLtp033Aq2lEZdDV8Sebdv9 yynfgdyB//gCsQXnZlotybJKycWxrnmqJdybI6eZOvRhPvtmftFoFt6oP+3ybtcheTysd07o 0lSaR3DbTLYGRSpdrm4QW+DtYryMSG9qftvuvF03JxV2hRCp1IxS0RMHf9LmRdQg5aCZ0lUL ed/NNAvTq8eXIRB/7LfEUtde7FutHNidbacQcLbiRXkzWmoBGJzPrBExae1goDSD8n+9kf2E XMjgCR3NTAj9iV0RnZvlWjiqh+uNyk8ddbAdzJt859EESQti+NRKBMH4KPpyo0pubH0idarP Dprw07N8p+r1P9F1vF2CfF4AXr3DYw53KK8zbx6hGC0K+JNw4SMMZPiZlUdRHU8SMbzalB+Z lGwn6DsN5vBQ7A9R6NmeTgbQ1glUa/vBMZ4IgupkFYOLFuDIN5nMg0+UNYF4o4ByTq6IwrO/ kGNrCi2N9mNXyddHzXpW9p3ZiFWWkyBA6PRgw4ttWSyCU+pgE182IogOgk2lsQ/pM0TJdJo8 zCL6RTjblLCusbd7h0CustSda+Y1a9DS7kASa3GxDKBasHM3XCp9rc+7Mu/tynf5QO0d8bhI nBeEkwjx9yR2veTem1mLFb+BHER2uwGR73zNtF2pR/srrgAJL2LCy4Tkw0mcfImYRQPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOIPvNIWXE+Pv9LrJoXmuvezSoeRGJPdVRIfHk/vCH oKWzb+YO9a6FqwZ3P+iB/NH1PhE3aPv65YIez/xaw+2YINPopDvkw+klKi/PyGLjVEr+gTdE t6K7X3r7OjqQCNjCP1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXmxOwn2dJFtaQ9nNGA BS43R7kJjHYKC49GQHMZaKI2iah3wcqDahVJEHgJCO4s/jZ9cfFZYpWKt4EC3RDBxrkQNWqG NOATV0BnP3J3fLs+GInZYUDObQe51XmwGwO/NZrnrZqAGhv801f2AaWDSvSMaTpg4rS1Nv9x lM2p5apIDFtSekKGM5juh9FFFXcmyYDIhLCxm/aJxOlqrmfxxxSmm2lSWX4itDClbCxgE3vC jMPCeUcfbEDh5mtndU3r3D3Xl0em+eFngAIkxSgMlYLyDrq3xz2eiEau6PyGOXcEIF2fxYGi rCeyEuLgRnwM2X2BaZlC2ZL2gvwowjM4XmffMeWoCW/knoBJyDlKkAEfMRwY1sM8r2tPQXFc 2YYA2YIVrDepQU8j3QgkxgHiZ6qHMpy6y1nDLk6XW1x345D775Jk98S7QSPtGb6CzFSp+zoe BEpONwmdH1FGP7LuOi4+XwSRVoLxvIu264T+0ys/lvzOsPnYo2O6OeaCfC0XFM4Q43I8j1nn 4PWagT2sGyBqZfO+gpPx9D9lUnlN6zPFImnwz/DOg5Z0wshRbgTqe0youNjbokGUuaogTsfX GZ7i1G5v/ANhHznoIyOuYVIW5MblI752kn1OSed5fIAAHvU+1Y5lK1Pjucd7BaIZL1U4k4n1 Jf49uSmfWQeDe98AfMvSFjKqYLyl2Ze6qJcXSxMN8N1ce7N1SKirar58D2rA6fc0rGV20owa tfdUIRacxfjCIFl4Nf6Fn1dpDK
- Ironport-sdr: Wc4geeFj6gQ0luS0NJQOsjnPWfq5BOhTZp1YbtRK9kBfjE4W2guOFiVYXS4pUVYfIUzwoeJ7vu NrCNJbZ8Qu3oHg6Dt9lHZvqyx7rckyIeLC0cYc+TNUHPKi5nSr+LiXHSfES6XcpOGUtpdlODoD Lmzhp1hs20LQyiuxZj4vzlh72Qhb12Qcw5sp0SnUqGOOsgZ0Ekq+EJBgb6aOmUHgoG1nxfThcj QUCFc1hRq/iksmXPPKCL2FPWoRrKpZx4HAGgTO0FQVWOQODNHxQENGbY8mKAPkWAc/6oDD7gDp D4Q=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 06, 2021 at 12:39:11PM +0100, Rahul Singh wrote:
> MSI support is not implemented for ARM architecture but it is enabled
> for x86 architecture and referenced in common passthrough/pci.c code.
>
> Therefore introducing the new flag to gate the MSI code for ARM in
> common code to avoid compilation error when HAS_PCI is enabled for ARM.
Is such option really interesting long term?
IIRC PCI Express mandates MSI support, at which point I don't see much
value in being able to compile out the MSI support.
So while maybe helpful for Arm PCI efforts ATM, I'm not sure it
warrants a Kconfig option, I would rather see Arm introduce dummy
helpers for the missing functionality, even if unimplemented at the
moment.
Thanks, Roger.
|
