Re: [PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const

[Julien Grall <julien@xxxxxxx>]

Hi Roger,

On 06/04/2021 08:24, Roger Pau Monné wrote:
> On Mon, Apr 05, 2021 at 04:57:02PM +0100, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > The function sh_audit_flags() is returning pointer to literal strings.
> > They should not be modified, so the return is now const and this is
> > propagated to the callers.
> >
> > Take the opportunity to fix the coding style in the declaration of
> > sh_audit_flags.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> While doing the cleanup I think you could narrow the scope of the 's'
> variables also, but doesn't need to be part of this patch:
I think you are right. I will look at it as a follow-up.

> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks for the review!

Cheers,

--
Julien Grall