Re: [PATCH 1/2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel

[Julien Grall <julien@xxxxxxx>]

On 02/04/2021 16:21, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Currently, we are ignoring any error from perform_gunzip() and replacing
> the compressed kernel with the "uncompressed" kernel.
>
> If there is a gzip failure, then it means that the output buffer may
> contain garbagge. So it can result to various sort of behavior that may
> be difficult to root cause.
>
> In case of failure, free the output buffer and propagate the error.
> We also need to adjust the return check for kernel_compress() as
> perform_gunzip() may return a positive value.
>
> Take the opportunity to adjust the code style for the check.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
>   xen/arch/arm/kernel.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index ab78689ed2a6..f6b60ab77355 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c
> @@ -292,6 +292,12 @@ static __init int kernel_decompress(struct bootmodule *mod)
>       iounmap(input);
>       vunmap(output);
>   
> +    if ( rc )
> +    {
> +        free_domheap_pages(pages);
This breaks the build. I am not sure how I managed to test it before... 
I will send a v2.
Cheers,

--
Julien Grall