[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen-pciback: reconfigure also from backend watch handler
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Mon, 12 Apr 2021 11:55:41 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atlzDi+DE6NBgRjfwgIjKyPIgX00s/eE046Xp+kC4EU=; b=eRfSLphhACcRZv28lTmMcsmFE5CuSzCCIwmVHOTa+25VIkeZU4T1EBzjPyHdaz40zltMfLfpb7sWoNCDHmsIsn0hVkSNzT5QEjc1IN37jcY/MCKIv8KsxpFL8Uo72F5DHiOmgfauQDwBGDXlQaztbd+l12lt1FNbgpr+jpf3qg1WqHV4ZDMi9KLU46jvDxSzqCigWsTS7qVeOQ8zQYpK3sTsFQL6LitNJsknISKU04ndH8BFJYWxoMKJL3lp1CkIcLSZGgAhowy7gT3SZNlyT6msR4LgLLBIfaEpkn6NDgNrojiQWFOpioqLZME4qgiFCOh0skeCPfPyDbRn1eODYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z+l5pE3zNq2uxdQ5upshF0YWqI44jWP7Ogygt2Uh5F9Qfmm8P+K4Uq2VdHtH7zPWRZL1ZRQvTnAbn2hAtTqWg/F3Nr8TS/vlDznp+ixyOaz4jUveHZyOdt2pNGUVF/56Gc6K79EgDJQZbc0wRC1xDoPUD04okS+r5ZItEuwHQ6nBK1Z54lvQlqBDBdkbApWFAa78+gJB+CzkW8tTyNlK8UBAAzqsFj1b1INjQLe2phwHZUgv0FeulD74DYE1KGCYzCKS7jPdCfNCdNePki+Elxpo7quuNeYAH5GcqH2q6VPay50dhiRFOacyynEVOfixrLNQSAGDmjHbstRDyQFRgw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 12 Apr 2021 15:55:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/12/21 5:44 AM, Jan Beulich wrote:
>
>> It also looks a bit odd that adding a device is now viewed as a
>> reconfiguration. It seems to me that xen_pcibk_setup_backend() and
>> xen_pcibk_reconfigure() really should be merged --- initialization code for
>> both looks pretty much the same.
> I thought the same, but didn't want to make more of a change than is
> needed to address the problem at hand. Plus of course there's still
> the possibility that someone may fix libxl, at which point the change
> here (and hence the merging) would become unnecessary.
Merging them would be a good thing regardless of fixing libxl. But I agree that
it is separate from fixing the issue at hand.
Maybe rename the function? (I myself can't think of a good name).
-boris
|
