回复: [edk2-devel] [PATCH v3 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

["gaoliming" <gaoliming@xxxxxxxxxxxxxx>]

Reviewed-by: Liming Gao <gaoliming@xxxxxxxxxxxxxx>

> -----邮件原件-----
> 发件人: devel@xxxxxxxxxxxxxx <devel@xxxxxxxxxxxxxx> 代表 Anthony
> PERARD via groups.io
> 发送时间: 2021年4月12日 21:30
> 收件人: devel@xxxxxxxxxxxxxx
> 抄送: Laszlo Ersek <lersek@xxxxxxxxxx>; Jordan Justen
> <jordan.l.justen@xxxxxxxxx>; Ard Biesheuvel <ardb+tianocore@xxxxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx; Anthony PERARD
> <anthony.perard@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Michael D
> Kinney <michael.d.kinney@xxxxxxxxx>; Liming Gao
> <gaoliming@xxxxxxxxxxxxxx>; Zhiguang Liu <zhiguang.liu@xxxxxxxxx>; Liming
> Gao <liming.gao@xxxxxxxxx>
> 主题: [edk2-devel] [PATCH v3 2/7] MdePkg: Allow PcdFSBClock to by
> Dynamic
> 
> We are going to want to change the value of PcdFSBClock at run time in
> OvmfXen, so move it to the PcdsDynamic section.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx>
> Reviewed-by: Liming Gao <liming.gao@xxxxxxxxx>
> ---
> 
> Notes:
>     CC: Michael D Kinney <michael.d.kinney@xxxxxxxxx>
>     CC: Liming Gao <gaoliming@xxxxxxxxxxxxxx>
>     CC: Zhiguang Liu <zhiguang.liu@xxxxxxxxx>
> 
>  MdePkg/MdePkg.dec | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index f4156920e599..8965e903e093 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2265,10 +2265,6 @@ [PcdsFixedAtBuild,PcdsPatchableInModule]
>    # @ValidList  0x80000001 | 8, 16, 32
>    gEfiMdePkgTokenSpaceGuid.PcdPort80DataWidth|8|UINT8|0x0000002d
> 
> -  ## This value is used to configure X86 Processor FSB clock.
> -  # @Prompt FSB Clock.
> -
> gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c
> -
>    ## The maximum printable number of characters. UefLib functions:
> AsciiPrint(), AsciiErrorPrint(),
>    #  PrintXY(), AsciiPrintXY(), Print(), ErrorPrint() base on this PCD
value to
> print characters.
>    # @Prompt Maximum Printable Number of Characters.
> @@ -2372,5 +2368,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
> PcdsDynamic, PcdsDynamicEx]
>    # @Prompt Boot Timeout (s)
> 
> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|0xffff|UINT16|0x0000
> 002c
> 
> +  ## This value is used to configure X86 Processor FSB clock.
> +  # @Prompt FSB Clock.
> +
> gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c
> +
>  [UserExtensions.TianoCore."ExtraFiles"]
>    MdePkgExtra.uni
> --
> Anthony PERARD
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#73954): https://edk2.groups.io/g/devel/message/73954
> Mute This Topic: https://groups.io/mt/82037830/4905953
> Group Owner: devel+owner@xxxxxxxxxxxxxx
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@xxxxxxxxxxxxxx]
> -=-=-=-=-=-=-=-=-=-=-=-
>