[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/4] xen/arm: Handle cases when hardware_domain is NULL



Hi Luca,

On 14/04/2021 10:14, Luca Fancellu wrote:
Among the common and arm codebase there are few cases where
the hardware_domain variable is checked to see if the current
domain is equal to the hardware_domain, change this cases to
use is_hardware_domain() function instead. >
Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
---
v4 changes:
- removed unneeded check for domain NULL from is_hardware_domain
   introduced in v3

After this change, this patch is only avoid to open-code is_hardware_domain(). Although, it adds an extra speculation barrier.

I am not against the change, however I think the commit message needs to updated to match what the patch is doing.

Can you propose a new commit message?

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.