[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/cpuid: support LFENCE always serializing CPUID bit
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 14 Apr 2021 13:49:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFe5AyKIYZ6R8ytjJFK0IlNDoqyNylHCztAikAkr3c8=; b=Hb1hCiHJOwQ8fe4MoqKdby/cBe1Q3fUKxZXpgqfLZfHCpb4fTD/tXBbuYIFEYPvU428LaOJTVNAEbouDt5wpFQuD+ziJwIM2CDMDwO+IQ95+BukBnyHROlK83KLGLWDBouXA27wAya0oB0Lj6T6p8a55jKfRW1WO5exBU2NQDSRqT3rf/tN3ICuFTqknAper+Yu4gdgMmcJh8kMx/wIh2shMNNJRNV5rZO3gUEgyGe7fIikN4cS1d3Kz5U7xBbSjr+4piK9TxogxVNMvu7cbs5/8E8KGkElMYgPTvnsNSyG3e3JEhUFdUuQm8eWxCZ1KdhnlHeDPqApKo2895y0Qyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZt6iwMGTfg5aMF3ZzTCMbsncj6e4uVJJ5q50Rxuyw4V5GdhN1dYQZ9zeABrmYSi/rzFb02QzwQKipOU5vRgoy4kRAivH6kF3NPNAGhaZu8XRCq5NDeKNajRwD0uXxmScrQFYgvjK0vpAHAEU1JoAWbD1h8nScODLhLGpo8aqUvdkjaINXElWsuA7QIxdPFKSLse121czEFCN24zQCmRwxWzxuRy9WeTyFpiEYx6D549WexFHmJCJu/FDJU9Ky82mechzHc7nhV5jnFctz+qNrqHXWgkvikSjOSTD1jlcNzfZ/nCQ6B0j/GrPXO1/qUe1rkyR12t9uzHGXzPCsxS8A==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 14 Apr 2021 12:49:17 +0000
- Ironport-hdrordr: A9a23:drXaqqEasEuJ7VLxpLqFvZXXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7MBbh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1Tbak/D38Zn/+ Nbf6B6YeeAbmRSpczx7BCkV/Mpx9ea+K6l7N2uv0tFZysCUdAZ0y5SDAGHHkpqACxPApQkHJ SRj/A31AaIU3IRc8i9Gz05RODFvdLGj9bLZhQBCh4h5mC1/HGVwZT9FAWV2QpbbiNXzd4ZgC v4uiHw+6nLiYDG9jbyzGnWhq4m/ufJ6twGP8CUj9hQFzOEsHfYWK1AQLuEhTYvvaWUxW1Cqr LxijMBG+g21H/LZGGypnLWqkzd+RIj8WXrx1PdoVaLm72HeBsAB8BMhZ1Uf3LigiJM0L4Tsc I7uxP/i7NtARzNhyj77dTTPisa6Hacm2YokuIYkhVkIPAjQYJRtoAW8Qd0F5oNDUvBmf0aOd RuF83V6bJqd0qbZRnizxNS6eGrN05DZyuucwwjocqT6j5MgTRQ8CIjrvA3rzMlztYQWpNE7+ PLPuBDj7dVVPIbaqp7GaMoXda3Inale2OJDEuiZXDcUI0XMXPErJD6pJ8v4vuxRZAOxJwu3L zcTVJjs3IocU6GM7zI4LR7tjT2BEmtVzXkzc9To7JjvKfnebbtOSqfDHcjjtWnuPdaJsHAQf 68NNZ3DpbYXC3TMLcM+ze7d4hZKHEYXsFQkM08QUiyrsXCLZCvuffcdPrVObrxATcpUm7yGR I4LWDODfQFynrudm7zgRDXVX+oUFf454hMHK/T+PVWyIVlDPwWjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quWLB72BjPAtBHl9YiY+QCU9ilEsvCQfZYLwDs9KQdSR5x32cPCJySMvQDU pYvFR4+aW+KpSK3iA8A9e7MmaX5kFj/U6iftM5oOmu9M3lcpQ3AtINQ6pqDzjGEBRzhEJ3sm tZcRQFQUXeDzvqjq2ggPUvdbziXug5pD3uDd9fqHrZu0nZmNomQWEDWSWyFeSNhxw1ejZSjl pt0qMWjbaagwyzIW8njOlQCiwRVE2nRJZ9SCWMfsF9h63icgAYdxb5uRWqzzUIPlfM22pXrG r7NiGQcezMGTNmywVl+5ev1kh1eGWbd193cVZgv+RGZDv7k35uzO6GYbey2WONal0EhvoQKi 3BfCF6GHIb+/mnkBGSgzqMDnMg29EnOfHcFq0qd/XJ1mqqM5Dgr9BGI9ZEuJJkPsvpqOkFTK aWfBKUNirxD4oSqkOoj2dgPCl/s38/l/z0nBXj8WijxXY6Rf7fOk5vSb1eI9aS6QHfNri1+Y Q8idI+pu2rNGrtLtaA1KHMdjZGbgrJvnTedZBjlblE+aYp8LdjFZjSVjXFkHlBwRUlNc/x0E cTWr5y7rzNMpJmFvZiOx5x7x4sjpCCPUErugv5DqslcVYhg2TSMtmJ77DLwIBfTnGptU/1Ix 2S4idd9/DKU2+fzrYcEbs3OnkTZ04m6nhuldnyPLH4GUGvbaVE81W7OHPmL+MYR6iBBLkKrh F1p9uPhPSaciLk2AbW+Tt3S5g+ulqPUIe3GkaLH+UN7tmxfVKLiaGu6NSojDj2RSCgAn5oyL FtZAgVdIBbljImjIcrySC8Raz8v1I9nzJlkEdav0+o3pLj/XzSEk5HOxDIm5laXTFcNX6TkM TOmNLonEjV8XxCwpnMFEBZY9FIFZwRV+HMXlBTFfQ=
- Ironport-sdr: gjYc6yjXK7NpMaaq61jU0/UcZ4nb+215+gM6WqeeJHL+JA+l4GTqAHspiBuOQzuae2RgYUBIsj wPkoMbc+wRjLubpIznMlbgeLMtzs3e6DYzRcdvp1vMEyeGnJhe2gUkslF7iWwJwhys4Wt2H1Dx tHZOuKxKBa6TE0HgjaLvauzVcf9R13HVwd4vEo2h0ugxk7wxQlJcM+Bj29bR7xAmD+0qKJ3AS7 gnDxxCJNzKEiRIDLwsGYh5R1HP69I/NiIKSmQZLBaLKsKhLJ8tlrc3p6BIqgEtteTdiXOiMyVz 7zc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/04/2021 13:45, Jan Beulich wrote:
> On 14.04.2021 14:33, Andrew Cooper wrote:
>> On 14/04/2021 12:04, Roger Pau Monne wrote:
>>> --- a/tools/misc/xen-cpuid.c
>>> +++ b/tools/misc/xen-cpuid.c
>>> @@ -178,6 +178,11 @@ static const char *const str_7a1[32] =
>>> [ 4] = "avx-vnni", [ 5] = "avx512-bf16",
>>> };
>>>
>>> +static const char *const str_e21a[32] =
>>> +{
>>> + [ 2] = "lfence-always-serializing",
>> This is a bit of a mouthful. One problem is the fact that "serialising"
>> is an ambiguous term, because neither Intel nor AMD formally specify
>> what it means in the architecture.
>>
>> There is a description of what "architecturally serialising" does, which
>> does occasionally move over time, and the name of this CPUID bit in the
>> PPR confusing at best, because it very much isn't "architecturally
>> serialising", and the term "dispatch serialising" isn't actually defined
>> anywhere.
>>
>> Intel have now started referring to LFENCE as a "speculative execution
>> barrier", but this still doesn't have a precise definition.
>>
>> I'm afraid I don't have a useful suggestion for something short and
>> concise, which also conveys the precise meaning.
> How about "lfence+" or some such?
Hmm yes - for xen-cpuid, that's probably fine, and for churn reasons, we
can keep X86_FEATURE_LFENCE_DISPATCH which was the best name I could
come up with at the time.
~Andrew
|