[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pv: Rename hypercall_table_t to pv_hypercall_table_t
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 16 Apr 2021 14:51:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aeohhhKKAm6meSXtE59Iz6vTz0lHGCF2S1wRzPflROM=; b=fY6Tw5zHNsKavdkrT3w2QngpcjJtKKpLoVFojy0moBmVoUdT6iCpsdoKQjz6aRW/C4CIlgsjSxXI2ZRkKowJItlMYqxBuOXIMQuznfVh/JXlCqfWn9oJC8fvs0utEHnO3oGQlq6qczdmD5LgS3u7tdDxvDjk05cWs6rNmhmnE+8jZ5OtioNCojkk4JeNMWNckvZbcyHBhnBPgbxjoZW85dN9jk7dfNs/W2t60FGG+ZXqL7bhKEgVYwLwygynIBzdepQ0UArXC49tnr8A5Ib6oHOqrg0bftA75MDBlmGOr7ZzDJHSbXoJZBL3qxoS5ZaqgWEDjmEckhEI6GL3KYDNdA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TXeMmXYQ93pYD8A/vy8k5x6xn9DmKAbd5pKyHoZBzlnXaFntLDSR8OIB1B15F/hbE6IzRA8gnDSSnojaQdznIOC+O1D0CTaSPVH+uUkPozTq9kXVnXAovqDA9gfQFXuVp/8rWc8vxuQo5KKVXaCXpMqxgXLjSIGWtpOJHF4Kg58dClXFlyv3IBmvLWPc2OA6LWMWKBM2jGt9Lof80Hr5hXaDVW5O8wkfPxbUrAz7Ytv0R7PiPtfhMQeXTV7YiGxsRZDDfo4P74L31q+U9Q5WfIfROsBL79zMOw6Zt3bprAeVaDeB4BZSc7ZJGCg2ErDTuPRjZZyIU2Cpkma/yzLLHQ==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Fri, 16 Apr 2021 13:52:08 +0000
- Ironport-hdrordr: A9a23:mRhZkqBwkw/UvBrlHekQ55DYdL4zR+YMi2QD/UZ3VBBTb4ikh9 mj9c516TbYgCscMUtBpfmuI6+FKEmxybdU5s0rMa6mTE3avgKTXeRfxK/v2SfpFSG71uM179 YFT4FbCNn9SWd3ltz75g7QKbgd6eKK+qypmuvSpk0FJWpXQppt4AtjBgGQHlcefngkObMCCJ Ge6sBbzgDARV0raK2Adxs4dtmGjfniuNbPZhYCFwQm8mC15w+A2frRNzC1mjsYTD9Lx64vmF K19TDR1+GGu/G/xgS07R61071m3OHM4Od5KPahsfc4EXHFoCyUDb4NZ4G/
- Ironport-sdr: vcUSk5pFwH9+ajPhtSmr8CticifXUW8WoylxarKijn3CnJfZc86dIW9stfhGxoGtnq7V/Ym7sR m/pjAYOAuSaELQWiu6mwlBVfK73CUmLOQ25GYsH3pU1V2PAMlz8v+/IvOaN9KE9Ujr3UflX5HH 6xWJEIiaLrMFeokZ+nwu39Es4dihJ5f5HEfa+BVxTIgrtIk69wdhbwEul79CiSEJQXi8armeu4 KXkOrVaQtCBLoGyUd4xeOMDwaolUGibDzGk6t+9SxK2UEhBXOPOobu+4XbNAtXUZwgC2t6u+yR qTw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/04/2021 15:04, Jan Beulich wrote:
> On 15.04.2021 15:21, Andrew Cooper wrote:
>> The type is no longer appropriate for anything other than PV, and therefore
>> should not retain its generic name.
>>
>> Fixes: 527922008bc ("x86: slim down hypercall handling when !PV32")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I'm not convinced this warrants a Fixes: tag (afaict there's no breakage),
> but in any event
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> I had considered doing the rename at the same time, but then decided to
> save on the extra code churn. I'm sorry if this was the wrong choice.
I would have requested the change on code review. Not necessarily part
of that patch, if it were easier to split out into an adjacent change,
but the patch did fundamentally change the purpose of the type.
Part of me still wonders whether it would be better to drop the type
entirely, as on the HVM side. However, whichever way you rewrite this,
you've always got an ugly plumbing problem with the pvshim alterations.
~Andrew
|
