[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: swiotlb cleanups v3


  • To: hch@xxxxxx
  • From: Tom Lendacky <thomas.lendacky@xxxxxxx>
  • Date: Sat, 17 Apr 2021 11:39:22 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GcdyVj41BYl03/aaPnzYLcCOx8MhOm28yR14v2uQR+w=; b=lrUHkoSYrhCM3NmHBP9O8JHXMyQHi4GsaC0wrMWL5dNlqvXOWwArLXIHpckispr2w51KIUdgS7budnpn05wqmIizZT59jN4DHq9GH6WInwegJ5oETU6jNe/Zk/nbkDzpY1Gwor+pVdk53nXScaPcBgl/efXEEembIYVE1LMhyaFq6nwf5LnosJ+Ti0uQSTSQV3/QhDM/kTRR4Ev2V3KtE9SqUMvaUNnApvxNWpCMDNxmxySgLmBY7DmND9yYmLKMkprta2vqSZbXVk7RsGROKpT0ZI7pPjL5kgnaqoyRGdg4QmKpHt6vo6zeDw2a5VGxeVCOY6EVCQjCOhSzaR16Xg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khxElySUEluQqP2D7CPByFXt4UOhs898e51DK38tqSTM/Pcuj9yMKBQBhsHHzy0OfmX/3mecebOq5UYrH4ZZ9qXyD7YofDPBd9wPMSEEtuQNjGx4KWHZh9qJ6iAruJBWV57fGiLFi2Y+d+/CZnMAmuRxZhLiumud1zrgKsFSo8qj7mMhcekRAC5B3iVoP9YS9M0ruF3Ky+HN23kor1vANioQ8UiaaL+9LpEYoZRtWLpJCdRKlUdJ7jkZuVcWFQz1+Mp2ieAZpzoP35TvTBlvzHWWplNVVYjiqJLNLQ3i2DR4ZW6etyAPXBOH61MvwtiYfMXFtRVNIQYeiosGI3McYA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=amd.com;
  • Cc: dongli.zhang@xxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, tientzu@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Sat, 17 Apr 2021 16:39:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

> Hi Konrad,
>
> this series contains a bunch of swiotlb cleanups, mostly to reduce the
> amount of internals exposed to code outside of swiotlb.c, which should
> helper to prepare for supporting multiple different bounce buffer pools.

Somewhere between the 1st and 2nd patch, specifying a specific swiotlb
for an SEV guest is no longer honored. For example, if I start an SEV
guest with 16GB of memory and specify swiotlb=131072 I used to get a
256MB SWIOTLB. However, after the 2nd patch, the swiotlb=131072 is no
longer honored and I get a 982MB SWIOTLB (as set via sev_setup_arch() in
arch/x86/mm/mem_encrypt.c).

I can't be sure which patch caused the issue since an SEV guest fails to
boot with the 1st patch but can boot with the 2nd patch, at which point
the SWIOTLB comes in at 982MB (I haven't had a chance to debug it and so
I'm hoping you might be able to quickly spot what's going on).

Thanks,
Tom

>
> Changes since v2:
>  - fix a bisetion hazard that did not allocate the alloc_size array
>  - dropped all patches already merged
>
> Changes since v1:
>  - rebased to v5.12-rc1
>  - a few more cleanups
>  - merge and forward port the patch from Claire to move all the global
>    variables into a struct to prepare for multiple instances




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.