[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/pci: Refactor PCI MSI interrupts related code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 20 Apr 2021 13:45:34 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4gkbQyUEzbcZmHe+RLjkljIj++4qE78MdNjIBqI2Ac=; b=C/XxCXFizDG80Std9J7yBsacmjRg4V7Bnf3+l5SYwIZK+2eANXev+MYgmAJ8W3OwDU6oAa3WIQtYphTC1Yxu1lZoAyRdQ81H8fIpXoGZL+HsNZjDfyFnp32cN66atqQMmnWgGdKEC/Dt0+ui48qPjDHtg1jnOW9yvxq9tBFYm3UQv3wVK5Nh72M8RIHt4q2F8/bCycsPbraFZd1L0XLlLZPEftO8mdD2fMJWpSEpvoe7J9zvggKrZo3LmOblzeyLhE184Cn3pzrh4cFQpEWe7CNWpbHW6g3qWh0Rlx3zfevhYYB6fDJgs7/Dw+7ouVb50xrbtb7USHMo+m5VYDWEhA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlR0kPeZvXQdU+0mr4ZeJVmlp3rUy2Sqtta6dEUzx6lMzonJl0PkcJxruwibCyxWC98TfrSlqqvYP3dwFT/g+oYnVhHNB/FO6Qu6vQ+Wuwpo5gnJc8n9ujo686RZph7VFmPmDNjU1Z1sNZ3s6igp8+kHrdzjQ6TohBQ3XgLbRu2fjbCuIs/1NAywyGBdUH0roHQNLRoRG4FjGPSTLnQvMGEKhM3FZUU/hkPHx7IlHXrqFUCe6ekWsT12eyiZf0RYB562vWj1nUhNYsjTTv5FMbVERl5C9XTO/Gi8DfIFajUE09a2ZHi5XSDE7kq2jZwP5C5OB/0Iv9yDgMyMFUMrPw==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 20 Apr 2021 13:45:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXLVmJnBz/2T+xZEqfD4R39q2wV6qwuDwAgAH9VwCAAPmtgIAADD+AgAHfkACAAAF1gIAF4LkAgAAXZQCAACuvgIAACpEAgAAKwACAAaaJgA==
- Thread-topic: [PATCH v2] xen/pci: Refactor PCI MSI interrupts related code
Hi Jan
> On 19 Apr 2021, at 1:33 pm, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.04.2021 13:54, Julien Grall wrote:
>> For the time being, I think move this code in x86 is a lot better than
>> #ifdef or keep the code in common code.
>
> Well, I would perhaps agree if it ended up being #ifdef CONFIG_X86.
> I would perhaps not agree if there was a new CONFIG_* which other
> (future) arch-es could select if desired.
I agree with Julien moving the code to x86 file as currently it is referenced
only in x86 code
and as of now we are not sure how other architecture will implement the
Interrupt remapping
(via IOMMU or any other means).
Let me know if you are ok with moving the code to x86.
Regards,
Rahul
>
> Jan
|
