[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xenstored: Remove unused prototype


  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 20 Apr 2021 15:27:07 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMgFSJ2DbdCGak6qozq9V8IEU5NJKAZ9i+DXMNUhZnA=; b=NGTgmbXWmXdQ3ktoVKfmBB0FH/KssGKW6czb03+F+yH5XRb/A8dCjgGhdvEMLA+O/Zgx1Be/RevCMluEqY0nsfwOPMgNqxdkVWH91sNh1MljoKu2wdb6ELDTNPGwGLAVCYVpmbwopTmNXCmqehHDUHm4Oy6pbAL7gCbjjgZK9Hh0Ie/xOytNvUwf0pjeIUo0JhuUxIPnDm5r28qonf+EOt9Ks4U868BCc4AVkhufRYm19HljApf5RCTrVdvi+mQXC4MmiRpBeYSyn0S6A9orxIYshPoA8kIvtr4C+Zmkwk63Bm2ZhYr4Oz1BTjiuUr7b3EI0d/zmfviYxPRYwj6xDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNV68cRRszVIv/SryDNNNAVzTL3H0ZnNP6vEkyJLkOSHUUX55YV+8lEGdBaObMta724g4JMsB8lbv+TYjGyRtaWbJD4q7TfKlS4LiufZTXCxmEW8sHWbbbKuF87MJQGxmuhEvjr8Ay3gZ1+XLIXfT8CrHcg3DwaNZpIeQmbapaz3H+/e/JCR8Y1JYxNpdDHBmXqotS0VQAomxP8Dr/2HqXxcQ/Xc10dM5Jm0uNcKC4DixMwWXhvFwUS/wVZkEe2Hy6csTVIkFOlDybZOVxMm9S3RQW5Nyc8B24wO711HC3oYtDlDin7xGd+xXvLwmbKno4dGubSSVoMYtaL6zNEcQQ==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 20 Apr 2021 15:27:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXNev79FvKKrAJ70+ijDo5F6dptaq9h2UA
  • Thread-topic: [PATCH] tools/xenstored: Remove unused prototype

Hi Julien,

On 20 Apr 2021, at 14:49, Julien Grall <julien@xxxxxxx> wrote:

From: Julien Grall <jgrall@xxxxxxxxxx>

A prototype for dump_conn() has been present for quite a long time
but there are no implementation. Even, AFAICT in the patch that
introduced it. So drop it.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Agree, no implementation of this exists so:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

---
tools/xenstore/xenstored_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index d54a6042a9f7..591b28e4552f 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2085,7 +2085,6 @@ static struct option options[] = {
#endif
{ NULL, 0, NULL, 0 } };

-extern void dump_conn(struct connection *conn);
int dom0_domid = 0;
int dom0_event = 0;
int priv_domid = 0;
--
2.17.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.