[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: centralize / unify asm-offsets generation


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 20 Apr 2021 18:20:26 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zTNew35HM0SBbU/IeSL5QNmXpeBjH9cogBjo6SbWW0I=; b=RSaR26sQkJ8XeOzGfr1nhPRBf9Nsciv0dIPW+qYjUUHgoJMnHAPhme38WkgPFXMoNGtsxbXByb3jJAJazfLApeFOStp06tiHH4V82gxTtzu3sX9WTcN0I/07UiPbSTHGZ1NCuwGXFNGvSv3i2zfKPHZm0uf6uwiYif0Xvt1pcVbz0tfkU6+TOHtrXDzlz7ohIcsSTHPbMILzeLQi3u991pOz90nE8DZ4m4uJvuf9K68/gbfHzqis3snn0y+1OAvxyCSatiehSSaNxq8rRkAF8YJ2X6NKbpChe/DMzAeNXpq2PlcO0ULZXfwhkseBGHoW/h7VnJA70b4T679Xsrn4NA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzB272LokCoySgp+t5CJgtg8pWmgSFRi8h/NKbEO/nvT7vYSl7FMgOs5XX/ctkMhJavzh3hQyPv2VQ95x8fuHfxUuXLocZkR+9dnhA9TzlEZrfSdAYLa28RuOFNK1Za42ybpZvX50NtwKU99k2qUFRJLOge9KJuOkRySZkfZ3WZ3ueDBx+mCP1cv2/Xz9Dw3B9CrutWj+2xhjpg3HaCog/pxKlJz0VmcrYSEBtarlEVvTVIR4F38BN6iQX8ikp7yH5pHknnp8/RKXpwor5N+TwkdNZFEZGOSOdySADo9ZpTZcpDeA5k/NADe+ep0dygTxhTlmj+1uZU/vH8+bAAFJg==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 20 Apr 2021 16:20:42 +0000
  • Ironport-hdrordr: A9a23:dhNyaK24BNYiO86hnQP9VwqjBQd0eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFnNJ1/Z xLN5JzANiYNzNHpO7x6gWgDpIEyN6I7KiniY7lvg5QZCttbLxt6Bo8Lw6dHFF/SgUuP+tAKL O34M1bqz28PUkGd8jTPAhLY8Hvr8DG/aiWBCIuKAUg7GC14w+AyLm/KBSA2wdbbjUn+8ZFzU HgsyjUopquqOu6zBi07R6c071zlMH6wtVOQOyg4/JlTgnEsQqjaIR/V7DqhllczI6SwW0nn9 XWrxArM94b0QK3QkiOvRDv1wP8uQxP11beyESViXamgcv1SCNSMbsiuatlcwDU40dlgddk0K gj5RP7i7NrC3r7/RjV1pztbVVHh0C0qX0tnao4lHpES7IEZLtQt4AEuGtIDZYpBkvBmdoaOd grKPuZyOddcFucYXyclHJo2saURXg2Hg2LWAwrptGV9zRdnXh/z1EdrfZvw0soxdYYcd1p9u 7EOqNnmPVlVckNd5tnCOMAW8esTkTQXBP3Nn6IK1iPLtBaB1v977rMpJkl7uCjf5IFiLEono 7aaUhVsW4pd1irIueltac7oizlcSGYZ3DA28te7592tvnXX7zwKxSZRFQvice759QeGNDcQO bbAuMBP9bTaU/VXapZ1Qz3XJdfbVMEVtcOg802X1KVrtiOEYHhtvXafPHPYIO3VQs1Q2+XOA orYBHDYOF7qmy7UH7xhxbcH1n3fFbkxIl9FKjB8/JW8qIpX7c87DQ9uBCc3IWmODdCuqs5cA 9VO7X8iJqhqW2352rTq1hzMh1GF0BP/Yj6W3xEpQU2I1r5GIxz5Om3SCR35j+qNxV/R8TZHE p0vFJs45utI5iR3yw5T9qhL2KBlnMW4GiBR5AXnKqf6db5E6lIWqoOaehUL0HmBhZ1kQFlpC NocwkfXHbFGjfvk6m+yJQJGefRccJjiBynLcM8kwOLiWys4eUUAlcLVT+nVsCaxSw0QSBPv0 Z8968EjKDFnTq0M2MwjP4/LEZHZA2sceN7JTXAQL8RtqHgeQl2Q2vPryedkQsLYWbv918fnC jmNi2befbCB1BZunxez6by+F54bWmGZStLGyNHmLw4MV6Dlmd40OeNaKb2+XCWcEE62e0YMC vIe38KOQVly8qs2BPQkybHFnM73ZInO+zbAt0YAubu80LoDLfNubANHvdS8pogHsvpqPUzSu 6aexWYNnfkEOsvwRWSvWs5IyF6p3kvjOPw1HTenTqF9U96JcCXDEVtRrkdLd3ZxXPjXey03J Jwis9wlfesM03qA+T2ip3/XnpmEFf+sGS2R+YnpdR/pqQproZ+GJHdTH/hyGxH5hMjN835/X luAphT0fTkAMtCbsYScyVW8h4Cj9KUNnYmtQTwH6sYcUwyiWTYe/eE+aDBp7ZqIkDpnnq0BX Cvtwlmu9vVVSqK0rAXT4gqJ35NVUQ64HN+uOyYcYndDxiravFD8FK2PmTVSs4bdIG1XZEr6j pq6dCBmOGaMwDi3hrLgDd9KqVSt2arKPnCRj6kKKptyZiXKF6Miqyl7IqYlzHsUwa2bEwemM lAfUwUZcJTlyk6gOQMo3GPY52yhnhgv0pV4DlhmFKo8JOh+n3nEUZPNhCchI5XUzlVOn2Blt /E7uCcyXT47FF+qN3+PXYVWusLN8kbT4DxISsrA9MXpqSU860mhTkGfA0jFHcmiDf23/pv2L Cw3Pm6YZy7NV7YfXY6vRJVDI99mSIm7U5HaNa39p+8ZQszEOgQasFPp7x+oXZMkBze/lccZx JiukgUzYnLNEXgJGk5P7Pph5HKjB8Ro7Wi51ViqG5LoE6ujEiRtjHO7p2Ikktxi1eYjwd87Y 2BWTM6gU9ix3Va6J0kFkDIbEnBbjeuNkjtwK4hJHt/YFpfsdkDvV7kNKcCkZCsx3dlqzMbDi A8z6qwL33SUzmICtH8RQraPOidMZpVePZeOm0KMnisEg/L865ADi7gcMt91xmqh3cFDbWPPK Tjew6GEJwR5sUrStLRaoOanIPWzQ5V63sOxriL9ECtkfdyqdiWLgRgsdQ7GpIZRTuC8SJgls SeRhjOOY9/2lCok0XxrStfP9MY2AIT3A0TojoRAjqhA5epSlhmvyNu8e6leAQIjcONDc9Pt2 3Mu0SstRDtRXWpGVjpX70G+HQy8gndBIrcolihYrL0Xiois82EAOO8lSDg0RXdqMjEhD7Ctg l12WcZQRku0Q+aUJAQDHjRpnpqeSZEB1dpkAC43LAa7WYijUg4ciYJTM1G5T73E3nnflrZrS WVISE1+5AMUmdzi+QMt31Uglg6kFtRSbhnjJ2ApFqka28sdHcB+/MGzw+V0MAtXXV3PEH8dP D5v9WmOMym1JZXFTL01IRMENRpLiBUzb7F7ujWTixOKxmC1bBI1BzQ51Uy6UMgl8JNjjCVvK LIOjzopLlnua4OWfWr2mQ9TvNFdMJ/qHLLCsxa7b4gj1//6c+Y2y9HXNbEnDBYRSKwF9hFc1 UraH3XgfRs18qFujubfZJkvaSu61RzVd/GcXIluZnvJnND6LgtyNrcZI7SLiXYwfM/fNUyx1 PA9wAi0GLiloXwFpGlPxK4hDidSnU7CIwnJj0FJsjLAJ4j4ewtggc18pgWAChVxfRkaieGqp 4QozDxwIlEyLtd0X1kZA==
  • Ironport-sdr: YBtJB7CD9b9hU6cOqjo5Mn4jqLDWhksxSfJuBmj4qFXKgTQsFxe++7JcfFCpPNU7ReZtcN0vx4 dKqPFaw9+LQkwoftMKJhw3A0AstTg29Hx9ttfUOV+5Xi+Zrnjcm0ktia0Dj0sQNvXxEl9+8tmI dpJ/LDFs1yJi/x6MuZeKYM5QdtATsa+Lq/FJZL1gr9X8wJLCiuHWGoKUfC95m1SWWDq6MviDV6 irJA8Y6Zn7+gJrLZeBPdz8yDOZuQ1V/E1aRL8Vbgn/ThrxCqkpVDP+M5AQC8AXwGwPuTi5vJhp +nw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Apr 20, 2021 at 05:47:49PM +0200, Jan Beulich wrote:
> On 20.04.2021 17:29, Roger Pau Monné wrote:
> > On Thu, Apr 01, 2021 at 10:33:47AM +0200, Jan Beulich wrote:
> >> @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi
> >>    @sed -rf tools/process-banner.sed < .banner >> $@.new
> >>    @mv -f $@.new $@
> >>  
> >> -include/asm-$(TARGET_ARCH)/asm-offsets.h: 
> >> arch/$(TARGET_ARCH)/asm-offsets.s
> >> +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c
> >> +  $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ 
> >> $@ $<
> >> +  $(call move-if-changed,$@.new,$@)
> > 
> > Won't it be more natural to keep the .s file in arch/$(TARGET_ARCH)?
> 
> Yes and no: Yes as far as the actual file location is concerned.
> No when considering where it gets generated: I generally consider
> it risky to generate files outside of the directory where make
> currently runs. There may be good reasons for certain exceptions,
> but personally I don't see this case as good enough a reason.
> 
> Somewhat related - if doing as you suggest, which Makefile's
> clean: rule should clean up that file in your opinion?

The clean rule should be in the makefile where it's generated IMO,
same as asm-offsets.h clean rule currently in xen/Makefile.

> Nevertheless, if there's general agreement that keeping the file
> there is better, I'd make the change and simply ignore my unhappy
> feelings about it.

I don't have a strong opinion, it just feels weird to have this IMO
stray asm-offsets.s outside of it's arch directory, taking into
account that we have asm-offsets.h generated from xen/Makefile into an
arch specific directory already as a precedent in that makefile.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.