[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] x86/EFI: program headers are an ELF concept


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 21 Apr 2021 11:11:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3DenC8vmwyz1IQMTPf6FIHDgZliHlVZISltA+ohrSrA=; b=Y9ug+pOGCWiNA2MY1ViAcms1EqSwcmKGhaG7KYq4H9rAiv8/6Xn1UjucVhEZ2O68nhAOc4RGIh21pilZwfSjoB18KFEkKmZeerm1v3gE9ePV00Wv/0yNL3SEVmf5+aLj1K47hvqxp7rA9z4DfcPhkMcE+AtekF0dPdzrzQmxQIfjcqX9Iz+23STEvcLveTRC+//UByfKsOUSULZyBkbo+KIRw6WraY1sakXtNQc87l6DuDeoeND0y603FWRTB+a8KuP1EAtu6m1NAAdyt7TAkynclwIzk6j9/fBJI6xesCH5JBNpleiQ4exsy0IXRtCTPtDZltmYKUhalDOjWFNAlg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPauvDpoRyHGZGNVlSdxlKDto9MLtgxKI5ksvIwfzyFI+7hB+AAatm8LRI+RkPXe8/ZsYMODOoElt8s3ZCYhubGXFT8MXiP5KzkTbr+RaBbxIXty5/y0PZ+JuNVwqAIXnMn6WEYkUUVCGq8Wy15j/xzHWuxSLaO9KUfzEa005Eu3UZsYfy71OxNo1cGHOXW3/5vCImSLX+AeJiPlfplj6Lqn418PXlQoV+8YwuQ7u04h5xnQXUZrfcJGJUrfo1TEObtZOYTWEaON3eL5t8/VTjaWSfqK5IePzSsv8wL6lyA1pLNDi2B2eoHthmkXao1j120mD58zfOiufWh5Djvd1w==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 21 Apr 2021 09:11:33 +0000
  • Ironport-hdrordr: A9a23:z1DLxKmV1tE9Tlh6Mb8ry4DhJC7pDfO9j2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW57LLA+E4 eR4dcCijq7YHIMbtm6AH5tZZm4m/TgkpX6bRkaQyM28QXmt0LS1JfWMTi9mi0fXTRG3Ks4/Q H+/TDRy62/v5iAu33h/kDJ6ZA+oqqF9vJiA4i2htEROnHQjG+TFflccpmjmBxwn+218lYtl7 D30mYdFuB+8WnYcG3wgTaF4XiY7B8U53XvyUCVjBLYyKSTLlJKaLszuatjfhTU8EYmtt1nuZ g7p16xjJZLEQjG2B30+tmgbWAVqmOPvXEgneQP5kYvN7c2Vbk5l/16wGplVL0EHC789bk9Fv hvAMz29J9tACynRkGckW91zNO2WHMvWj+AX0gZo8SQlwNbhXZj0iIjtYEit0ZF0Kh4Z4hP5u zCPKgtvLZSTvUOZaY4IOsaW8O4BkHEXBqkChPfHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8bYSvVeIyz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykvGnv+4UDqTgKr iOEaMTJ8WmAXrlGI5P0QG7cYJVM2MiXMocvct+dEmJpu7NN432ps3WePveP9PWYHUZc1K6Jk FGcCn4Jc1G4EzucGT/mgLtV3TkfVG63Z8YKtmZw8EjjKw2cqFcuAkcjlq0ouuRLydZj6AwdE xiZJfukqaxo3iK7X/Fhl8ZfyZ1PwJw2vHNQnlKrQgFPwffarAYoeiSfmhUwT+hKgJgSdjVVC pSvU5+967yD5H4/1FsN/uXdkahy1cDrnODSJkR3oeZ493+R58+BpE6HIprFQvKEBRxsR1wqH hKbTIFQkO3LEKvtYyVyLgvQM3Pfdh1hwmmZeROr2jEiEmarcYzAkcAUyWWSs6RiwY2Tz9yjl l8mpVvxIaoqHKKEy8Ske44OFpDZCCyDKhdBAqIXolSh4vmYRp9V2uMmDychSwiY2aCzTRjuk XRaQmvPd3bCFtUvX5Vlpzn9155bU2xVUN9YHISi/w0KU32/lJIlcObbKu61GWcLmYYyuYGKT fffH85OQV13e260xaThRePHXgr3Y8VI+TYFbgvGoujnU+FGcmtr+UrDvVU9JFqOJTSqecNS/ uYYBLQAzXiCe8lsjbl0UoNCW1Rkj0Dnvzp0hG+szT98347HPbIIFNpA5scOMqR6mD4R/COlL V15OhFyNeYAyHUUJqhz6qSUhtobjX0ikSyR/szqZ9Vsbkp3YEDVqXzYH/t7jV/wB46LM3Ij0 sQT6Rw3aDZNuZUDr4vUhMc2mBsqc+GI0QquDHnG+MSfVkiiHnAItOCioC43YYHMwmkpAHqP0 OY/DAY1/DZXzGb3bpyMdN6HU1mLGw94m9l5uWMasn5DxirbfhK+B6fPmWmeLFQDIiDFrN4lG cx3/i428uWfTH/wgbeoH9SJb9P6X+uRYeKOz23cNQ4heCSCBCrmaul4Mm6kTfxR3+aUi0j9P F4XH1VSN9ChDkkhJAwyQ6oRMXM0wQYr2c=
  • Ironport-sdr: bNx6acyhtKistrICTYJawBDDbyO2UL2dudq6H0zXkBEthXJ9SpI4xAA09kTo52MzG008JEjPwX LBDKDu2GYGxRmoIN4pFZAqrH1JQsx60lkLBKyqW5ZyOFCrEEqyL9HcuNTi0FnVDxzMyq9EPRSs 79kgVzSuMHEloUhzsED/wCjRRUaqQZR1TnJ+wjAk735WKobRXD5XNMX7CQX0PrSUBgASTIWAo0 lJqrz1rwquwYwbR1hUQhyN0wWlqCRNtMvFQA4Iw4bbUYAwO240CknVWZQWevna9XvAfailX1bo 02k=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Apr 01, 2021 at 11:45:09AM +0200, Jan Beulich wrote:
> While they apparently do no harm when building xen.efi, their use is
> potentially misleading. Conditionalize their use to be for just the ELF
> binary we produce.
> 
> No change to the resulting binaries.

The GNU Linker manual notes that program headers would be ignored when
not generating an ELF file, so I'm not sure it's worth us adding more
churn to the linker script to hide something that's already ignored by
ld already.

Maybe adding a comment noting program headers are ignored when not
generating an ELF output would be enough?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.