[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] x86/EFI: avoid use of GNU ld's --disable-reloc-section when possible
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 21 Apr 2021 17:20:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rnL1wrRC8Xlighg0QkObbiRpbkamEWJFLiMZEFD/Mc=; b=cDoDiKWMMQfxsDwSPtF0qsGOzm8Zm7cHj49HTx/f9XaNs8eM3Dyd4VXxH7JTxabp1Bd9C0YwEMbD89l1M/StSX9hhCgRlBmxTutTScMZInE8c1Tpz0dFwowv/X9EVQVO4k9fsJ7Ll2t3Kgn9CSGAd6KBUurDA/aPOqDAWbVAHFs1vxJM753KxXedAPxrb902qIu4YdtJf2wlcQWcA7y/pxEHDnzgVYg+TDfkjDk5A5Hsxzft5iTF3MXkUZ7+KBEWj6oz/vneUHgwTRLezKIqbd1cyqTtibqsDFqAaMqu+kSRVw/Cx9adKwpAWWLx2D9aKImCTpxbHkFIbvajCpu7wA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX10/zcYKt8WFP/HsftGNsyucT9ajDUVHwj5c4LrjG8ABX8JdRU5wDb/abNDR7KqVzGvhj0KjMbBWPbVAxYSdGLEorByk7cX6aqttsBGNCUJAXq/wJR1J7ovB5i4wDe8N9DLb/xZE3KpSGN3tlW+6AmPnVeLSDtgDflyyJ8GLxHv3p9IQlbxFla0TW7sGcnmEJAywBpG966sRi0YK29clh61W2PetLke9gi4RdY7C00/rvKil7Qmm7pQ8JEWIjoQ7MZmPwAySCJyND/pUFNlACwmB9v+731i1WfCW+OWfm5B5DkZtAqtw44rLj51P+Y+lfvDrS2qawMtOSFQK8gbIA==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 21 Apr 2021 15:21:13 +0000
- Ironport-hdrordr: A9a23:30HECqkPbtAYK0UpNMyQTgjjG7bpDfOcj2dD5ilNYBxZY6Wkvu iUtrAyyQL0hDENWHsphNCHP+26TWnB8INuiLN/AZ6LZyOjnGezNolt4c/ZwzPmEzDj7eI178 tdWoBEIpnLAVB+5PyW3CCRD8sgzN6b8KqhmOfZyDNXQRt3brx7hj0ZNi+wOCRNNW57LLA+E4 eR4dcCijq7YHIMbtm6AH5tZZm4m/TgkpX6bRkaQyM94A6Vgj+yrJL8GR6U3hAROgk/vIsK22 7DjgD/++Gfo+i2oyWsrFP7wrZ3vJ/aytVFDNGRkcR9EFvRoyuheYgJYczhgBkbu+eqgWxa9e XkgxBlBMhr7mOUQ2fdm2qQ5yDF8BIDr0Dv0kWZh3yLm72IeBsfB9BajYxUNjv1gnBQxe1U66 5A02KHu5c/N3qp906clru4JS1CrUa6rWEvluQelRVkIPMjQYRcsJAF+wdtGIoAdRiKmbwPKv VkD83X+Z9tADWnRk3e11MfpOCEbzAYGxeLRVU6ocqF0zRat2AR9Tpn+OUv2lgH754zUJ9C+q DtNblpjqhHSossYbt6H/ppe7r6NkX9BTb3dE6CK1XuE68Kf1rLtp7M+b0woMWnYoYBwpcekI nIOWko+lIaSgbLM4mjzZdL+hfCTCGWRjL20PxT4JB/p/nVWKfrGTfrciFvr+KQ59EkRuHLUf e6P5xbR9X5K3H1JIpP1wriH7FPNHglVtEPsNpTYSPOnuv7bqnR8sDLevfaI7TgVRw+XHnkP3 cFVD/vYOpa6ESGXWL5nQjxV3vhdleXx+MzLIHqu8wojKQdPIxFtQYYzX6j4NuQFDFEuqsqOG tySYmX15+TlC2TxyLl/m9pMh1SAgJ++7P7SU5HogcMLgfRebYHsNOPRHBK0BK8V1tCZvKTND Qai0V8+KqxIZDV7zslEcibPmWTiGZWg36WUZEGmOmm6d3+cp01SrYqMZYBWznjJlhQo0JHuW 1DYAgLSgv0DTX1k5ioi5QSGaX4bNlzgACiJOZOsnLBvUCgpcUiL0FrHAKGYIqyu0IDVjBUjl p+/+s0m7ybgwuiLmM5naAFKlFWUX+WB7hHFQyBQ41RltnQCUZNZFbPoQbfpwA4e2Ls+UlXom D6NyWbdcvGBUdntmlC3rzn9051cWuhb1t9A0oKwrFVJCDjgDJewOWLbq283y+qZlwOzvo0HR vFbTERSzkejOyf5VqwonKvBH8mzpIhMqjhF7wlaajUwW7oApaPj7s6E/hd+4tFONjivvQQa/ +WfxaYIVrDeqUU8j3QgkxgFDh/qXEin/+t5Qbs63Kg2mUjRdXVO1ZrStggUqehxlmhY8zN9p p3jdg457Ttdkrwb8OL0qHRYXpoLAjJrWu/UuEvrtR1sMsJxc9ONqiedQGN8ndNmCgaBoPTsm g1Raxg+rDPOoN1ZaUpCmpk12tssO7KFVchtwz9P/Q3cl4shULKJt/h2cu8lZMfRmm64DbqMV aR8ydh7+7IciuK27kdEb8xKw1tGT8BwUUn2OOJbIvLDgq2M8lF4VqhK3e4GYUtApStKPE1rh xg5cuPkPLSXy3k2BrItT8+Bq5V6W6oTYeTBw2LcNQ4vuCSCBCpgqGw5tS0gyqyYTyna14AjY kATHcuVK14+3Afpbxy9DOzRKzxql8klFUbwQgPrC+T5qGWpEHBHU9HNgXFhI5xRjc7CAnQsf j4
- Ironport-sdr: CeNDIFiZ0k8xynsqjzHhQZ5xaVVOUMMLnxKahszUHRgj7GDNfbppHOnrSHm2JX+VykC2UMVUZ9 IHNZ8ooiyIx79+v8UBRw8wr5gm3kB1rgGBQTAFVrWuL88DPSU9dRblqkcuAflb6jxQ59qnSbuI 2iwct1Vl0+gyNZwhEsfh1b9TCc6iTTVBzUR8G2oPheSgI52/ZbXlPEsPfVQCS+aQEaZYd8wX2P FdL1R0uF4q7GBC+BXY+1fko7dvtBRAN4uIpM1lc7z0rDn+gfju7OKdDdxotZAnI1Otda09RKOE rNw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 21, 2021 at 02:03:49PM +0200, Jan Beulich wrote:
> On 21.04.2021 12:21, Roger Pau Monné wrote:
> > On Thu, Apr 01, 2021 at 11:46:44AM +0200, Jan Beulich wrote:
> >> @@ -189,7 +208,11 @@ EFI_LDFLAGS += --no-insert-timestamp
> >> endif
> >>
> >> $(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n
> >> 's, A VIRT_START$$,,p')
> >> +ifeq ($(MKRELOC),:)
> >> +$(TARGET).efi: ALT_BASE :=
> >> +else
> >> $(TARGET).efi: ALT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's,
> >> A ALT_START$$,,p')
> >
> > Could you maybe check whether $(relocs-dummy) is set as the condition
> > here and use it here instead of efi/relocs-dummy.o?
>
> I can use it in the ifeq() if you think that's neater (the current way
> is minimally shorter), but using it in the ALT_BASE assignment would
> make this differ more from the VIRT_BASE one, which I'd like to avoid.
Sorry, I think I'm slightly confused because when the linker can
produce the required relocations relocs-dummy variable is left empty,
so it won't be added to $(TARGET).efi.
But we still need to generate the efi/relocs-dummy.o file for the ELF
build I assume?
Thanks, Roger.
|
