[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/oprofile: remove compat accessors usage from backtrace
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 23 Apr 2021 13:51:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Le3wG6gtk9U+b2oT7Z1lfVxhrgWRrGoAU6EmW7bflM=; b=Tin7VjeOw/5C5EaIoskgkzV5ytZ0Vy84BzwNH1L1yHAKVeW6Atl20gHi+k9QswCLtfp/apKCPGxYhbLJpZseA/e1hA9/fwg5M6LYfEyP33AAXGjTn0sSM6tj3rdlItuMPK9Xkh0spVO++t9YtaC8sPT4v49IVFxm6nMKP4r2C+5miyuYS1goZOA6ZEAz9EEnsnbHow/kNJnzUkkW4SFjkGhqPAody7pZyI/zMBacLIjN/379q+5xVBvAP9LE/PY0pjABSyohvCFF0P37fMElkjQgRz0ng0f6Dv3CRdJxnk+39z4PFJi27NBxM0u9duko9CWpvm9rj4e+Lmz6aOffKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+PzE2+N7O/eWzyso6PVUIxH512rifcJ5Ywac7HlUH9yJ805++JyPwRK+Jn8X1iKQo3TW/gSuXtdjP3TC7T+pXxUAn++nFB3WHz0b8gGcPxG96rVgzr3cPLGculDB/ljt5c0DPUB9maZilUTQXGQX/vrMsx/dNiFD0CWgGnVyRK/UOOlyHuwP6+KW51CDmsCL27zmPcP8qR+xl5G8y1HjjOlIj5k8a93qGcpcoj31YC486A2WyVL9v65kqOTjaEQbyES1I9le4kmvzbwc8UUUXGHjBKeqoWSoenvracCvr008rXJL1REMOMVyBF6Q9JBwTymUp6QV6znOxDud3SSyQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 23 Apr 2021 12:52:00 +0000
- Ironport-hdrordr: A9a23:g3SPianGA9JvbsYjDJOIjcyoUBPpDfP+imdD5ilNYBxZY6Wkvu izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKMaVI3DYCDNvmy0IIZ+qbbz2jGIIVybysdx94 dFN5J/Btr5EERgga/BijWQPt48zLC8n5yAqvzZyx5WIz1CT4FFw0NHBh2AEktwLTM2YKYRMJ aH/MJIq36BVB0sH6eGL0IIVeTCuNHH/aiOCXI7LiUq9RWUineQ4KP6eiLy4j4lTzhNzb0+mF K18TDR26PLiZCG4y6Z7UD/xdB8mNztytxMbfb89/Q9G3HXpSuDIKhkU72GljgprO+o80ZCqq ixnz4Qe/5dxlmUUmapoQb8+wSI6kdQ11bSjWW2rFGmgcvlSCk0A8BM7LgpDCfx2g4bk/xXlI dotljp0KZ/PFf7swnWo+XsbVVMkHG5pHIz+NRj9EB3YM8lR5J66bAE8Fg9KuZnIAvKrLoJPc NJF8/m6PNfYTqhHgrkl1gq+tCqU3gpdy32O3Qqi4iQ2zhSqnhz01EV8swZhmsB75IwUfB/lp z5Dpg=
- Ironport-sdr: Fj0nkkCQL4X7OgRRwCX1PSMusZAudidZqb/rSt1uR78rTGBHvyP3Wa86vkweac2AvDiGXQfcLh gCThzbz4EdH5haS6g197Vovlk/GsJ8MXuM+v4EBeoUWG1iU7N28ptYBAE3mzZz3t56NmF61tyJ blKz3jewDSAKn+RFcR4OCIQLo5YuktIAQ3pCKDOSfd+MyEZCycRzDIAzaHNDgd7hLRR33KuD3t +tkwrjft09vKU+JMS9n5MyCrvzHHNsADwbvRLXtnOsPOjPFH9l8dRCQvQZOwOy/RGJZqHzyI8l P+Q=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/04/2021 13:35, Roger Pau Monne wrote:
> Remove the unneeded usage of the compat layer to copy frame pointers
> from guest address space. Instead just use raw_copy_from_guest.
>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Just build tested. Note sure I'm missing something, since using the
> compat layer here was IMO much more complicated than just using the
> raw accessors.
Thankyou, and yes - I agree. The logic was unnecessarily complicated.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Needs a fixes tag, but can be sorted on commit.
|
