Re: [PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

[Julien Grall <julien@xxxxxxx>]

On 27/04/2021 14:57, Jan Beulich wrote:
> > diff --git a/docs/hypercall-interfaces/arm64/grant_tables.rst 
> > b/docs/hypercall-interfaces/arm64/grant_tables.rst
> > new file mode 100644
> > index 0000000000..8955ec5812
> > --- /dev/null
> > +++ b/docs/hypercall-interfaces/arm64/grant_tables.rst
> > @@ -0,0 +1,8 @@
> > +.. SPDX-License-Identifier: CC-BY-4.0
> > +
> > +Grant Tables
> > +============
> > +
> > +.. doxygengroup:: grant_table
> I continue to object to this giving the impression that grant tables
> are something Arm64 specific.
+1, grant tables is common interface so why do they need to be described 
per arch?
I haven't looked at the history of the patch, but if there was some 
rationale about this approach, then this ought to be written in the 
commit message or at least after (---).
Cheers,

--
Julien Grall