[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/oprofile: remove compat accessors usage from backtrace
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 27 Apr 2021 20:07:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0cD5Er0KujSlLLnnmEad21Ga6zZz6hn6HOhqtsSdkss=; b=VDazG8baqIaqIqJmhIJlCuikAWnF5vH6iigDDZUNYaRIx6LSTHKAs7B0de90U3w/ctmXIxx/xbAAbJv2X2g3VbU/M0BiCViHXYrGOhRyh2kTbXp7e607UDn8o/VeCRrjZkYPQpZppzNv0aGErIVH0urYYGLobczbGIF5qjCO3PZbgrwrC+PVRwHvXxd3VB43b+MNRZMy/uKhGrl67iQ/8X6Ygf6BNrwscQ6C0mcjLW57FYNWhS98irb/OISu3DI38kjRUYDmXpQMfqxW3g9ly9vrKI8BQV5pHYjnbyxIQNluLjaP5nQTVHdhriXmvH3kOAELNRQBOAUQuHNbpnbRGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acaaoUuxvNrx9DS8/CFx0l0l5E8sH/B03Hi5YtYo/tPi+4edVYTv2rkjERXk4Ook7peNO/5gDOQEkp6G/2Lxvx4uhMr5VSpWCj1YQcA+GBmi8k9c9nZQPbcwD80WG7wLDKpNnlJH1C2JLaybnjJC/EITC2SNsXh0JPIkZdV5Kxj3GhQOEG1tnaJBMklhgng66ZC8iUJqLV3h9waADifRXMO3OeLIoj3XifAn2vGdjIyzGUxjQeSEmHkXQ9jTbph/yDACLvHkxSPyO4znPG1i/9cvgAfs/93q/qZkvUKL5FMKffkKNzyhHmx73QXw3/hVuiqz3q7cAySnec6TwODzkA==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 27 Apr 2021 18:07:55 +0000
- Ironport-hdrordr: A9a23:QhXpCKhcdFRRDsSqLca9PBKljHBQX4t13DAbvn1ZSRFFG/Gwvc rGppsm/DXzjyscX2xls9WJIrPoewK6ybde544NMbC+GDT8sGyzI414qafkyTvsGyrxn9QtsJ tIWa54FdH2EBxGnd/3iTPIceoI7dGb/MmT5Nv24GxqSWhRBp1IzwNhDB2HGkp9SGB9dPwEPb 69wuYCmDa6Y3QQaa2Adxo4dszOvcfCmp6jQTNuPX4awTCUjTWy6KPreiLopys2aD9Ezbc8/W WtqWWQ2oyYr/q5xhXAvlW8071qmcDswtYGOcqUisJ9EF7RozuvDb4MZ5Sy+BQ8oOSi8z8R4b 3xiiZlG8R251X1UgiO0GPQ8hTgyzon5jvjzlKVkBLYy/DEeA==
- Ironport-sdr: /Pus4mt7meV4lbn1fyrJLKulIfF9BWGeRsjpqgpDYqTmtUO8ZaFVHBVTZzakHQUPotUP/SgeCz roxXxbN4mqHtHfi9Y7H9rBnBRntKznLRZcWIKr4IpV7xltsba7yTYbRJp3UtfTD7VUD/dPYetg p0tv92mw6bVBNK7NLTCg5JwADG1sLTrVac0hCNWICQgUQ6z9R2b0lhBo3ahpQOtO5W5ps8tz/r gwprRohR4kaJ6SALIfr+i2sGTDpsCIVYbnnRCbNsUUWElWhdHWL+KFkB3kfUCIMqWPbkfK/XrB BU4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 27, 2021 at 05:37:22PM +0200, Jan Beulich wrote:
> On 27.04.2021 16:21, Roger Pau Monne wrote:
> > Remove the unneeded usage of the compat layer to copy frame pointers
> > from guest address space. Instead just use raw_copy_from_guest.
> >
> > While there change the accessibility check of one frame_head beyond to
> > be performed as part of the copy, like it's done in the Linux code.
>
> Oh, one further question: I suppose you mean historic Linux here? I
> can't find anything like this anymore in current one. If so, I'm
> inclined to suggest "..., like used to be done in the Linux code."
> Or something substantially similar.
Oh, so my local copy of Linux seems to be circa 5.11, and AFAICT the
code was removed in 5.12. I can reword as: "..., like it's done in the
Linux code in 5.11 and earlier versions".
Thanks, Roger.
|
