[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Fix redefinition errors for toolstack libs
- To: Costin Lupu <costin.lupu@xxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Wed, 28 Apr 2021 12:34:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Le0gWx7wut1Zo5pYM1/cp2biusyQgv5NLEq99iXwqWU=; b=X7G651djLcO2DtDZdaAACWH0Hm5iw3VxT0v20jerT/jR9rV9vf93n3UUxJfpPEPWfYFh9Ddql7/AFPRmmYFMw9tYb5YuXbxrh0wQEEAH6mkOPvdRXPw400GzZX80HCw26ut/0BKKWlKO2paEl9bW0gzo/SybhWVRTQet+rJMXZGhoS+9GTc9NEe+BY2ooo5nlu4RMySOFqZ6BbZaJcTqeg2RcENILHmLurSoqC9GQbYvCdH4Y/eFvFX3qKEujVsRsenmb/jBRCYTCsFfH5LC0O7iALxvnIpzfvZPlqBI0hIs/61l6xKrs2jA5dAuPApLl7K9+XB0zJ8EuEy0b1Cepg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmCx9t94AonCMjKwhNnTODY3GV7HDcXu4nIiHvG/JZ+iqUuI/DlZlQfNqnTMHaBF/5hYRG1GQMACkwV5wGSi0LVYcLIB+KNBrdc0H+rdQ+8vATdj+mVIgiTTSQwNoaWXnTCsXYT816ytP1zepZ8DKl1bmrxww9xvn/3bCpfo/b4VTG65sC/yNK4FI2hxxf5mdUInpBqnNcDAe+2nBcO9akam5IEBNPMTI6QvR0mbwlsoAdry+OZzGcihNHjtu+EmyrViuePUAuFOXcLglPJhphHv5dhxAXbCdyNC/FVx8eqM9gaYr0T3VaEWkqSLf+d+vMY8NzPFxXht/eNL3iieyQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Scott <dave@xxxxxxxxxx>
- Delivery-date: Wed, 28 Apr 2021 12:34:30 +0000
- Ironport-hdrordr: A9a23:Ehfs4a+V6LWpUkZLJJRuk+EKdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnXnKQU3aA6O7C+UA76/Fa5NY0K1/qH/xTMOQ3bstRc26 BpbrRkBLTLZ2RSoM7m7GCDfOoI78KA9MmT69v261dIYUVUZ7p77wF/Yzzrd3FeYAVdH5I2GN 69y6N81lmdUE8aZMi6GXUJNtKrz7H2vanrfAIcAFof4BSO5AnC1JfBDxOa0h0COgk/o4sKzG 6tqW3Ez5Tmid6X4Fv212jf75NZ8eGRt+drNYi3peU+bhnpggasTox9V7OFpyBdmpDS1H8a1O Pijj1lE8Nv627AXmzdm2qT5yDQlAwAxlWn6ViEjWDtqcb0LQhKdfZptMZiXTbyr28D1esMt5 5j7iaimLd8SS7kpmDb4ePFUhl7/3DE2kYKoKoooFF0FbcFZKQ5l/14wGplVK0uMQjd844dHO xnHKjnlYxrWGLfVXzfs2V1qebcJ0gbL1ODSkgGjMSfzyJbqnB/11cZ38wShB47heoAd6U=
- Ironport-sdr: LpTO5jvh/cL4D74N4pAi36XdNrdFUbK7kp5Wre2KoLKx+li4XtlXIMwNpNbYhdiEisKZ8k7Tmy w/a40u25EaJZbRM6wzk1UrriAJB5rGiadAeeEq1PBwOUtwW5Eo92+dUXrtuJAQLOtrsdGHfCFA NSWKAadbh6yGNPn/pMVYvNJm06ulC/48lDXcghh+c5zz9sDq83djdS8RxGWCooJLE+v4TjHYUn DKnbf6H9mIWeYW1CsDjNBm7ThmcDPMz0S2nu9yiyz/k7zwoy6iv8vUgioWpIifyUDUOmuxjmZ+ zdA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXO12k0/hgjfv/3kiQm5n2yrTGaqrJ3uCA
- Thread-topic: [PATCH 0/5] Fix redefinition errors for toolstack libs
For replication I used gcc 10.3 on an Alpine system. In order to replicate the
redefinition error for PAGE_SIZE one should install the 'fortify-headers'
package which will change the chain of included headers by indirectly including
/usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined.
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error
tools/libfsimage: Fix PATH_MAX redefinition error
tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error
tools/libs/gnttab: Fix PAGE_SIZE redefinition error
tools/ocaml: Fix redefinition errors
tools/debugger/kdd/kdd-xen.c | 4 ++++
tools/debugger/kdd/kdd.c | 4 ++++
tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 ++
tools/libs/foreignmemory/private.h | 6 ++++--
tools/libs/gnttab/linux.c | 6 ++++++
tools/ocaml/libs/xc/xenctrl_stubs.c | 8 ++++++++
tools/ocaml/libs/xentoollog/xentoollog_stubs.c | 4 ++++
tools/ocaml/libs/xl/xenlight_stubs.c | 4 ++++
9 files changed, 38 insertions(+), 2 deletions(-)
—
2.20.1
For the OCaml bindings, this avoids redefinitions as you say. Looks good to me.
|
|
