Re: [PATCH v3 3/3] xen/pci: Refactor MSI code that implements MSI functionality within XEN

[Julien Grall <julien@xxxxxxx>]

On 28/04/2021 12:06, Roger Pau Monné wrote:
> On Mon, Apr 26, 2021 at 05:21:27PM +0100, Rahul Singh wrote:
> > MSI code that implements MSI functionality to support MSI within XEN is
> > not usable on ARM. Move the code under CONFIG_PCI_MSI_INTERCEPT flag to
> > gate the code for ARM.
> >
> > Currently, we have no idea how MSI functionality will be supported for
> > other architecture therefore we have decided to move the code under
> > CONFIG_PCI_MSI_INTERCEPT. We know this is not the right flag to gate the
> > code but to avoid an extra flag we decided to use this.
> >
> > No functional change intended.
> >
> > Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> I think this is fine, as we don't really want to add another Kconfig
> option (ie: CONFIG_PCI_MSI) for just the non explicitly intercept MSI
> code.
+1 This is code and therefore can be revisited once we have more data 
(e.g. a second arch that will re-use it).
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall