[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 21/21] libs/guest: (re)move xc_cpu_policy_apply_cpuid
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 28 Apr 2021 17:45:59 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 28 Apr 2021 16:46:32 +0000
- Ironport-hdrordr: A9a23:AUO3sauiKy02AJZc3YsYGOHp7skD6dV00zAX/kB9WHVpW+az/v rBoN0w0xjohDENHFwhg8mHIqmcQXXanKQFhbU5F7GkQQXgpS+UPJhvhLGSpgHINiXi+odmuJ tIXLN5DLTLYWRSrcG/2wWgFsZl/d/vytHOuc7771NACT5ncLth6QARMHf4LmRTSBNdDZQ0UL qwj/AmmxOadX4abtu2CxA+NoCpzeHjr57obQULABQq8mC1/FCVwYX3DgSC2VMmWy5PqI1Sl1 TtqRDz5amorpiAqyP06mm71ftrpOc=
- Ironport-sdr: YZNX38uhHeiNnrQ8TT4+aPPFs0zROO1tfRo6NVfMkZM6QA4K+X3CqgmFiTGh8qRQTrSwtjMM+l Pbqg+1oObi8rQoBjBlh4ml2ot7h3al+ZXafJsM8UlZfMNMQJdRcINAxR3nU6GJXOzPugMx9lX9 QQoVk64voLDrhrmuW5Ewhdwsva2dbkHnvyono70k1GgmYWcBmwkG/RGU23HPX/pPNCKfJDDbDt vFh1EBu8Rc4jcKUSecM1PotizR2CokbEs58vX5qX5f4fEJj1qZp0G+shwR1nGML2AB3ahc+DS3 fyI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 13, 2021 at 04:01:39PM +0200, Roger Pau Monne wrote:
> diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
> index cadc8b2a05e..6be2d773d1d 100644
> --- a/tools/libs/light/libxl_cpuid.c
> +++ b/tools/libs/light/libxl_cpuid.c
> @@ -419,6 +419,136 @@ int
> libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid,
> return 0;
> }
>
> +static int apply_cpuid(libxl_ctx *ctx, xc_cpu_policy_t policy,
I'm pretty sure we want `libxl__gc` here instead of `ctx`. `ctx` will
then by available via `CTX`. (and the GC_* macro will not need to be called)
Beside that, there is also the need to store libxc return values in 'r'
instead 'rc', and maybe use LOG*D macros to log the domid on error
messages.
Thanks,
--
Anthony PERARD
|
