[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/3] xen/pci: Refactor PCI MSI intercept related code


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Thu, 29 Apr 2021 08:27:14 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqafzmGHUxx2gy76AV37qLVoESIMB1wY4moj2vZiXqI=; b=jO5amxRqYdlPDRk3D//bJosyF8VDDcp4f26fT7SST8IEpd7C3d4W8YgntZ40Eq8hdifwcE74+TuDBL/EbUu0qjEOS6oqDuIO4celzYIviEfgj3lD1iYg/OCz3xsfbKguWj9iYgRQiVXjHPIkJhrLfvNvKZuJy0WWjdEkff8rOtmLO59ETA+CM4i1nJOr5V//enTZ/2+V73dRXl97ofFKjo7niFSkyGG0Bs/yZKqpZVad6uZVEyRGU5KRtO2EEn7KsLEhohv41qV6Vo+rmRPQUtqwn+GJBFn2FrwggraCaMy7tCwhnYm3wQy2UUi0E0zfnqygN/lXP8bwwBodVdvmnA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3axqdCOv/3VUTV5lmddNVwOdKAfZnnixLF7Y15F8/yzW4nLmAK1g5X31AZmbgrBQKNkcb48Q5AQ4IS4u0y9fWrsPRAd/qdv3cUr9fw/zAgDryvOqjxNJwTXL2iOVq6KPRKNe7YMKAgyuVTSPyRKwO+eOSt3GUsIHsZ1AWZEkVjH5PkzbSREkaMNGr9OnZX/jodAVauPJX1ZK761mhR0APD7G5x6PIvii4U9a3qX/+lS9RuSZi07Vl4nfjjuGNujRhGLh8C4DKED1YBibkmX3T8iTw9AyxcnaFdF5GHMfdUeSULmlL5o4YILR8Ig0DG0ahZXFvjIQRK1GkKmquJsuQ==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 29 Apr 2021 08:27:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXOrhr42FH3XtdSEulNtIMBWAh5arJwQ+AgAA2a4CAATX+gA==
  • Thread-topic: [PATCH v3 2/3] xen/pci: Refactor PCI MSI intercept related code

Hi Jan,

> On 28 Apr 2021, at 2:57 pm, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 28.04.2021 12:42, Roger Pau Monné wrote:
>> On Mon, Apr 26, 2021 at 05:21:26PM +0100, Rahul Singh wrote:
>>> --- a/xen/arch/x86/Kconfig
>>> +++ b/xen/arch/x86/Kconfig
>>> @@ -20,6 +20,7 @@ config X86
>>>     select HAS_NS16550
>>>     select HAS_PASSTHROUGH
>>>     select HAS_PCI
>>> +   select PCI_MSI_INTERCEPT
>>>     select HAS_PDX
>>>     select HAS_SCHED_GRANULARITY
>>>     select HAS_UBSAN
>> 
>> This list is sorted alphabetically AFAICT, and new additions should
>> respect that.
> 
> Since this isn't a user visible option, perhaps it wants to be
> HAS_PCI_MSI_INTERCEPT anyway?
> 

Yes I agree with you I will change the name to HAS_PCI_MSI_INTERCEPT in next 
version.

Regards,
Rahul
> Jan
> 


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.