[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/12] x86/p2m: change_entry_type_* hooks are HVM-only


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 29 Apr 2021 17:49:03 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/MM05zdT3QVI80XF6xaBWZr+I6gI6WFhIVfCbdXKHU8=; b=NFFJOftkTURiHwJFg4+8+DRoq79qpl94wEyxWTxj9bc24eTHt1hZzzKFmvf4fPXF4tNDoE7kHTBUGl3RifG3o1Idx6g1k0gq4hnTPhVdc3UuL+jYDi6l0HIgu4udUOFbTSU/rbryQSR/zPe6IpryHrVnro7cu+TB+aiuvC+s11uUS47Xi/ukySYtXdl4izwvFmI8w0LV9UBxv4Xwf8Fyxm9IpPsl0+5lAqyzn1cBo+w/dRBbADirSp5TAtwvIXRGGiV2bszNG654feCv0jAJ51OcNbOsH6NatPMG4LUUKAPB+6j8Nm04GKl1Vh0mjsMhHX3G3ylmID9GrQao4gFBqA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MTl0Hud9PgaLcCRqJ0ANEPSUuYbNMgvQL7hMZSHxereF6bvOYpb1bWm5pt/WG9uWoFaqNMlz2dWGk40GDqFm1qLoNjOQzNFnrcxBOwrhn8SLYOz9CDOpCuIFLsE+RVIbkEbOjgyJhCiJCOCh0B+q7qPUchU9I/hV93uwMy/EP8DtgtdZWOtOnjo755gEeg/munzAiiiG3Yl/uix1HvrsS5WGXUlb5SQq5qURYJUblO81x9cXy60l8oXp8tZY8qbstwLScv07E045iTBo3bCdKbxRrm+7m4L2TzAxPJZMbRFnWistNXUNBs4F2zdF0lbzNCKK7Y1lCYMrDtHnueQviQ==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Thu, 29 Apr 2021 15:49:15 +0000
  • Ironport-hdrordr: A9a23:n4nCeKsfVyycPXtCghj1Y9+V7skCkocji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOkPUsFJ+Ydk3DtHGzJI9vqbHjzTrpBjHk+odmpN pdWoBEIpnLAVB+5PyKmjWQO9wrzMCbtIWhgunDx3lgJDsaIZ1IxS0RMHfoLmRdQg5aCZ0lUL +V4cRarzStEE5nI/iTLH8DQuTFupn3hIvrCCR2WCIPxSuvqXeT6LD8GwWFxRt2aVk/vosK3G DZn2XCl9Oemt6hzBu07R6i0713n5/bxsJHFIiwjKEuW37RoyKJQKgkZLGYpjAyp4iUmQgXuf 3BuQ0pMcg2y165RBD9nTLX1wPt0Ckj5hbZoDf08B+Txr2eNUtKc7s79PwpAyfx0EYusMpx16 hGxQuixtJqJCjNgTjn4JzwXwxq/3DenVMZjeURg3ZDOLFuHYN5kI0F8EtZVLcGES7qgbpXZ9 VGMcDG6P5aNW6ddnDS11MftOCEY3JbJGb0fmEy/ueP0zZWgXRwz05d+dcWlHUN7/sGJ6Vs1q DpNbstrr1IQ8MMBJgTOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCDYvUzvcoPsa WEdGkdmX85ekroB8HL9oZM6ArxTGK0Wimo4t1C5qJ+pqb3SNPQQH2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM+AHiRZ9IKz07XNcOstg2H3KCy/i7ebHCh6j+SrL+NbDtGTErVifUGX 0YRgX+I81G8wSlQXn9jB/NW278e0D28J5qeZKqqtQ7+cwoDMlhowIVgVO26oWgMjtZqJE7e0 N4Pffmn8qA1D2L1FeNy18sFgtWD05T7rmleWhNvxU2P0T9dqtGv92efGtVzWaWPxMXdbKALC dv43BMvY6nJZ2Zwi4vT/i9NHiBsncVrHWWC5EGmqOC4s/hcogiDokvXbFwEQmjLW0mpS9a7E N4LCMUTE7WET3jzY+/ioYPOe3Zf95gxBuwLdVMsnLZv0WErcQpTn8WNgTeB/K/sEILfX55l1 dx+6gQjP68gj6pM3I4m/l9GkZLcn6rDLVPCxmlaI1YlqvwQhx5SX6HiFWh+jgOU1uv039Xp2 T6aQWIZPnAAzNmyzxl+5ev1GkxS0KwUAZbbGtgvYh0CGLc00wDntOjV+6WyWXUUVcMq9tyDB j1JR0IIg1vwNir1Bma3Ba6fE9G+rweesrHDLoidLnP3GiKM4Pgr9AvI9ZkuKxUEPqrntUwFc ibewOTMXfRF/4psjb0ml8VfBNooGIfm/vunCbo5mS5w3IzaMCiQ2hOdvUgPtmG1WLtQLK23I 5ijdQz1NHAUFnZW5q4ybrKdRRDJhnQrWPedZBMlblYuLt3raB0EoXQTFLzpT969Rg6NYPumE sVXaR859n6S89SVsEWYmZH8kEylNKJRXFb8zDeE6swe0oggGTcOM7M673UqaA3CknEvwfoP0 KDmhctpcvtTm+G1bQADbg3LnkTYE8g6G569OfqTfyJNCy6M+VC9kG9KHmzbftUT7WEA6wZql J/78uTl+GaMyr+1wa4h0ohHotet2KmS9i1GgSCBKpB9MG7I02Fhu+y+9Go5Q2HDgeTegAdn8 lIZEYQZsNMhn0ri5A2yDG7Tujyrlg+m1VT7Dl7njfWq9WbyXaeGVsDPRzSg51QUzUWKHSOgM jf+eWT1Xj24lF+qMD+PVYVessLF8kbT4DxISsrNNMZu6Sw+bEzxitEexUjAgcH+WzA9vIj2a 383vrcW+fvUyi1fV0A/CNIHY5ykGggr3paf8238JK6ZUEWG4czcr4Cz5ETlCgsrF75q0AYZV FqsAcj04nWNFzpP3hmD8HV7M3LqQldoLLH8kFkoXVbh0iuh16dsUXkhsrdgQt3k0TN6gt87b iHTDQ/gCxFphdqzKxoPH2KS3PtSxq+QRfK5bptP2ZkB2Apw/gqixSGL7BjrOH881ZZ
  • Ironport-sdr: 6JLJtJaDxiQcVkDKblPaZEk9xHfPDKjKttCHfbTPETRTLoGhqKJ5IcHOJZJi/zLCNZN6vqajB1 vbiGYsHFT+6peC5quJpCTiJQZ4kwX90nco+S28f8L/V3Z2PtH3QhWB5rIGF2TDFYwN0Ow4Ymlm MAnglIY2LycVWcDUy/lJFNfginoO+Jj1a6zKnyY+4uWLHHszGioIlOlh3wjamm/WK1DpC74aLl WX/DBo6m8+01pBhc8HBB8XbyxkL28Ua/MWnAurOzTBrWJOJ9/aGT8mnVToU+wDZ00LYLZGAtn3 0kE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 12, 2021 at 04:08:29PM +0200, Jan Beulich wrote:
> Exclude functions using them from !HVM builds, thus making it possible
> to exclude the hooks as well. Also cover the already unused
> memory_type_changed hook while inserting the #ifdef in the struct.
> 
> While no respective check was there, I can't see how
> XEN_DOMCTL_set_broken_page_p2m could have been meant to work for PV the
> way it is implemented. Restrict this operation to acting on HVM guests.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I see you also make the recalc hook HVM only in a later patch, which
I was going to ask, so:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.